RE: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

[<allen.chen@ite.com.tw>]

Hi

data-lanes is output configuration. Maybe it is not suitable to put data-lanes in input endpoint.
extcon doesn't have output endpoint, so I don't know where to put is better.

-----Original Message-----
From: Neil Armstrong <neil.armstrong@linaro.org> 
Sent: Thursday, September 29, 2022 4:40 PM
To: Allen Chen (陳柏宇) <allen.chen@ite.com.tw>
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Jernej Skrabec <jernej.skrabec@gmail.com>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng@ite.com.tw>; David Airlie <airlied@linux.ie>; open list:DRM DRIVERS <dri-devel@lists.freedesktop.org>; Neil Armstrong <narmstrong@baylibre.com>; open list <linux-kernel@vger.kernel.org>; Robert Foss <robert.foss@linaro.org>; Pin-yen Lin <treapking@chromium.org>; Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw>; Rob Herring <robh+dt@kernel.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Andrzej Hajda <andrzej.hajda@intel.com>; Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

Hi,

On 29/09/2022 03:44, allen wrote:
> From: allen chen <allen.chen@ite.com.tw>
> 
> Add properties to restrict dp output data-lanes and clock.
> 
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> ---
>   .../devicetree/bindings/display/bridge/ite,it6505.yaml | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml 
> b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 833d11b2303a..62b9f2192202 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,6 +52,14 @@ properties:
>       maxItems: 1
>       description: extcon specifier for the Power Delivery
>   
> +  data-lanes:
> +    maxItems: 1
> +    description: restrict the dp output data-lanes with value of 1-4

Can't you use the data-lanes property in the first port endpoint ?

Look at Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml

> +
> +  max-pixel-clock-khz:
> +    maxItems: 1
> +    description: restrict max pixel clock

New vendor specific properties should have the ite, prefix.

> +
>     port:
>       $ref: /schemas/graph.yaml#/properties/port
>       description: A port node pointing to DPI host port node @@ -84,6 
> +92,8 @@ examples:
>               pwr18-supply = <&it6505_pp18_reg>;
>               reset-gpios = <&pio 179 1>;
>               extcon = <&usbc_extcon>;
> +            data-lanes = <2>;
> +            max-pixel-clock-khz = <150000>;
>   
>               port {
>                   it6505_in: endpoint {

Thanks,
Neil