From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752403AbdHOMhP (ORCPT ); Tue, 15 Aug 2017 08:37:15 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3539 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbdHOMhL (ORCPT ); Tue, 15 Aug 2017 08:37:11 -0400 Subject: Re: [PATCH] f2fs: check hot_data for roll-forward recovery To: Jaegeuk Kim , , , References: <20170813043416.89230-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <08788823-d67f-90e0-216b-cac32cb62919@huawei.com> Date: Tue, 15 Aug 2017 20:37:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170813043416.89230-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0202.5992EAF2.00DA,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b0ec57a2bb6038fc749e8a76964e81ef Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/8/13 12:34, Jaegeuk Kim wrote: > We need to check HOT_DATA to truncate any previous data block when doing > roll-forward recovery. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu > --- > fs/f2fs/recovery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index f707d810c87d..9626758bc762 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -317,7 +317,7 @@ static int check_index_in_prev_nodes(struct f2fs_sb_info *sbi, > return 0; > > /* Get the previous summary */ > - for (i = CURSEG_WARM_DATA; i <= CURSEG_COLD_DATA; i++) { > + for (i = CURSEG_HOT_DATA; i <= CURSEG_COLD_DATA; i++) { > struct curseg_info *curseg = CURSEG_I(sbi, i); > if (curseg->segno == segno) { > sum = curseg->sum_blk->entries[blkoff]; >