From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=178.251.229.89 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792507295; b=eL6V59zppsoW+GQPLhDgp8TNtslzlIUxwr7WkDTRrCeJxzxWLv8dzWpv+rlNbcl1GLpw eQzHgmQkRohHNEHuVwGzZxTXfO3oOo3bmslwwzK10fnS8mPMszL1DMrqADVLWFtrhjfA0 cCSxQREFyLJ7U54dt0EfTl28V2SLiZf3cxxYTmcR5VignBBG3SCiDIQXmSFXChzXIAJ1e cDA84aGr2inswKDKtHiNXVa0W3jN2lp1I+e2cvU4a5xP7IkOSWCvlT8J4LRYKd8cijtqQ NatjOQe374ynhrYNOsMV8Vidwd7xOdnlZyeRgU31mkGCxqihxuTroQcGfxCHkja1Ueg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792507295; h=DMARC-Filter:Received:DKIM-Signature:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding:X-Last-TLS-Session-Version; bh=obZm6fYxDBkvsgsqatxSsEtySSvVtNol2JAwOQdxyP8=; b=5nfDMAA7aNzY/TRYejRL6ZQsdK6RoK09YW2g+CHcGy+pyPEf4N+VhJX2YmI2zRqQqUW0 4oB7tg+6YYKXpfVSUKD6nfSACozOz/ykT7VKRNMeTpMtPO+eVdgnbIJ+kxV15EmocZAnv WMAfkirrBiITwVqm8V7GyN5+Rjn8nSD4ww9dRaQkiXEti53GMfWVo7K39MpieVRMXJWaC 8SXIGPDeF81ojI3kRVJl93NEtt9c+Eo2YOGOhsI4xmn3EUIN5053PYqqb3HxJh8QXfYvk RQ8skuB5WDNQrXDNP/gVR+xwiSd7SY9bGeyT+qyjth+nX4grTaGsQqEskClFF2sZhlw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass header.d=nabladev.com header.i=@nabladev.com header.a=rsa-sha256 header.s=dkim header.b=KZIpTYXr; arc=none smtp.remote-ip=178.251.229.89 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB719606A335; Tue, 20 Oct 2026 14:41:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EB719606A335 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=nabladev.com header.i=@nabladev.com header.a=rsa-sha256 header.s=dkim header.b=KZIpTYXr Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1B4321087B7; Tue, 20 Oct 2026 16:41:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1792507288; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=obZm6fYxDBkvsgsqatxSsEtySSvVtNol2JAwOQdxyP8=; b=KZIpTYXrLOZeb0sWyDSqtRamX8N7fjSjraNOOVWlArE4s24uLb0AYU+UyW1juMdh/ZkGJd smxH2yDoOk8ZkWPYrAiSAquObI+DVKplBXgsANRlvr7sYUP4Jq9rFR2aAtRObeqWtj4A65 RIO78yCfyJvsRNMnGKyQP8ykSis8A8fjfhfA/BOsenJ+s+NQBhZ4B35lI0xWX88L385IAs 8w5WzVK2R0jWVWrmM5Vc1ZBrbfkuyd1lE0WYd376dqn2pH07IeLYOdBDMG08IjIxxi74ym m3yamkl3pp9LxSRe41HKBvL1u484D9TJtuLQRm8JonNtwsCrlDMhPTIQBCzmJQ== Message-ID: <087bdc09-cf57-444e-aa29-f977998b0024@nabladev.com> Date: Tue, 20 Oct 2026 16:41:20 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] dt-bindings: spi: Add separate binding for dh,dhcom-board To: Christoph Niedermaier , Conor Dooley Cc: "Frank.Li@oss.nxp.com" , "imx@lists.linux.dev" , Guenter Roeck , Jonathan Cameron , Frank Li , Ashish Yadav , Colin Huang , Sanman Pradhan , Thorsten Blum , Troy Mitchell , Eddie James , Rodrigo Gobbi , "open list:SPI SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , kernel , open list , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley References: <20261016205718.877668-1-Frank.Li@oss.nxp.com> <20261018-freeway-twitch-e813208aa9af@spud> <20261019-cycling-unnatural-c1adbfb5c9d9@spud> <05e66d8f57a44c9aa87cac1c35e82184@dh-electronics.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <05e66d8f57a44c9aa87cac1c35e82184@dh-electronics.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 10/20/26 3:33 PM, Christoph Niedermaier wrote: Hello Christoph, [...] >>>>>> +++ b/Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml >>>>>> @@ -0,0 +1,46 @@ >>>>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>>>>> +%YAML 1.2 >>>>>> +--- >>>>>> +$id: http://devicetree.org/schemas/spi/dh,dhcom-board.yaml# >>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>>> + >>>>>> +title: DH electronics GmbH on-board CPLD trivial SPI device >>>>> >>>>> This does not look quite right, since compatible this is used only on: >>>>> >>>>> arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts >>>>> >>>>> model = "DH electronics i.MX6ULL DHCOR on maveo box"; >>>>> compatible = "marantec,imx6ull-dhcor-maveo-box", >>>>> "dh,imx6ull-dhcor-som", >>>>> >>>>> So the whole >>>>> >>>>> spidev@0 { >>>>> compatible = "dh,dhcom-board"; >>>>> reg = <0>; >>>>> spi-cpha; >>>>> spi-cpol; >>>>> spi-max-frequency = <54000000>; >>>>> }; >>>>> >>>>> Should probably use a different compatible. >>>>> >>>>> Christoph, what device is this on this board ? > > There is no device connected to these pins, only an extension connector. > The "dh,dhcom-board" device was used only to test the hardware and was > unfortunately forgotten to be removed. In the production version, no > device is connected to this interface. It should actually be removed. > Should I create a patch for this? In that case, I would suggest to remove this whole spidev@0 from this DT with proper Fixes: tag . [...] >>> But in any case, the compatible string should likely be fixed here, this >>> does not seem right. The dh,dhcom-board was describing some CPLD/FPGA on one >>> of the evalboards. >> >> Ye I don't disagree there. "dhcom-board" seems not nearly specific >> enough about what the device is. > > There isn't actually a user for this device, see above. It's only used downstream > at DH electronics for a connection to a PSoC chip. But even for this purpose, it's > not being used correctly. What should we do now? I think this patch can also be dropped, the dh,dhcom-board would be left as a legacy compatible for the CPLD/FPGA on the DHCOM PDK2 board (where it is not described yet, but should be) , and the dh-dhcom-board should remain a trivial device, since the CPLD/FPGA is connected via some parallel bus if I recall it right ?