From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2022C433B4 for ; Wed, 12 May 2021 09:36:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 979D261278 for ; Wed, 12 May 2021 09:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbhELJhq (ORCPT ); Wed, 12 May 2021 05:37:46 -0400 Received: from pegase2.c-s.fr ([93.17.235.10]:37967 "EHLO pegase2.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbhELJhm (ORCPT ); Wed, 12 May 2021 05:37:42 -0400 Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Fg8nF5JGxz9sfF; Wed, 12 May 2021 11:36:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B4dS7uK_X9-j; Wed, 12 May 2021 11:36:33 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Fg8nF4JH0z9sf6; Wed, 12 May 2021 11:36:33 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 77ECA8B7E5; Wed, 12 May 2021 11:36:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id NJvqNYHf9qcZ; Wed, 12 May 2021 11:36:33 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D64DE8B7DF; Wed, 12 May 2021 11:36:32 +0200 (CEST) Subject: Re: arch/powerpc/kernel/optprobes.c:34:1: error: unused function 'is_kprobe_ppc_optinsn_slot' To: Nathan Chancellor , kernel test robot , Nick Desaulniers Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Michael Ellerman References: <202105120059.uTLH58Lm-lkp@intel.com> <48747467-cb93-c66d-4cf9-097be0568488@csgroup.eu> <208186f3-aab0-d94e-bcf4-8347983cc1a6@kernel.org> From: Christophe Leroy Message-ID: <0885f8b8-fea5-3fb0-42d7-b73e862a8c47@csgroup.eu> Date: Wed, 12 May 2021 11:36:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <208186f3-aab0-d94e-bcf4-8347983cc1a6@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 11/05/2021 à 20:46, Nathan Chancellor a écrit : > On 5/11/2021 9:47 AM, Christophe Leroy wrote: >> Hi All, >> >> Le 11/05/2021 à 18:30, kernel test robot a écrit : >>> Hi Christophe, >>> >>> First bad commit (maybe != root cause): >>> >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>> head:   1140ab592e2ebf8153d2b322604031a8868ce7a5 >>> commit: eacf4c0202654adfa94bbb17b5c5c77c0be14af8 powerpc: Enable OPTPROBES on PPC32 Ok, the problem appears on PPC32 with that patch, but it must have been there on PPC64 since the implementation of optprobes with commit 51c9c0843993 ("powerpc/kprobes: Implement Optprobes") >>> date:   3 weeks ago >>> config: powerpc-randconfig-r033-20210511 (attached as .config) >>> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project >>> a0fed635fe1701470062495a6ffee1c608f3f1bc) >> >> A clang issue ? >> >> >>> reproduce (this is a W=1 build): >>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O >>> ~/bin/make.cross >>>          chmod +x ~/bin/make.cross >>>          # install powerpc cross compiling tool for clang build >>>          # apt-get install binutils-powerpc-linux-gnu >>>          # >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=eacf4c0202654adfa94bbb17b5c5c77c0be14af8 >>> >>>          git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>>          git fetch --no-tags linus master >>>          git checkout eacf4c0202654adfa94bbb17b5c5c77c0be14af8 >>>          # save the attached .config to linux build tree >>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=powerpc >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kernel test robot >>> >>> All errors (new ones prefixed by >>): >>> >>>>> arch/powerpc/kernel/optprobes.c:34:1: error: unused function 'is_kprobe_ppc_optinsn_slot' >>>>> [-Werror,-Wunused-function] >>>     DEFINE_INSN_CACHE_OPS(ppc_optinsn); >>>     ^ >>>     include/linux/kprobes.h:306:20: note: expanded from macro 'DEFINE_INSN_CACHE_OPS' >>>     static inline bool is_kprobe_##__name##_slot(unsigned long addr)        \ >> >> That's a 'static inline', shouldn't generate an 'unused function' warning. > This is a W=1 build, which means that "inline" does not silence unused function warnings with clang > because of commit 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions for W=1 > build"). Ok, I didn't know that. > > Cheers, > Nathan > >>>                        ^ >>>     :16:1: note: expanded from here >>>     is_kprobe_ppc_optinsn_slot >>>     ^ >>>     1 error generated. >>> >>> >>> vim +/is_kprobe_ppc_optinsn_slot +34 arch/powerpc/kernel/optprobes.c >>> >>> 51c9c084399352 Anju T 2017-02-08  20 >>> 51c9c084399352 Anju T 2017-02-08  21  #define TMPL_CALL_HDLR_IDX    \ >>> 51c9c084399352 Anju T 2017-02-08  22 (optprobe_template_call_handler - optprobe_template_entry) >>> 51c9c084399352 Anju T 2017-02-08  23  #define TMPL_EMULATE_IDX    \ >>> 51c9c084399352 Anju T 2017-02-08  24 (optprobe_template_call_emulate - optprobe_template_entry) >>> 51c9c084399352 Anju T 2017-02-08  25  #define TMPL_RET_IDX        \ >>> 51c9c084399352 Anju T 2017-02-08  26      (optprobe_template_ret - optprobe_template_entry) >>> 51c9c084399352 Anju T 2017-02-08  27  #define TMPL_OP_IDX        \ >>> 51c9c084399352 Anju T 2017-02-08  28 (optprobe_template_op_address - optprobe_template_entry) >>> 51c9c084399352 Anju T 2017-02-08  29  #define TMPL_INSN_IDX        \ >>> 51c9c084399352 Anju T 2017-02-08  30      (optprobe_template_insn - optprobe_template_entry) >>> 51c9c084399352 Anju T 2017-02-08  31  #define TMPL_END_IDX        \ >>> 51c9c084399352 Anju T 2017-02-08  32      (optprobe_template_end - optprobe_template_entry) >>> 51c9c084399352 Anju T 2017-02-08  33 >>> 51c9c084399352 Anju T 2017-02-08 @34  DEFINE_INSN_CACHE_OPS(ppc_optinsn); >>> 51c9c084399352 Anju T 2017-02-08  35 >>> >>> :::::: The code at line 34 was first introduced by commit >>> :::::: 51c9c0843993528bffc920c54c2121d9e6f8b090 powerpc/kprobes: Implement Optprobes >>> >>> :::::: TO: Anju T >>> :::::: CC: Michael Ellerman >>> >>> --- >>> 0-DAY CI Kernel Test Service, Intel Corporation >>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >>> >>