mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Rigel Di Scala <zedr@zedr.com>, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	rigeld@gmail.com
Subject: Re: [PATCH] Staging: rtl8192e: fix a brace style issue
Date: Fri, 14 Oct 2022 18:56:08 +0200	[thread overview]
Message-ID: <08887454-0ea8-107d-196d-b21b46e357da@gmail.com> (raw)
In-Reply-To: <20221012211612.75871-1-zedr@zedr.com>

On 10/12/22 23:16, Rigel Di Scala wrote:
> Fixed a coding style issue affecting a conditional if statement.
> 
> Signed-off-by: Rigel Di Scala <zedr@zedr.com>
> ---
>   drivers/staging/rtl8192e/rtl819x_BAProc.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 19d13b3fc..e932ad1a9 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -180,11 +180,10 @@ static void rtllib_send_ADDBAReq(struct rtllib_device *ieee, u8 *dst,
>   
>   	skb = rtllib_ADDBA(ieee, dst, pBA, 0, ACT_ADDBAREQ);
>   
> -	if (skb) {
> +	if (skb)
>   		softmac_mgmt_xmit(skb, ieee);
> -	} else {
> +	else
>   		netdev_dbg(ieee->dev, "Failed to generate ADDBAReq packet.\n");
> -	}
>   }
>   
>   static void rtllib_send_ADDBARsp(struct rtllib_device *ieee, u8 *dst,

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>


      reply	other threads:[~2022-10-14 16:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 21:16 Rigel Di Scala
2022-10-14 16:56 ` Philipp Hortmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08887454-0ea8-107d-196d-b21b46e357da@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=rigeld@gmail.com \
    --cc=zedr@zedr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®