mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
To: Haipeng Lin <jimmie.lin@gmail.com>,
	Manivannan Sadhasivam <mani@kernel.org>
Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, daleyo@gmail.com,
	Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH RFC v2] bus: mhi: host: pci_generic: Add MBIM-mode config for generic SDX65
Date: Fri, 20 Nov 2026 09:37:57 -0700	[thread overview]
Message-ID: <088d0be9-5d45-4454-b160-efff83e7a647@oss.qualcomm.com> (raw)
In-Reply-To: <93f7aabc-4a92-4d3c-a6af-a84b461c0e0c@gmail.com>

On 11/16/2026 8:08 PM, Haipeng Lin wrote:
> On 11/13/26 1:53 PM, Jeff Hugo wrote:
>> On 11/10/2026 6:06 PM, Haipeng Lin via B4 Relay wrote:
>>> From: Haipeng Lin <jimmie.lin@gmail.com>
> [...]>> Boards with a Qualcomm-ID modem in MBIM mode have so far been told
>>> apart by subsystem ID, like the SC8280XP CRD's SDX55 (17cb:010c).
>>> This modem carries the generic subsystem ID, so select an MBIM
>>> configuration by machine compatible instead.
>> I'd like it if we could query the hardware to determine if it is in this mode as maybe one of these systems has a SDX65 dongle attached where this workaround does not apply.  However, I am failing to identify such a mechanism so what you have proposed seem to be the best solution so far.
>>
>> Unless someone identifies a better idea, this seems reasonable given the situation.
>>
>> -Jeff
> 
> Hi Jeff,
> 
> Thank you for your reply. I tried to look for a hardware hint since we
> have to select the channel layout before opening a channel (so that
> can't be the way to select MBIM, I think). The oem_pk_hash on this SP11
> SDX65 is non-zero (12 words) so it could potentially tell this module
> apart from a dongle, but using it would mean reading BHI before the
> controller is registered plus adding a table of hashes in the driver.
> 
> I can try the hash route if preferred. The machine match is simpler
> although it wouldn't cover the situation e.g., a SDX65 dongle is attach-
> ed via PCIe tunneling/USB4 you mentioned...
No, I don't think that is better. The pk_hash is just what firmware 
signature the device will accept as valid, but does not directly relate 
to the capabilities of the firmware or hardware. Trying to tie this 
workaround to that feels like an abuse of the meaning of that register, 
which I would be concerned would lead to some horribly broken corner case.

Without additional data, I think you move forward with what you have but 
it is really up to Mani if he'd accept this or would like something 
different.

-Jeff

      reply	other threads:[~2026-11-20 16:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  1:06 Haipeng Lin via B4 Relay
2026-11-13 18:53 ` Jeff Hugo
2026-11-17  3:08   ` Haipeng Lin
2026-11-20 16:37     ` Jeff Hugo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=088d0be9-5d45-4454-b160-efff83e7a647@oss.qualcomm.com \
    --to=jeff.hugo@oss.qualcomm.com \
    --cc=daleyo@gmail.com \
    --cc=jimmie.lin@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mhi@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®