From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4125E355050 for ; Wed, 18 Mar 2026 18:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773857559; cv=none; b=LYhd4Uui4IUe8pU3JJYuF+et4RRx6dOB4W4KxkoyniMSHm3ofTQFcZTmDnkF2dEFXeHzk3efcj8EfDZYiZeCq0tv6ypePV5v4GRV7LvKbjlDRjIaRWAepgTGoPlYEBCdTvOhBYfNWqqeIkeXo8RAc1+jQ2eRcUIVXCCyA4J6vaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773857559; c=relaxed/simple; bh=0UrZRLkimMDCcD2T3nHPvaaxC017oNtzYkFihTplPZg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l4YUeZjUJzLiqNcVt470IG9zfh0Rivwjmqgvmlx67mD/nngN+XE6fB8th09ASK2//o2lb+lbzZVITLXQlkr2Zco/I9NfaDRH6KzZHC7FD3cr2Hu6RlYan//3rie4PmXkhLczanBP/6bLcoZDSQ6zS4zjmZsuER9MFbdfiFptxtc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=eJ7e38SL; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="eJ7e38SL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1773857556; bh=0UrZRLkimMDCcD2T3nHPvaaxC017oNtzYkFihTplPZg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eJ7e38SLJwx0CvRCMIqYzBnZpiwRHLdICvBTEYXxTx0u+ZM72avUXVBd/s1M+pK2Z BD8tH2jG1UbJ0JqlA4EwnHyT0Mz1bUSqa1iQ0MdI+9St5y58zBZMOgq+8+Z+M3Cjfo dGveAdC9BfDQIBXWWaoBTvMABj3KxsFWD6xXGjxhOjS89NT/xJRzsAP8RMZ05a5Ik+ NIIL3erXZdw0pEo9PLOBxI0Ul1MsRxWA1+K/FfFdqzOsLSstB3e1ip2RrXqwafpP0r EKbJEjVOPrbGz1uotCbVCuhLleTufJSah55GnFjxpDNidDjIArYFJr8wZmcMut9jnv xxg0Xn6N7c7tQ== Received: from [192.168.1.90] (unknown [86.123.23.225]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id BDEF717E0ED6; Wed, 18 Mar 2026 19:12:35 +0100 (CET) Message-ID: <0895dfa0-9527-41b1-b991-a2bd6e0c549b@collabora.com> Date: Wed, 18 Mar 2026 20:12:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/bridge: dw-hdmi-qp: fix multi-channel audio output To: Luca Ceresoli , Christian Hewitt Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Detlev Casanova , Douglas Anderson , Andy Yan , Sugar Zhang , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260228112822.4056354-1-christianshewitt@gmail.com> <00EE3E21-F614-429B-ACB6-19AF64CF74B3@gmail.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Luca, On 3/17/26 7:35 PM, Luca Ceresoli wrote: > Hello Christian, Cristian, Jonas, > > On Tue Mar 17, 2026 at 5:49 PM CET, Christian Hewitt wrote: >>> On 17 Mar 2026, at 8:16 pm, Luca Ceresoli wrote: >>> >>> Hello Christian, >>> >>> On Sat Feb 28, 2026 at 12:28 PM CET, Christian Hewitt wrote: >>>> From: Jonas Karlman >>>> >>>> Channel Allocation (PB4) and Level Shift Information (PB5) are >>>> configured with values from PB1 and PB2 due to the wrong offset >>>> being used. This results in missing audio channels or incorrect >>>> speaker placement when playing multi-channel audio. >>>> >>>> Use the correct offset to fix multi-channel audio output. >>>> >>>> Fixes: fd0141d1a8a2 ("drm/bridge: synopsys: Add audio support for dw-hdmi-qp") >>>> Reported-by: Christian Hewitt >>>> Signed-off-by: Jonas Karlman >>>> Signed-off-by: Christian Hewitt >>>> Reviewed-by: Cristian Ciocaltea >>> >>> While applying this patch to drm-mics-fixes, checkpatch complains: >>> >>> -:14: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report >>> >>> You can send v3 with the link, or just reply with the link and I'll take >>> care of adding it to the commit message. >> >> Apologies, it looks like use of Reported-by was tightened since I last >> used it, and there’s no official report anywhere I can link to (it was >> all done in private channels) so better to just drop it from the v2 patch >> if that’s possible? - if not I can send a v3 without it. > > Thanks for the quick feedback. > > I applied keeping the commit message as is. In lack of a public discussion > I guess the 'Reported-by' is somewhat informative anyway. I read the > checkpatch as a general suggestion, not a hard rule. > > So now this patch is on drm-misc-fixes, but drm-misc-fixes and > drm-misc-next are now conflicting because of other changes by Cristian > Ciocaltea applied in the meanwhile to drm-misc-next, and particularly > commit 3ea699b56d31 ("drm/bridge: dw-hdmi-qp: Rework Audio InfoFrame > handler"). > > Cristian, Christian (heh), Jonas, could you please check whether the code > on drm-misc-next has or not the bug that is fixed here? And if it still > has, send a fix based on current drm-misc-next? The conflicting commit in drm-misc-next (i.e. 3ea699b56d31) implicitly resolves this audio related issue as well, hence there is no need for any further action. Regards, Cristian