From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
robh+dt@kernel.org, mathieu.poirier@linaro.org,
mike.leach@linaro.org, leo.yan@linaro.org,
alexander.shishkin@linux.intel.com, andy.gross@linaro.org,
david.brown@linaro.org, vivek.gautam@codeaurora.org,
jhugo@codeaurora.org, dianders@chromium.org, sboyd@kernel.org,
bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
mark.rutland@arm.com, marc.w.gonzalez@free.fr
Cc: rnayak@codeaurora.org, sibis@codeaurora.org,
tingwei@codeaurora.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table
Date: Fri, 1 Feb 2019 06:20:50 +0530 [thread overview]
Message-ID: <0896a3f6-e2c3-49a0-8420-5127972b410b@codeaurora.org> (raw)
In-Reply-To: <2801964a-ba35-9393-593b-c5108a8825e4@codeaurora.org>
On 2/1/2019 6:17 AM, Sai Prakash Ranjan wrote:
> On 1/31/2019 11:31 PM, Suzuki K Poulose wrote:
>>
>>
>> On 31/01/2019 14:22, Sai Prakash Ranjan wrote:
>>> Add UCI table for coresight CPU debug module. This patch adds
>>> the UCI entries for Kryo CPUs found on MSM8996 which shares
>>> the same PIDs as ETMs.
>>>
>>> Without this, below error is observed on MSM8996:
>>
>> nit: Subject doesn't match the patch contents. You could simply say :
>>
>> coresight: cpu-debug: Add support for Qualcomm Kryo
>>
>
> Done.
>
>>>
>>> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c
>>> b/drivers/hwtracing/coresight/coresight-cpu-debug.c
>>> index e8819d750938..915d86a39cee 100644
>>> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
>>> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
>>> @@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
>>> return 0;
>>> }
>>> +static struct amba_cs_uci_id uci_id_debug[] = {
>>
>> As Stephen mentioned, this must be "const".
>>
>> Rest looks fine.
>
> Done.
>
Also it should be changed in Mike's patch I suppose or else:
In file included from
drivers/hwtracing/coresight/coresight-cpu-debug.c:26:0:
drivers/hwtracing/coresight/coresight-cpu-debug.c:672:29: warning:
initialization discards ‘const’ qualifier from pointer target type
[-Wdiscarded-qualifiers]
CS_AMBA_UCI_ID(0x000f0205, uci_id_debug), /* Qualcomm Kryo */
^
drivers/hwtracing/coresight/coresight-priv.h:192:11: note: in definition
of macro ‘CS_AMBA_UCI_ID’
.data = uci_ptr \
^~~~~~~
drivers/hwtracing/coresight/coresight-cpu-debug.c:673:29: warning:
initialization discards ‘const’ qualifier from pointer target type
[-Wdiscarded-qualifiers]
CS_AMBA_UCI_ID(0x000f0211, uci_id_debug), /* Qualcomm Kryo */
^
drivers/hwtracing/coresight/coresight-priv.h:192:11: note: in definition
of macro ‘CS_AMBA_UCI_ID’
.data = uci_ptr \
^~~~~~~
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2019-02-01 0:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 14:22 [PATCHv6 0/6] Add coresight support for SDM845, MSM8998 and MSM8996 Sai Prakash Ranjan
2019-01-31 14:22 ` [PATCHv6 1/6] arm64: dts: qcom: sdm845: Add Coresight support Sai Prakash Ranjan
2019-01-31 14:22 ` [PATCHv6 2/6] arm64: dts: qcom: msm8998: " Sai Prakash Ranjan
2019-01-31 14:22 ` [PATCHv6 3/6] arm64: dts: qcom: msm8996: " Sai Prakash Ranjan
2019-01-31 14:22 ` [PATCHv6 4/6] coresight: etm4x: Add support to enable ETMv4.2 Sai Prakash Ranjan
2019-01-31 14:22 ` [PATCHv6 5/6] coresight: etm4x: Add ETM PIDs for SDM845 and MSM8996 Sai Prakash Ranjan
2019-01-31 14:22 ` [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table Sai Prakash Ranjan
2019-01-31 16:31 ` Stephen Boyd
2019-02-01 0:45 ` Sai Prakash Ranjan
2019-01-31 18:01 ` Suzuki K Poulose
2019-02-01 0:47 ` Sai Prakash Ranjan
2019-02-01 0:50 ` Sai Prakash Ranjan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0896a3f6-e2c3-49a0-8420-5127972b410b@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jhugo@codeaurora.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome