From: sathyanarayanan.kuppuswamy@linux.intel.com
To: bhelgaas@google.com, corbet@lwn.net
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Ashok Raj <ashok.raj@intel.com>,
Keith Busch <keith.busch@intel.com>
Subject: [PATCH v1 4/5] PCI/ATS: For PF/VF skip ATS initalization if spec check failed
Date: Wed, 6 Mar 2019 14:11:17 -0800 [thread overview]
Message-ID: <0898a9bd92cfcf2ab07e5dd5ba59dc181b88edec.1551909341.git.sathyanarayanan.kuppuswamy@linux.intel.com> (raw)
In-Reply-To: <cover.1551909341.git.sathyanarayanan.kuppuswamy@linux.intel.com>
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Don't initialize ATS for VF/PF devices if the ATS Capability
implementaion is not aligned with PCIe spec r4.0 sec 9.3.7.8.
Cc: Ashok Raj <ashok.raj@intel.com>
Cc: Keith Busch <keith.busch@intel.com>
Suggested-by: Ashok Raj <ashok.raj@intel.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
drivers/pci/ats.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c
index 28bbf7dad425..11299d93a59a 100644
--- a/drivers/pci/ats.c
+++ b/drivers/pci/ats.c
@@ -23,6 +23,12 @@ void pci_ats_init(struct pci_dev *dev)
if (pci_ats_disabled())
return;
+ /* If ATS Cap is invalid then return */
+ if (dev->is_virtfn || dev->is_physfn) {
+ if (dev->invalid_cap & PCI_IOV_INVALID_ATS)
+ return;
+ }
+
pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ATS);
if (!pos)
return;
--
2.20.1
next prev parent reply other threads:[~2019-03-06 22:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1551909341.git.sathyanarayanan.kuppuswamy@linux.intel.com>
2019-03-06 22:11 ` [PATCH v1 1/5] PCI/IOV: Add support to verify PF/VF spec compliance sathyanarayanan.kuppuswamy
2019-04-19 13:59 ` Bjorn Helgaas
2019-04-19 17:37 ` Raj, Ashok
2019-04-19 18:41 ` sathyanarayanan kuppuswamy
2019-04-23 22:11 ` Bjorn Helgaas
2019-04-23 22:57 ` Raj, Ashok
2019-03-06 22:11 ` [PATCH v1 2/5] PCI/ATS: Fix PRI PF/VF dependency issues sathyanarayanan.kuppuswamy
2019-03-06 22:11 ` [PATCH v1 3/5] PCI/ATS: Fix PASID " sathyanarayanan.kuppuswamy
2019-03-06 22:11 ` sathyanarayanan.kuppuswamy [this message]
2019-03-06 22:11 ` [PATCH v1 5/5] PCI/ATS: Fix ATS " sathyanarayanan.kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0898a9bd92cfcf2ab07e5dd5ba59dc181b88edec.1551909341.git.sathyanarayanan.kuppuswamy@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=keith.busch@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®