Re: [PATCH v3 3/5] ASoC: dt-bindings: wm8904: Add DMIC, GPIO, MIC and EQ support

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

On Tue, Mar 11, 2025 at 09:42:45AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Mar 07, 2025 at 02:52:42PM +0100, Francesco Dolcini wrote:

> > +  wlf,in1l-as-dmicdat1:
> > +    type: boolean
> > +    description:
> > +      Use IN1L/DMICDAT1 as DMICDAT1, enabling the DMIC input path.

> > +  wlf,in1r-as-dmicdat2:
> > +    type: boolean
> > +    description:
> > +      Use IN1R/DMICDAT2 as DMICDAT2, enabling the DMIC input path.

> Are these two properties mutually exclusive?

No, it's one property each for the left and right channels.

> > +  wlf,drc-cfg-names:
> > +    $ref: /schemas/types.yaml#/definitions/string-array

> No constraints, so I assume you can have here any number of items?

Yes.

> > +    description:
> > +      List of strings for the available DRC modes.

> Why the actual names are not defined? Why do you need this property if
> they are not defined (thus driver does not request this by the name)?

The driver displays the list of names to the end user for them to choose
between.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]