From: Markus Elfring <Markus.Elfring@web.de>
To: Xiyu Yang <xiyuyang19@fudan.edu.cn>,
Xin Tan <tanxin.ctf@gmail.com>,
linux-rdma@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Bernard Metzler <bmt@zurich.ibm.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kangjie Lu <kjlu@umn.edu>,
Yuan Zhang <yuanxzhang@fudan.edu.cn>
Subject: Re: [PATCH] RDMA/siw: Fix potential siw_mem refcnt leak in nr_add_node
Date: Wed, 15 Apr 2020 13:00:21 +0200 [thread overview]
Message-ID: <08a5af5b-96f8-837c-ff4b-814901ad9ed5@web.de> (raw)
> The issue happens in one error path of siw_fastreg_mr(). When "base_mr"
> equals to NULL but "mem" is not NULL, the function forgets to decrease
> the refcnt increased by siw_mem_id2obj() and causes a refcnt leak.
How do you think about to mention the terms “exception handling”
and “reference counting” in the commit message?
Would you like to add the tag “Fixes” to the change description?
Regards,
Markus
next reply other threads:[~2020-04-15 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 11:00 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-15 8:39 Xiyu Yang
2020-04-15 9:19 ` Bernard Metzler
2020-04-15 14:09 ` Jason Gunthorpe
2020-04-15 14:16 ` Bernard Metzler
2020-04-15 14:27 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08a5af5b-96f8-837c-ff4b-814901ad9ed5@web.de \
--to=markus.elfring@web.de \
--cc=bmt@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tanxin.ctf@gmail.com \
--cc=xiyuyang19@fudan.edu.cn \
--cc=yuanxzhang@fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®