From: Paulo Alcantara <pc@manguebit.org>
To: shyckless@gmail.com, linkinjeon@kernel.org
Cc: ematsumiya@suse.de, sprasad@microsoft.com,
linux-cifs@vger.kernel.org, bharathsm@microsoft.com,
ronniesahlberg@gmail.com, samba-technical@lists.samba.org,
daniel.birtwhistle@gehealthcare.com,
linux-kernel@vger.kernel.org, smfrench@gmail.com,
dhowells@redhat.com, tom@talpey.com
Subject: Re: [PATCH v2 2/2] smb: client: don't use read data that failed signature verification
Date: Wed, 18 Nov 2026 19:02:57 -0300 [thread overview]
Message-ID: <08a684fb935ae094d70dfc3111c03054@manguebit.org> (raw)
In-Reply-To: <20261116-smb2-sign-v2-2-a823a90d0db4@gmail.com>
Suyuan Wang via B4 Relay <devnull+shyckless.gmail.com@kernel.org>
writes:
> From: Suyuan Wang <stevewong@hust.edu.cn>
>
> When smb2_readv_callback() finds a bad signature, it sets the error in
> rdata->result but leaves rdata->got_bytes alone. Further down, a short
> read that reaches the remote EOF clears the error again:
>
> size_t trans = rdata->subreq.transferred + rdata->got_bytes;
> if (trans < rdata->subreq.len &&
> rdata->subreq.start + trans >= netfs_read_remote_i_size(inode)) {
> rdata->result = 0;
>
> and got_bytes is then added to subreq.transferred. So the last part of a
> file, or all of a small one, is returned even though its signature is
> wrong.
>
> Clear got_bytes when the signature check fails, as the retry path in the
> same function already does.
Please check sashiko's review.
prev parent reply other threads:[~2026-11-18 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 4:06 [PATCH v2 0/2] smb: client: don't use SMB2 responses that fail " Suyuan Wang via B4 Relay
2026-11-16 4:06 ` [PATCH v2 1/2] smb: client: fail SMB2 responses with a bad signature Suyuan Wang via B4 Relay
2026-11-18 22:02 ` Paulo Alcantara
2026-11-16 4:06 ` [PATCH v2 2/2] smb: client: don't use read data that failed signature verification Suyuan Wang via B4 Relay
2026-11-18 22:02 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08a684fb935ae094d70dfc3111c03054@manguebit.org \
--to=pc@manguebit.org \
--cc=bharathsm@microsoft.com \
--cc=daniel.birtwhistle@gehealthcare.com \
--cc=dhowells@redhat.com \
--cc=ematsumiya@suse.de \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=shyckless@gmail.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®