From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Yeoreum Yun <yeoreum.yun@arm.com>
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, rafael@kernel.org,
pavel@kernel.org, catalin.marinas@arm.com, will@kernel.org,
anshuman.khandual@arm.com, ryan.roberts@arm.com,
yang@os.amperecomputing.com, joey.gouly@arm.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2] arm64: fix cleared E0POE bit after cpu_suspend()/resume()
Date: Mon, 12 Jan 2026 10:36:48 +0100 [thread overview]
Message-ID: <08af7447-1ea8-4513-907e-1902a661261f@arm.com> (raw)
In-Reply-To: <aV6YPyLV1quaOkyw@e129823.arm.com>
On 07/01/2026 18:30, Yeoreum Yun wrote:
> Hi Kevin,
>
> [...]
>
>>> @@ -144,6 +148,10 @@ SYM_FUNC_START(cpu_do_resume)
>>> msr tcr_el1, x8
>>> msr vbar_el1, x9
>>> msr mdscr_el1, x10
>>> +alternative_if ARM64_HAS_TCR2
>>> + ldr x2, [x0, #104]
>>> + msr REG_TCR2_EL1, x2
>>> +alternative_else_nop_endif
>> Maybe this could be pushed further down cpu_do_resume, next to DISR_EL1
>> maybe (since it's also conditional)? Otherwise the diff LGTM:
> Sorry but IIUC, currently there is no DISR_EL1 save/restore not yet?
It's zeroed at the end of cpu_do_resume, but yes it's not saved.
> and I think current place is good where before restore SCTLR_EL1 which
> before MMU enabled.
Fair enough, and I can see that other registers are not restored in the
same order as they're saved, so we're not breaking an existing pattern.
Either way Catalin took the patch so this is settled :)
- Kevin
next prev parent reply other threads:[~2026-01-12 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 16:21 Yeoreum Yun
2026-01-07 16:54 ` Kevin Brodsky
2026-01-07 17:30 ` Yeoreum Yun
2026-01-12 9:36 ` Kevin Brodsky [this message]
2026-01-08 5:25 ` Anshuman Khandual
2026-01-09 18:00 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08af7447-1ea8-4513-907e-1902a661261f@arm.com \
--to=kevin.brodsky@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®