From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3492C3524D for ; Wed, 5 Feb 2020 07:39:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9289B2085B for ; Wed, 5 Feb 2020 07:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727937AbgBEHjY (ORCPT ); Wed, 5 Feb 2020 02:39:24 -0500 Received: from mx2.suse.de ([195.135.220.15]:36474 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725497AbgBEHjX (ORCPT ); Wed, 5 Feb 2020 02:39:23 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2DCE4B05C; Wed, 5 Feb 2020 07:39:21 +0000 (UTC) Subject: Re: [PATCH] drm/virtio: fix vblank handling To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: olvaffe@gmail.com, gurchetansingh@chromium.org, David Airlie , Daniel Vetter , "open list:VIRTIO GPU DRIVER" , open list References: <20200205065312.15790-1-kraxel@redhat.com> From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= mQENBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAG0J1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPokBVAQTAQgAPhYh BHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsDBQkDwmcABQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAAAoJEGgNwR1TC3ojR80H/jH+vYavwQ+TvO8ksXL9JQWc3IFSiGpuSVXLCdg62AmR irxW+qCwNncNQyb9rd30gzdectSkPWL3KSqEResBe24IbA5/jSkPweJasgXtfhuyoeCJ6PXo clQQGKIoFIAEv1s8l0ggPZswvCinegl1diyJXUXmdEJRTWYAtxn/atut1o6Giv6D2qmYbXN7 mneMC5MzlLaJKUtoH7U/IjVw1sx2qtxAZGKVm4RZxPnMCp9E1MAr5t4dP5gJCIiqsdrVqI6i KupZstMxstPU//azmz7ZWWxT0JzgJqZSvPYx/SATeexTYBP47YFyri4jnsty2ErS91E6H8os Bv6pnSn7eAq5AQ0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRH UE9eosYbT6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgT RjP+qbU63Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+R dhgATnWWGKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zb ehDda8lvhFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r 12+lqdsAEQEAAYkBPAQYAQgAJhYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsMBQkD wmcAAAoJEGgNwR1TC3ojpfcIAInwP5OlcEKokTnHCiDTz4Ony4GnHRP2fXATQZCKxmu4AJY2 h9ifw9Nf2TjCZ6AMvC3thAN0rFDj55N9l4s1CpaDo4J+0fkrHuyNacnT206CeJV1E7NYntxU n+LSiRrOdywn6erjxRi9EYTVLCHcDhBEjKmFZfg4AM4GZMWX1lg0+eHbd5oL1as28WvvI/uI aMyV8RbyXot1r/8QLlWldU3NrTF5p7TMU2y3ZH2mf5suSKHAMtbE4jKJ8ZHFOo3GhLgjVrBW HE9JXO08xKkgD+w6v83+nomsEuf6C6LYrqY/tsZvyEX6zN8CtirPdPWu/VXNRYAl/lat7lSI 3H26qrE= Message-ID: <08af7a9d-4d5b-3b5d-ce0d-e4cfa8700ead@suse.de> Date: Wed, 5 Feb 2020 08:39:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200205065312.15790-1-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n7BqPTALHhmC9nv5EOlXhgd7PvwNLTub7" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --n7BqPTALHhmC9nv5EOlXhgd7PvwNLTub7 Content-Type: multipart/mixed; boundary="8jyV62oj2H4d51KvhrWXToHiPqQnXYFsY"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: olvaffe@gmail.com, gurchetansingh@chromium.org, David Airlie , Daniel Vetter , "open list:VIRTIO GPU DRIVER" , open list Message-ID: <08af7a9d-4d5b-3b5d-ce0d-e4cfa8700ead@suse.de> Subject: Re: [PATCH] drm/virtio: fix vblank handling References: <20200205065312.15790-1-kraxel@redhat.com> In-Reply-To: <20200205065312.15790-1-kraxel@redhat.com> --8jyV62oj2H4d51KvhrWXToHiPqQnXYFsY Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 05.02.20 um 07:53 schrieb Gerd Hoffmann: > virtio has its own commit fail function. Add the > drm_atomic_helper_fake_vblank() call there. >=20 > Fixes: 2a735ad3d211 ("drm/virtio: Remove sending of vblank event") Thanks for fixing the fallout. > Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/virtio/virtgpu_display.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm= /virtio/virtgpu_display.c > index ecf4ba7cc32b..7b0f0643bb2d 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > @@ -324,6 +324,7 @@ static void vgdev_atomic_commit_tail(struct drm_ato= mic_state *state) > drm_atomic_helper_commit_modeset_enables(dev, state); > drm_atomic_helper_commit_planes(dev, state, 0); > =20 > + drm_atomic_helper_fake_vblank(state); > drm_atomic_helper_commit_hw_done(state); > =20 > drm_atomic_helper_wait_for_vblanks(dev, state); >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --8jyV62oj2H4d51KvhrWXToHiPqQnXYFsY-- --n7BqPTALHhmC9nv5EOlXhgd7PvwNLTub7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl46cScACgkQaA3BHVML eiP5QQgAuCOwZJoU/TXyWVpYlSmyHRDS14CnhHE94aQmrU9D8k1UsJUt/bqr+7NK PAKWbLWuZoeeHc1evbbqPypqdh47ndG9kT03/eEzLmKALmHqq1lcPj8evj9T1f3l 5lol2uJoEFrf1OmB4Cmt5vwvg51X/ohqkzy8mi7EIeacSnDxIXeNtrSje9KCpBYU AXSz5WaFTq+uWpYIMKcrjfP9R/st/ULzHusI+Sa5gjjso2dIG62tvUSPJQZkxVfz iH0JO3doGIaLNGlWINQ+LEYB6tbIjgH9L+wzhegov0B4GUP0Trg0cH9oK52WcTRk UoySz2Jccy/g7FqHWhjT/zislQfZug== =eo1s -----END PGP SIGNATURE----- --n7BqPTALHhmC9nv5EOlXhgd7PvwNLTub7--