From: Tony Jones <TonyJ@suse.com>
To: Yafang Shao <laoar.shao@gmail.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"acme@kernel.org" <acme@kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"jolsa@redhat.com" <jolsa@redhat.com>,
"mingo@redhat.com" <mingo@redhat.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"florian.schmidt@nutanix.com" <florian.schmidt@nutanix.com>,
"daniel.m.jordan@oracle.com" <daniel.m.jordan@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tracing, vmscan: add comments for perf script page-reclaim
Date: Wed, 25 Sep 2019 19:21:14 +0000 [thread overview]
Message-ID: <08afb22b-de50-7a2b-6d37-136d1bc41b23@suse.com> (raw)
In-Reply-To: <1568817522-8754-3-git-send-email-laoar.shao@gmail.com>
On 9/18/19 7:38 AM, Yafang Shao wrote:
> Currently there's no easy way to make perf scripts in sync with
> tracepoints. One possible way is to run perf's tests regularly, another way
> is once we changes the definitions of tracepoints we must keep in mind that
> the perf scripts which are using these tracepoints must be changed as well.
> So I add this comment for the new introduced page-reclaim script as a
> reminder.
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
This seems like the tail wagging the dog to me. If we added this to every tp defn that is used by a perf perl/python script the tp headers would be littered with such comments.
prev parent reply other threads:[~2019-09-25 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 14:38 [PATCH 0/2] introduce new perf-script page-reclaim Yafang Shao
2019-09-18 14:38 ` [PATCH 1/2] perf script python: integrate page reclaim analyze script Yafang Shao
2019-09-26 1:56 ` Tony Jones
2019-09-26 3:36 ` Tony Jones
2019-09-26 4:37 ` Yafang Shao
2019-09-26 4:42 ` Yafang Shao
2019-09-18 14:38 ` [PATCH 2/2] tracing, vmscan: add comments for perf script page-reclaim Yafang Shao
2019-09-25 19:21 ` Tony Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08afb22b-de50-7a2b-6d37-136d1bc41b23@suse.com \
--to=tonyj@suse.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=florian.schmidt@nutanix.com \
--cc=jolsa@redhat.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®