From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751652AbdFFL7D (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Jun 2017 07:59:03 -0400
Received: from fllnx209.ext.ti.com ([198.47.19.16]:62088 "EHLO
        fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751601AbdFFL7A (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Jun 2017 07:59:00 -0400
Subject: Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node
To: Tony Lindgren <tony@atomide.com>
References: <20170601143401.16852-1-kishon@ti.com>
 <CAPDyKFqHHjZQnnaGLP=xDj3eYgzADDYoomzBuXRviBgh-n2QFw@mail.gmail.com>
 <f78dd61c-6689-4dbc-d1db-128f92be8e51@ti.com>
 <1d15c9e9-f257-fd97-a9a2-055ee90d7e84@ti.com>
 <20170606105131.GZ3730@atomide.com>
CC: Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Sekhar Nori <nsekhar@ti.com>, Russell King <linux@armlinux.org.uk>,
        linux-omap <linux-omap@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
From: Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <08b140b7-de76-c912-9f81-c7cdeca45641@ti.com>
Date: Tue, 6 Jun 2017 17:27:13 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170606105131.GZ3730@atomide.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Tuesday 06 June 2017 04:21 PM, Tony Lindgren wrote:
> * Kishon Vijay Abraham I <kishon@ti.com> [170606 03:40]:
>> omap3-overo-base.dtsi has the following dt node for mmc.
>> /* optional on board WiFi */
>> &mmc2 {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&mmc2_pins>;
>>         vmmc-supply = <&w3cbw003c_npoweron>;
>>         vqmmc-supply = <&w3cbw003c_bt_nreset>;
>>         vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
>>         bus-width = <4>;
>>         cap-sdio-irq;
>>         non-removable;
>> };
>>
>> It has both "vqmmc-supply" and "vmmc_aux-supply". However omap-hsmmc driver has
>> never parsed vqmmc so far. So I'd assume bt was never functional and it's used
>> only for wifi.
> 
> Hmm yeah the vqmmc-supply probably got copied from some
> other SoC for w3cbw003c.

Okay. So I think we can remove vqmmc-supply here without breaking any existing
functionality.
> 
>> So for the change suggested by Ulf, Can I do something like below, so that we
>> can keep wifi functional (ignoring bt since that was never functional)?
>> -       vqmmc-supply = <&w3cbw003c_bt_nreset>;
>> -       vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
>> +       vqmmc-supply = <&w3cbw003c_wifi_nreset>;
> 
> Optional sdio pins 4 - 8 need separate power and that's
> why we have the vmmc_aux supply to start with. But here
> there are only four pins, so my guess is that only one
> regulator is needed and the the other two are gpio pins
> for wland and bt that nowadays should be handled by the
> mmc power sequence driver.

Yeah. Just now checked the pwrseq driver (pwrseq_simple), but it has it's own
binding. So even if we move to the pwrseq, we still have to support
"vqmmc-supply = <&w3cbw003c_wifi_nreset>" to avoid breaking old dt compatibiltiy.

Thanks
Kishon