From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB4C5399001 for ; Tue, 23 Jun 2026 07:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782198667; cv=none; b=GcdLQAjZVeSYbRsw7GKEmbBnC57EpC2gttuaLoaTa7uJF+SY1eObfk1fU6TGA3w2RMlcx+G+HOQTlAsicK2by+f5OjK5Z68N9pUJbQ0gU40GyTAaXw+69D8vY22KFuVZLL1sAbc2577Abc2CASKllEZOLGpBD00ORvHAlFSBJS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782198667; c=relaxed/simple; bh=ENKNN70K35I+XiGk5B0w6h1fPi/USSd++hCbSNKdKt8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s2vCE9jIjyO10IHRf1xjs+yH3/qdBZy9qg2EI4ndZjVAYIUxbAxmwoAFJxh7SyV34exP2TSiATRLnNMci77b3Yy3eRmV3Wmfdmtm2bVYFyDsYTcLDb13rSg8oLyKMImDNKQX6Ys2trflmzVwAh+fAfPz9ArZhuoaJGQilGAB7xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HwoOuOch; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c0A0v/J8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HwoOuOch"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c0A0v/J8" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N6cjpW3563987 for ; Tue, 23 Jun 2026 07:11:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tqQEqsHHunLFUCM1PpOOmueTw23PhpFJabrs7PJLUH4=; b=HwoOuOch+wLomMqZ L8Pz2jDwxGUdAkY5wLbwXjsMIfrwM3W7Yda5ABfYroE2J9W84aoHTzjLQNbE0B1h 8L9vj9ND5zhO/jcDuzgo6rtwub9J2lx8KJtsllcM2Vf72UtZ0pMs7VfWSS/Nqz7v MOyY81aWQgs1Gc241mdHR9EK1IHO+yZIJ8ZKnk6KPSYsHd1GHkXsxWQCnOv2C+sY +3xgHcm9xBX69V/7PfFe1ENJ1hWb6oIGJ6bQi/8OybxMMVkS2+W8TKlavEyJ1PJ2 Czj0F2vulZ34xzALqazvABFxA9exL4xgD5ad7HCRsmHq+Yg7mGUlPZp8hhh6Agq0 q8eF0A== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey5n43fq2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 07:11:04 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c6a2ee8cc9so47900665ad.3 for ; Tue, 23 Jun 2026 00:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782198664; x=1782803464; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tqQEqsHHunLFUCM1PpOOmueTw23PhpFJabrs7PJLUH4=; b=c0A0v/J8GopIjc8s2Tuq+e1vfo6fzrtb6FSunZ43CCY9GxlFTxrLK2R78Fz8+rq2Mc US3fgAdxvQIxns7DzNiVQPCpWcER9lrO7098378JbbV61qOqIgXweVaXpqH/iThvcdz3 u1v/QnH3UpoboVaPOCh7zgYhHxupQz0/1Zi7oJMLyvWfkjeSZy52wyDtW8Fdpbe6cAcK 6q9Xce43FNPjChogFoeox1x4T/JgQ+tEiWyKnOEw7YOri7ivuG3qjceAgYFsBRp51rbk Q8VAZ9PHA/7pkpQMYx7N48ntECK4v7kHg4V/mrpcdRvC6WxDiiCO88tvZiSBuHnBnq7O +yow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782198664; x=1782803464; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tqQEqsHHunLFUCM1PpOOmueTw23PhpFJabrs7PJLUH4=; b=WyFu5PyySviefyFRmbqeFK+vhvtjN4cheC9rxdKiszMmkzKIlCjuUHMqjd4f/PWGuZ nuC2HXLEbBNMnOKfsyHJqlhjTNUt/Ihiv8iUbqe1jESycUqgrP7/l7vhsMDamSpjIbJR IDs7KQSigaTsqIWmXKipyKFl0Y9+dtn/esw4TQ+he7Qb4DhTDwuMKilRQL4Jt++CHBbw txU6MM34eKV1jbsaXFt/s+m9MbLYrU1X9LKREkcjWxYj1YgH6MjOY0Z0X/UoxHIS6aoF 7rWZxbyheri3UE5SRaU0SuMNFkosQLAouOWoaPb1rixFYPxDIuGr8iyB4ViU2fHfbGVG wx2Q== X-Forwarded-Encrypted: i=1; AHgh+RpytK7WPTvak2ZZU6lGRHr4cl79xa6dPfuR7EWqSmWR2uEEXDzOeccyBbEhIQuZ6TSFKV0hfGLOYkeSSBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxuZ+c1TpMFaotjr7kZeRAAlYJDeKsIm1Akht2fZKpsIyyUzz0o Hh1bW5hWzoVHu5KJMx2p56m+BF1KGUiq9/w2FBaFMfS8OtoPhV3NrB5kA30Jym+Ky9QnX/cjMpI XPKP1tnBmpb1JMzxj+AEA5BD3T6Cr/bQF4XxASeCC27bGWcHnqe1nYyKQpHEUI0VYtpU= X-Gm-Gg: AfdE7cklTMNe6FXsLiHsxmERdi9f4Mq697ObYnPh2O7oTKbnUisjbHZcbNGb1XRw5aT 9RdynakvtE0AxdSRuaeZA1MCfRY2hKW/cY6IseCefoDJpucxYbVcLB+pKQQzHFnw3BTF+imcvyw 53OUHSrGXuk/iHMseW/gmy8PHQ3CudLpT14oXJ8/T0ECRQexv6XFq4BRM4zPiqAJOuifNkMWk3L vBqwEObLgNciT8Au3wVsAgrebHT7FPP+akaHNayKn0um+tB+ZrqZDEd4ocLJrrEL4+fSwZtLRDi oAdWxUMqSyoJCQ8MPJ3akHfUme3jC48AGaDLNk6KRs5yauH5tK4+0fd55l56f2hBClfPUpgFsGf ztAwDLQxUXY8ZafCiHTxCO7GmOSlUaSThtJZjSfHHRkojYxWqipXXvoBNZ7Ga X-Received: by 2002:a17:902:fc46:b0:2c6:b768:a7de with SMTP id d9443c01a7336-2c7422c36f0mr145281525ad.8.1782198663626; Tue, 23 Jun 2026 00:11:03 -0700 (PDT) X-Received: by 2002:a17:902:fc46:b0:2c6:b768:a7de with SMTP id d9443c01a7336-2c7422c36f0mr145281215ad.8.1782198663195; Tue, 23 Jun 2026 00:11:03 -0700 (PDT) Received: from [10.137.71.130] ([106.198.36.229]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c743fd6420sm98079155ad.70.2026.06.23.00.11.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 00:11:02 -0700 (PDT) Message-ID: <08b24438-9d5e-4418-8297-8e7f573349f4@oss.qualcomm.com> Date: Tue, 23 Jun 2026 12:40:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] wifi: ath6kl: fix OOB access from firmware ADDBA window size To: Tristan Madani , Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani References: <20260421135009.348084-1-tristmd@gmail.com> <20260421135009.348084-2-tristmd@gmail.com> Content-Language: en-US From: Vasanthakumar Thiagarajan In-Reply-To: <20260421135009.348084-2-tristmd@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA1NSBTYWx0ZWRfX5w7OYsqWRRSj sPEwMr7DaaPbG1XKDIj5HLKyBXe3KPCulS11UtQ4OffoP15xyPxpM57HadqB5y6cxoH1YnLq1yC gtAQHf6tNGjzr80yQI8lgnBGJcAUdsM= X-Authority-Analysis: v=2.4 cv=R8Uz39RX c=1 sm=1 tr=0 ts=6a3a3188 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=6/2MXK9rXRWb21GBy9lArw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=J_-Nd1mkAAAA:8 a=6hp2VIgpqHygfFtxsjAA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=n8ForQn92ZFaZtFqRdMw:22 X-Proofpoint-ORIG-GUID: GHf5wO0GjrqSljlXI3OW4UunDf3RV5Gw X-Proofpoint-GUID: GHf5wO0GjrqSljlXI3OW4UunDf3RV5Gw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA1NSBTYWx0ZWRfX44IizmcooMjU wCB68m1DH/L4WwEHwttxZv9L7vZYoPwO+DtaGNhghfcKV5Wao2SM6r3wvVz+3G0KVJnAAXxSpDO ElV5a8WrImyC58N3XA68blpntVK9CfhezFErliU1Yy0HLawAgZZ6uxwKFH4eDVpu7yi0Vir4Vhc Z6iFBv2WHVu9q9sBliaueqsvNqOOZeEsvRj5aTmZ4QczGoSkWd9D7rv6u+VnNRrky1/KArOMlAC 0ijh5ev5XO0yhjHWfI/lFeTvscLwpTfoVMihVVqRTPdvwoPwvLO8e9cKrJw/Mz2LdNyl22UTne8 9WBbwTXbL8lRTeqD0ydrNOtdDe1hFoZ0DCw22hyPP4wDd7WESbDG//DofBJledvphA5BbcyAU9+ XuxMW8h9dZTgBJMlrqSHrkP4QoyDKNxeX1dUrYmwbBiqOZyXHJGDbSk6sAsSgJJsN+CyeDwoWAb WdQ5hde0uuwyNu66SVA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230055 On 4/21/2026 7:20 PM, Tristan Madani wrote: > From: Tristan Madani > > aggr_recv_addba_req_evt() logs a debug message when the firmware-supplied > win_sz is outside [AGGR_WIN_SZ_MIN, AGGR_WIN_SZ_MAX] but does not > return. The out-of-range win_sz is then used in TID_WINDOW_SZ() to > compute a kzalloc size and stored in rxtid->hold_q_sz, leading to > zero-size or overflowed allocations and subsequent OOB access. > > Return early when win_sz is out of the valid range. > > Fixes: bdcd81707973 ("Add ath6kl cleaned up driver") > Signed-off-by: Tristan Madani > --- > Changes in v3: > - Regenerated from wireless-next with proper git format-patch to > produce valid index hashes (v2 had post-processed index lines). > > Changes in v2: > - No code changes from v1. > > drivers/net/wireless/ath/ath6kl/txrx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath6kl/txrx.c b/drivers/net/wireless/ath/ath6kl/txrx.c > index 97fdac7237e26..5575b535f94cd 100644 > --- a/drivers/net/wireless/ath/ath6kl/txrx.c > +++ b/drivers/net/wireless/ath/ath6kl/txrx.c > @@ -1723,9 +1723,11 @@ void aggr_recv_addba_req_evt(struct ath6kl_vif *vif, u8 tid_mux, u16 seq_no, > > rxtid = &aggr_conn->rx_tid[tid]; > > - if (win_sz < AGGR_WIN_SZ_MIN || win_sz > AGGR_WIN_SZ_MAX) > + if (win_sz < AGGR_WIN_SZ_MIN || win_sz > AGGR_WIN_SZ_MAX) { > ath6kl_dbg(ATH6KL_DBG_WLAN_RX, "%s: win_sz %d, tid %d\n", > __func__, win_sz, tid); > + return; > + } I think, before returning, it makes sense to clean up the previously active session also upon an event with unexpected aggregation window size for the tid. Vasanth