From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7364B149C4A; Wed, 29 Jan 2025 05:43:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738129398; cv=none; b=u3lkd2CHdV9CIHpcFMEs3V/W/HPnsupzAa8ShXBQIP5vwbcasWuWP2Vefwd/HrD+B3QTjndgm9ID6TWAjOcQsGCG6/RBZ0t/Vy60ZdPMRmd5sQ0nnFD9mNW+EfY1Xw3d06q8UZFs5Fhnku6uHfPnTRZY70/NW2Qg2Zwf3ka6G30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738129398; c=relaxed/simple; bh=mKSiYsx8t3a88mj0PMMuSue3Ra7WZyO7nirohvQjEUo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=uhK9xwe+nCd11V6TJYcxPhrPthiac356BWNiVZ9g1QricP3RwkbESzuLPtYfK703A5L84PlU3fUZoksauM/3uEtCwb2/bHKziPWJV1k+9JXLGEN5f4OKumDIstpxQSq95U74neb0FlnOTdFEuulG89Mw03XMMu1ZvGCa4UCPxQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=VQiKF+Ab; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="VQiKF+Ab" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50T2hGZT021051; Wed, 29 Jan 2025 05:43:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MluhHGnAAyIhuJOeIvVp+VrtgGP6P/eiVV8c2vS8Kfk=; b=VQiKF+AbjJ7ubL8l JMBkogNSvEAOT+kvMyPpIfyb7Yzlqm4+vOfw49iX99zR8ehZiL+vl9xrV0/XUck5 rEllZ+v+5f/GAl4bIzhtTxjfyqHHS9hApObkRfcIarqoJ5lI+2DaoFagXgHcFE/J FHfJYXgIx/YZNmFzKFPsd4HNcpVebRTiwMwpQGZ3BZ6l8hkPusmIlN8X0ZTnz0qy F0KXiqw1sPVLRJlf5vBtnrBvXmNBY0Fxstq3GrLYEdBa+f1FlY/4KuSe4hSXQJhV M0lm9bskHCiWX6DKAi+5M8Di+m+d/RbQzBu3osW6sKPs3SlYEUwOeRGyJIWq8yAF H6wCXg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44f7xfgkr5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Jan 2025 05:43:12 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 50T5hB7L013730 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Jan 2025 05:43:11 GMT Received: from [10.204.65.49] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 28 Jan 2025 21:43:08 -0800 Message-ID: <08b469b8-2339-4fde-9472-fcaadbb4ed87@quicinc.com> Date: Wed, 29 Jan 2025 11:13:05 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] misc: fastrpc: Modify context id mask to support polling mode To: Dmitry Baryshkov CC: , , , , , , , References: <20250127044239.578540-1-quic_ekangupt@quicinc.com> <20250127044239.578540-6-quic_ekangupt@quicinc.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: xTgp9aCGfXEQaNAtw6CIm52bhGquG61u X-Proofpoint-GUID: xTgp9aCGfXEQaNAtw6CIm52bhGquG61u X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-28_04,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501290045 On 1/29/2025 5:00 AM, Dmitry Baryshkov wrote: > On Mon, Jan 27, 2025 at 10:12:39AM +0530, Ekansh Gupta wrote: >> DSP needs last 4 bits of context id to be 0 for polling mode to be >> supported as setting of last 8 is intended for async mode(not yet >> supported on upstream driver) and setting these bits restrics >> writing to poll memory from DSP. Modify context id mask to ensure >> polling mode is supported. > Shouldn't this commit come before the previous one? Yes, I'll change the order in next series. Thanks for reviewing the changes. --ekansh > >> Signed-off-by: Ekansh Gupta >> --- >> drivers/misc/fastrpc.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c >> index 257a741af115..ef56c793c564 100644 >> --- a/drivers/misc/fastrpc.c >> +++ b/drivers/misc/fastrpc.c >> @@ -40,7 +40,7 @@ >> #define FASTRPC_INIT_HANDLE 1 >> #define FASTRPC_DSP_UTILITIES_HANDLE 2 >> #define FASTRPC_MAX_STATIC_HANDLE (20) >> -#define FASTRPC_CTXID_MASK (0xFF0) >> +#define FASTRPC_CTXID_MASK (0xFF0000) >> #define INIT_FILELEN_MAX (2 * 1024 * 1024) >> #define INIT_FILE_NAMELEN_MAX (128) >> #define FASTRPC_DEVICE_NAME "fastrpc" >> @@ -524,7 +524,7 @@ static void fastrpc_context_free(struct kref *ref) >> fastrpc_buf_free(ctx->buf); >> >> spin_lock_irqsave(&cctx->lock, flags); >> - idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); >> + idr_remove(&cctx->ctx_idr, ctx->ctxid >> 16); >> spin_unlock_irqrestore(&cctx->lock, flags); >> >> kfree(ctx->maps); >> @@ -664,7 +664,7 @@ static struct fastrpc_invoke_ctx *fastrpc_context_alloc( >> spin_unlock_irqrestore(&cctx->lock, flags); >> goto err_idr; >> } >> - ctx->ctxid = ret << 4; >> + ctx->ctxid = ret << 16; >> spin_unlock_irqrestore(&cctx->lock, flags); >> >> kref_init(&ctx->refcount); >> @@ -2675,7 +2675,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device *rpdev, void *data, >> if (len < sizeof(*rsp)) >> return -EINVAL; >> >> - ctxid = ((rsp->ctx & FASTRPC_CTXID_MASK) >> 4); >> + ctxid = ((rsp->ctx & FASTRPC_CTXID_MASK) >> 16); >> >> spin_lock_irqsave(&cctx->lock, flags); >> ctx = idr_find(&cctx->ctx_idr, ctxid); >> -- >> 2.34.1 >>