mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
To: Kathiravan Thirumoorthy
	<kathiravan.thirumoorthy@oss.qualcomm.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	"Dmitry Baryshkov" <lumag@kernel.org>,
	Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] phy: qcom-qusb2: reuse the IPQ6018 settings for IPQ5424
Date: Mon, 14 Apr 2025 19:03:16 +0530	[thread overview]
Message-ID: <08b5187b-0e74-4ba8-9893-4be61c2f9bdf@quicinc.com> (raw)
In-Reply-To: <20250414-revert_hs_phy_settings-v2-2-25086e20a3a3@oss.qualcomm.com>



On 4/14/2025 5:22 PM, Kathiravan Thirumoorthy wrote:
> With the settings used in the commit 9c56a1de296e ("phy: qcom-qusb2: add
> QUSB2 support for IPQ5424"), complaince test cases especially
compliance
> eye-diagram (Host High-speed Signal Quality) tests are failing.
> 
> Reuse the IPQ6018 settings for IPQ5424 as suggested by design team,
No mention of team. Write it as generic.
> which helps to meet all the complaince requirement test cases.
compliance
> 
> Fixes: 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424")
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
>   drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> index 81b9e9349c3ebb4d303cb040b5c913336bb6b6d6..49c37c53b38e70db2a1591081a1a12db7092555d 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> @@ -929,6 +929,9 @@ static const struct phy_ops qusb2_phy_gen_ops = {
>   
>   static const struct of_device_id qusb2_phy_of_match_table[] = {
>   	{
> +		.compatible	= "qcom,ipq5424-qusb2-phy",
> +		.data		= &ipq6018_phy_cfg,
> +	}, {
>   		.compatible	= "qcom,ipq6018-qusb2-phy",
>   		.data		= &ipq6018_phy_cfg,
>   	}, {
> 


  reply	other threads:[~2025-04-14 13:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 11:52 [PATCH v2 0/2] Reuse the IPQ6018 QUSB2 PHY " Kathiravan Thirumoorthy
2025-04-14 11:52 ` [PATCH v2 1/2] Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424" Kathiravan Thirumoorthy
2025-04-14 13:33   ` Mukesh Kumar Savaliya
2025-04-15  4:08     ` Kathiravan Thirumoorthy
2025-04-14 11:52 ` [PATCH v2 2/2] phy: qcom-qusb2: reuse the IPQ6018 settings for IPQ5424 Kathiravan Thirumoorthy
2025-04-14 13:33   ` Mukesh Kumar Savaliya [this message]
2025-04-14 13:33 ` [PATCH v2 0/2] Reuse the IPQ6018 QUSB2 PHY " Mukesh Kumar Savaliya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08b5187b-0e74-4ba8-9893-4be61c2f9bdf@quicinc.com \
    --to=quic_msavaliy@quicinc.com \
    --cc=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=kishon@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=lumag@kernel.org \
    --cc=quic_varada@quicinc.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®