From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B871C433FE for ; Thu, 10 Feb 2022 22:46:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345218AbiBJWqt (ORCPT ); Thu, 10 Feb 2022 17:46:49 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345209AbiBJWqr (ORCPT ); Thu, 10 Feb 2022 17:46:47 -0500 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6872C5F45 for ; Thu, 10 Feb 2022 14:46:47 -0800 (PST) Received: by mail-il1-x12f.google.com with SMTP id b5so5579600ile.11 for ; Thu, 10 Feb 2022 14:46:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B/UXIV3zf866V2KVi395pqDMtj3eD/83YXll34yD54w=; b=BDz7AdxsRIcraonOF4GIu+SUGbj1wkvZhku3SLPoSuwmlYMbKzH/x/rw21Zq2qZGN/ RqnAHnf0EMjXBB/sYR35dmGGeYeSkNIdE78z1g3sh8hGsS4YXwqr7d54V0YXKW9b5Z7y h3UK4GKzi0cKc8CQOElBzKDKu3ylqWx4Ex2+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B/UXIV3zf866V2KVi395pqDMtj3eD/83YXll34yD54w=; b=jOZaKWX4KHCz4Xa1WL0s27FOcZITodByrgQlspaDgSv9tPghf/8SwPvD6DNDNpszeS KbwbsL+FuIIHQdTkzDMtn92cXlFNbNKCozjUoUJG9sl4wNkDUBTzRG4EIhm+G+kwvxkS jgJev33jls0fkF5bBas6O51G7YOCz+c0fqLYjNUNVfqcdY7LvbqnISUS2OinXMVFx+E4 CB9mmrOWt/InRlR1rvfCYnpY8MGHGGPR946HoMuclpPdCkqniOU5h/I+0YRr8jS9acnc t7gVMGSwNB1trAqG5VoZZGOFn3DwS6NSGg9y4u5Hil5QHTGBvu6x6y0pGoAZCoFg9guY TCFg== X-Gm-Message-State: AOAM5329VuITD/9o7svaXN5ePAx4r1ErltAB6jR/AM8YW+eoBmWz5SlR 3J4P/MYA59Y1hVhZCInt31dqLQ== X-Google-Smtp-Source: ABdhPJx4+vBo900qqkINhcheGliA9WQQ0yV4w/bhniIOWepwfYg1sRffUB0hU4xb+Z0iqz9KI3p0bQ== X-Received: by 2002:a92:1311:: with SMTP id 17mr5118958ilt.42.1644533206807; Thu, 10 Feb 2022 14:46:46 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id c2sm8558041ilh.43.2022.02.10.14.46.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 14:46:46 -0800 (PST) Subject: Re: [PATCH 1/2] selftests: x86: allow expansion of $(CC) To: Muhammad Usama Anjum , Jarkko Sakkinen , Dave Hansen , Shuah Khan , Andy Lutomirski , Borislav Petkov , Jethro Beekman , "open list:INTEL SGX" , "open list:KERNEL SELFTEST FRAMEWORK" , open list , Shuah Khan Cc: kernel@collabora.com, kernelci@groups.io, "kernelci.org bot" References: <20220210190642.1477814-1-usama.anjum@collabora.com> <20220210190642.1477814-2-usama.anjum@collabora.com> <81619c13-41e6-3aab-4cf7-9b6d5a11e05c@collabora.com> From: Shuah Khan Message-ID: <08b8b886-4ec4-994a-4a4b-0da30766df1e@linuxfoundation.org> Date: Thu, 10 Feb 2022 15:46:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <81619c13-41e6-3aab-4cf7-9b6d5a11e05c@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/22 3:41 PM, Muhammad Usama Anjum wrote: > On 2/11/22 1:51 AM, Shuah Khan wrote: >> On 2/10/22 12:06 PM, Muhammad Usama Anjum wrote: >>> CC can have multiple sub-strings like "ccache gcc". Erorr pops up if >>> it is treated as single string and double quote are used around it. >>> This can be fixed by removing the quotes and not treating CC a single >>> string. >>> >>> Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture >>> detection") >>> Reported-by: "kernelci.org bot" >>> Signed-off-by: Muhammad Usama Anjum >>> --- >>>   tools/testing/selftests/x86/check_cc.sh | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/x86/check_cc.sh >>> b/tools/testing/selftests/x86/check_cc.sh >>> index 3e2089c8cf549..aff2c15018b53 100755 >>> --- a/tools/testing/selftests/x86/check_cc.sh >>> +++ b/tools/testing/selftests/x86/check_cc.sh >>> @@ -7,7 +7,7 @@ CC="$1" >>>   TESTPROG="$2" >>>   shift 2 >>>   -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then >>> +if $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then >>>       echo 1 >>>   else >>>       echo 0 >>> >> >> The intent is testing if $CC is set. Does this change work when >> $CC is not set? >> > Yeah, it works. I've added a debug variable inside sgx/Makefile and it > is detecting empty argument correctly as well. > Sounds good. thanks, -- Shuah