From: Andrew Lunn <andrew@lunn.ch>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shenjian15@huawei.com, wangpeiyang1@huawei.com,
liuyonglong@huawei.com, chenhao418@huawei.com,
sudongming1@huawei.com, xujunsheng@huawei.com,
shiyongbang@huawei.com, libaihan@huawei.com,
jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 net-next 5/7] net: hibmcge: Add pauseparam supported in this module
Date: Wed, 13 Nov 2024 21:41:06 +0100 [thread overview]
Message-ID: <08bbffc1-3c99-4b4a-a3b3-02707752398b@lunn.ch> (raw)
In-Reply-To: <2d8e467d-b8e0-4728-ac2c-fba70a53bd9f@huawei.com>
> Maybe there is an error in this code.
> If I want to disable auto-neg pause, do I need to set phy_set_asym_pause(phydev, 0, 0)?
You could. It is not actually clear to me what you should tell the
link peer when you decide to not use pause autoneg. By passing 0, 0,
you are telling the peer you don't support pause, when in fact you do,
and the configuration is hard coded. Not using pause autoneg really
only makes sense when you do it to both peers. And then the
negotiation configuration does not matter.
phylink makes this a lot easier, it hides this all away, leaving the
MAC driver to just program the hardware.
Andrew
next prev parent reply other threads:[~2024-11-13 20:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 14:55 [PATCH V3 net-next 0/7] Support some features for the HIBMCGE driver Jijie Shao
2024-11-11 14:55 ` [PATCH V3 net-next 1/7] net: hibmcge: Add debugfs supported in this module Jijie Shao
2024-11-11 14:55 ` [PATCH V3 net-next 2/7] net: hibmcge: Add irq_info file to debugfs Jijie Shao
2024-11-11 14:55 ` [PATCH V3 net-next 3/7] net: hibmcge: Add unicast frame filter supported in this module Jijie Shao
2024-11-13 13:33 ` Simon Horman
2024-11-11 14:55 ` [PATCH V3 net-next 4/7] net: hibmcge: Add register dump " Jijie Shao
2024-11-11 14:55 ` [PATCH V3 net-next 5/7] net: hibmcge: Add pauseparam " Jijie Shao
2024-11-11 17:58 ` Andrew Lunn
2024-11-12 14:37 ` Jijie Shao
2024-11-12 16:32 ` Andrew Lunn
2024-11-13 3:20 ` Jijie Shao
2024-11-13 20:41 ` Andrew Lunn [this message]
2024-11-11 14:55 ` [PATCH V3 net-next 6/7] net: hibmcge: Add reset " Jijie Shao
2024-11-11 14:55 ` [PATCH V3 net-next 7/7] net: hibmcge: Add nway_reset " Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08bbffc1-3c99-4b4a-a3b3-02707752398b@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®