Re: [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice

["Luka Gejak" <luka.gejak@linux.dev>]

October 10, 2026 at 8:36 PM, "Hungyu Lin" <dennylin0707@gmail.com mailto:dennylin0707@gmail.com?to=%22Hungyu%20Lin%22%20%3Cdennylin0707%40gmail.com%3E > wrote:


> 
> query_phy_status_ofdm() divides the SNR report by two when filling
> pkt_stat->rx_snr, then shifts it again when updating dm_info->rx_snr.
> This halves the SNR used for diagnostics and average statistics.
> 
> Store the raw report in pkt_stat->rx_snr and convert it only when
> updating dm_info->rx_snr, as the other chip drivers do.
> 
> Fixes: 61a486bcd782 ("wifi: rtw88: Add rtw8703b.c")
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/net/wireless/realtek/rtw88/rtw8703b.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8703b.c b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> index 25456f0367b2..1920277d626f 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> @@ -959,7 +959,7 @@ static void query_phy_status_ofdm(struct rtw_dev *rtwdev, u8 *phy_raw,
>  val_s8 = phy_status->path_agc[RF_PATH_A].gain & 0x3F;
>  pkt_stat->rx_power[RF_PATH_A] = (val_s8 * 2) - 110;
>  pkt_stat->rssi = rtw_phy_rf_power_2_rssi(pkt_stat->rx_power, 1);
> - pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2);
> + pkt_stat->rx_snr[RF_PATH_A] = phy_status->path_rxsnr[RF_PATH_A];
>  
>  /* signal power reported by HW */
>  val_s8 = phy_status->cck_sig_qual_ofdm_pwdb_all >> 1;
>

Looking good to me.

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak