From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0997D212B17 for ; Mon, 3 Mar 2025 13:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741010180; cv=none; b=iNyBsnvRK9/rDNhc3DzTN3GS4Vkyhlt4s2LK8vzFmdipla9RBl03T/wd0Ga48oRD2JU7jM01c6WlyDH3YnLXDFhNlahfa/sreyNQYY/WklDaOtDuppRRIkGxHnMOMTpimJBDjUm2ZqDSYr9B1/K/Tfins7b1cEpRzRA3jhpd00Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741010180; c=relaxed/simple; bh=E1xOBAVFlgs9j5gJVrOlXBK11cCTzI/e/8Q4n9db54s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C56azbARw1FM87WKfkyCmnZUuupXHjWOFIwMZFRBg4ULySzHuAiNMBMIrMnkKS4zNeS531KLqDkVLFTpsLN9YeGCIFQX9c+/FmnXgR9KOPrYiklXNMvbNeRhDo6OVc8lskpcsYg7dOZT8d5bls7TpqyHKKHRNMBCj40k/TowFWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hbrzhn49; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hbrzhn49" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 523Aj96r028602 for ; Mon, 3 Mar 2025 13:56:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gTQYhiV7A/gSrCUW3UIc/0TICLatkTmwJ5T2ivNqO7E=; b=Hbrzhn49gVZnNPwT fQWdDQBOm4hpTiVLxcT4Q07A8MAc9TediHFnwwVrbxjGeeFTHzHc81PhP6hru/4I VX3Qiwcy6DLgY7EpRgVZjPs0mSuaFtYd/s+ZAJwuBRvwehqzn68oVfXmeJH2DLr+ SOrUGXdV3Tii4lVd14kdQSiraPJELATCrIw52fzZ/Pv5bvTbvOLKwhxJOWvcoCgz SsOhD5vwGSyBi3vtcumtp9D2OU4XcV3JzbqpcWTSstuqTuk+wXtf0XPyqie8K1K3 B1F28yh0gCGjD4/ge8aXB5vVfPUXHPaeODa3KyDoadbE9O0VGyZQz2k6kdLEbunK xfkR0A== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 453t99500x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 03 Mar 2025 13:56:18 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2233b764fc8so80432255ad.3 for ; Mon, 03 Mar 2025 05:56:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741010177; x=1741614977; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gTQYhiV7A/gSrCUW3UIc/0TICLatkTmwJ5T2ivNqO7E=; b=rModNMGJs2FpPZ36r2CqLfMU8vqwQyjq3Pk/fUKdVMuDUdorwji5IBqTo6MsKgw6Ce s7bpE03oVxgkynl37ASmzAiW+NAo7dcfWZytrHo+k45mXoeh1I2L2v8DD8Q3MCUkgI+J KEDYM+1VWPM8yJDp0UlBK+aeWQRpMUNCvH5VmmR7Xcofhx9oO/znIb4V6RfvXqRRgnTn 5v98NmpehKD3YAMdTv+5gLkVJeYNwYJy0MIc4IzU/KA9AWt6iqTXj2BVNY6gYkfJJwkD j+HNo8xOrN2mphyeqnWlulUKnZZmaXAm9GkYQv98LnBVN688Qz3P8WNXzNss7M9vv3/Y +HIQ== X-Forwarded-Encrypted: i=1; AJvYcCXacw99RzhwPSELvxmP7sDO5rUCzXr25X9wdnS4D3lpGH5lqPj6NyXuTT97V/qh9gUPp4aGTH1TvUwK8Us=@vger.kernel.org X-Gm-Message-State: AOJu0YzUnvfPvJwMBcxzAvARph/L+PAgcnScCZx/ZcfA0LVevVrncmYw BswQDEWv27bgcYUWr1lyvexV7oHgNg4JdbL/XHtTEGEZytcIN12A0/4vqr4xw9TNIWJAPrMAld9 2p9NELrgiZ2cU27Pd5sdc1Zf4dlbm3rFDazJWiOg+PnWBv84brAHh2IknGC2/0BU= X-Gm-Gg: ASbGncvpyiy4wNgFIJ2aC+M/0y5mO9YpAb1rcNLbAFaXwaknLwwpcOYISGj0hEDoMPL jRf8hUBt4XFIbWktAs4xEOLKr7+rG/Lf+Y2ToD+Qriy/0V7xD9EkCYp+rL33HP1986Cvuu74uyO KHMsEER1qzs1pK/A/ofXJUbej99JYywyv85/xM+BfVn5p4FVZ4I5eWUuABSJmlLZ9w9mRbSvduq YQyuWt87Dwwwv0vOevUa5DrkD3rlvPRrnrzPKaoN1Ca2vKHoeJ4wxajXE2FBeGvPR49FsH6SLLR iSx5qD3KiwuLvDKBHudC5t+SiAcxdnEUVA2q3ElpwA== X-Received: by 2002:a17:902:ef46:b0:223:66bb:8995 with SMTP id d9443c01a7336-22368fa9026mr216179365ad.20.1741010177189; Mon, 03 Mar 2025 05:56:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbSlgFrISgvoe5OLtQWuyCUh/aMNHtXhJk50H1lG1jgX8pVYLXg263ffFlRpYKzlf8B3uh7w== X-Received: by 2002:a17:902:ef46:b0:223:66bb:8995 with SMTP id d9443c01a7336-22368fa9026mr216178635ad.20.1741010176426; Mon, 03 Mar 2025 05:56:16 -0800 (PST) Received: from [10.218.7.34] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223501d3eaasm78068995ad.33.2025.03.03.05.56.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 05:56:16 -0800 (PST) Message-ID: <08be051d-6c76-4513-84fd-3ebd0808f695@oss.qualcomm.com> Date: Mon, 3 Mar 2025 19:26:07 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 1/5] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder To: Krzysztof Kozlowski , "Rob Herring (Arm)" Cc: jic23@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, konradybcio@kernel.org, daniel.lezcano@linaro.org, sboyd@kernel.org, amitk@kernel.org, thara.gopinath@gmail.com, lee@kernel.org, rafael@kernel.org, subbaraman.narayanamurthy@oss.qualcomm.com, david.collins@oss.qualcomm.com, anjelique.melendez@oss.qualcomm.com, quic_kamalw@quicinc.com, rui.zhang@intel.com, lukasz.luba@arm.com, lars@metafoo.de, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, cros-qcom-dts-watchers@chromium.org, quic_skakitap@quicinc.com, neil.armstrong@linaro.org References: <20250131183242.3653595-1-jishnu.prakash@oss.qualcomm.com> <20250131183242.3653595-2-jishnu.prakash@oss.qualcomm.com> <20250202-convivial-stingray-of-promotion-1123b8@krzk-bin> <690befae-335d-4d35-aa32-abd537dfc4ef@kernel.org> Content-Language: en-US From: Jishnu Prakash In-Reply-To: <690befae-335d-4d35-aa32-abd537dfc4ef@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: rArypL84hHI_lAWtP0xXv0B8QyawyqaU X-Proofpoint-GUID: rArypL84hHI_lAWtP0xXv0B8QyawyqaU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-03_07,2025-03-03_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 impostorscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503030106 Hi Krzysztof, On 2/26/2025 2:41 PM, Krzysztof Kozlowski wrote: > On 26/02/2025 09:51, Jishnu Prakash wrote: >> Hi Krzysztof, >> >> On 2/2/2025 6:59 PM, Krzysztof Kozlowski wrote: >>> On Sat, Feb 01, 2025 at 12:02:38AM +0530, Jishnu Prakash wrote: >>>> There are several files containing QCOM ADC macros for channel names >>>> right now in the include/dt-bindings/iio folder. Since all of these >>>> are specifically for adc, move the files to the >>>> include/dt-bindings/iio/adc folder. >>>> >>>> Also update all affected devicetree and driver files to fix compilation >>>> errors seen with this move and update documentation files to fix >>>> dtbinding check errors for the same. >>>> >>>> Acked-by: Lee Jones >>>> Acked-by: Rob Herring >>>> Signed-off-by: Jishnu Prakash >>>> --- >>>> Changes since v4: >>>> - Updated some more devicetree files requiring this change. >>> >>> I don't get why this fails building and nothing here nor in cover letter >>> helps me to understand that. >>> >> >> I have tried checking multiple ways for anything missing in my build setup, but I'm not getting this error when building in my local workspace. But the error itself looks invalid to me. > > So probably false positive / automation issue. > > Maybe describe just in case in the changelog that you run full > dt_binding_check and no errors were reported. > I can do that, but do you mean I should just push this same patch again with only that update in the changelog? I'm asking because I suspect this patch will get the same error again. I remember that this patch 1 got the exact same invalid error (qcom,spmi-vadc.h missing) in my V4 patch series. At that time, I thought this may be some rare corner case error which might not always happen, but that seems wrong now. Please let me know, is it better to keep this single patch for the binding file movement and reviewers can overlook the invalid error from the bot, or should I split this patch, like I suggested in my previous mail ? Thanks, Jishnu > BTW, please wrap your emails. > > Best regards, > Krzysztof