From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E879D352F9C for ; Tue, 10 Feb 2026 10:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770718791; cv=none; b=VG3YfacM+qufhcJzf4vxvlsrjTC8BHbWQVCPQ5SstGWfjWic53a3EuYBQMiIKbSurcP10C28NZxCBOtFrw06Pyck4AAz1ck2eZ7J2PGge3WbfyoYmyjkWtfiO5QNK6njBdl6wpvcg3vuVn/XFUgGaFKboKA7nu2rnHVpcLxglPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770718791; c=relaxed/simple; bh=W8eKgxz75TaxalIUxwgfNx8txGwvrbC3VG3ZM/y6H1I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KwBc6AXX01r7BVmozKccBhm0dAFwjxDwBx7VjuJuNH/MGuNUfBDcJh87dEmXDPuCiUUmDwmXKZe09awj6tr8/RLwpXrmUHnabqjgedy2aZh7WvLnRhHOYDQJC4oqSp0B8jZnaQPjJ8OKECS1Qi+1nie3T+CgWR/6Nc8Qa/etiOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KMKopnLB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ay7zqdKP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KMKopnLB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ay7zqdKP" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61A6DmgR3436720 for ; Tue, 10 Feb 2026 10:19:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= escwbqVJN0/V5CRcV9ZKOJ/PB8ZuKP8rhVmgblAx+Yg=; b=KMKopnLB74y78K1G UEmtKFOqHJLIGCRvIXmweHtsQjGDlBTU3uFuaT50WDzfCLVHRnj0eOEDjp0l6VZ3 k4VuZK3QUigl3gvtWH6IIWirF5TrA/9mM3rns9dJt0SoxsHM4CEE6eUfpYLvJ2lH Bb/wwma4TNVAgs8UIi9rxMg05qBFvVwuoTlP+ofV0z/CQJsmsQRYCC1aM5bPnZmM 5BC4IGe3mlE1G5ejxuyBXGnGJkL24YzqOCR+jh4TNz7cEPoMYdr9dMvyfpyjkUnG II91t+LfcaypWKquU89ppM2GvyJszNV+xIEw+x0g7CD2uxkmTsWQb/7yDhDqDXoL UGxhGw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c7fevbyj3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Feb 2026 10:19:50 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35641c14663so2210186a91.2 for ; Tue, 10 Feb 2026 02:19:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770718789; x=1771323589; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=escwbqVJN0/V5CRcV9ZKOJ/PB8ZuKP8rhVmgblAx+Yg=; b=Ay7zqdKPhN8PXw8mZerikwt7Nd+qpJOkPtZNH6Xo4eyIyiUbQjIhtS0s1P0oaaLYvF Gz6fZpfFTxl1Yh1x/4Si9Z/e1PTb76vTpcZd+DHn2xSLpEBVeQgkwWDiUcat0b2k61pA JqMxGiV/PL2YDgy8a0kveGPNwzDu4Sss3/6t48i8IXlfu/6Zdgw9j60E3qdLkouUP+f1 pobR45RuZYItfcq8SRe6XwBowqfOBEcXvbxxE8zjheYDOJQxWHlYJseyCCqSxAbnYvFy zOmw0VI3EavxD1FEW/7r5qNGOSskdIgAVIdW2eA1lnyhVXPJQ+f9pj8MBvXyQXNGgyhp NwVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770718789; x=1771323589; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=escwbqVJN0/V5CRcV9ZKOJ/PB8ZuKP8rhVmgblAx+Yg=; b=Gm26glpNpwJy/PlejfZczwVAD4YLoQU6dMeCG6Y5rwFD9IdHqZS3VayJMFsc4aD3EX kiLoy246VegUMQ3V6zdGXLXIaW4mFhPz9VIM9KrGLu3UWjmXv4nh58aiw9Xs4DUnSqY6 mIcg3BzNxakjRpkllKIXtzLEsIH/SnbD662ccoYx96EJ/oqVbfFkuSmV5DkFyB/BT+Up 9j+yIa4NY7Mqj8kUiCvl3VAbRWvh7x7ArDUDAUIuNuLn3UsN02xPbiozUInARXKVTPg2 nS6QZCEN1Vns4FQFw9Mte74ItZSTu4ybUDWvQzWiMoNmlYIs4euOTKxq6i7ntd9dD/oX 24CQ== X-Forwarded-Encrypted: i=1; AJvYcCV15/h07wpUdjuQeqG4St5vxSUsGvCXh1OIxNAjcSmfgloGi2IvSQkWKjlCo2GgZHBLasxiLSiqMkbcLKU=@vger.kernel.org X-Gm-Message-State: AOJu0YyjROfVmo8T+jjEm5O8c1Y2kCLMrm562MdlbM1wV7c8+a+Ho7e2 rCGPv8JBWJrth2qD646nbmXYdv5h5zATf2A6K858+kQu2NOt14zniFqnI+9t/ii2Mmbc2L0uNFx TevLzYn93OCVVOC6NFBi/k2JTxSH8/KPNoXAkmyNh0F30YtQDX2+gNbTlP1Fdm1wB9UM= X-Gm-Gg: AZuq6aJ822SfILll9Dw0POpgOgUobM7RRgv78DbwdM+Nh/bck4xqa2CqfomC9hv1a7N NcGov9no9Z5+KQpZkVgqAZgDZrflW8/BJ8eKM8Yf09Ao752jQzyfj6i0Mgpll74Z+H7ReSDVq3V g7uEcITTBEbaYb9kcoAKu8mMaov6S1h8UCB7iYIkAN7cUvweg2fAdmgHj629egZy6/QeQ9MGwaP pmuHE/jdEREEkLqHL1PXPvPVD2ndXz/8ehwVSOxOzBMLM0PlhNlT0EyG5xW9KLE53y07spwFjU5 Rf7Yh34sKRteC6RMUCkKOIua62IvmTbO7pyPC61UjJGtDi6QafzoM467zQrDfNEBein2Wutm10f VP/cCi5Q/5kMc5bp3QG6GWcwJ7m7XBkRh/ISY4exjhAKfBuw1YbVs/Q0wEVWtsb/fOIa/51pbiB WQWb+JI6KIUGElrLg= X-Received: by 2002:a17:90b:3505:b0:341:c964:126c with SMTP id 98e67ed59e1d1-354b3d086f9mr10609077a91.34.1770718789479; Tue, 10 Feb 2026 02:19:49 -0800 (PST) X-Received: by 2002:a17:90b:3505:b0:341:c964:126c with SMTP id 98e67ed59e1d1-354b3d086f9mr10609053a91.34.1770718788995; Tue, 10 Feb 2026 02:19:48 -0800 (PST) Received: from [10.133.33.6] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82441695f50sm12314405b3a.22.2026.02.10.02.19.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 02:19:48 -0800 (PST) Message-ID: <08cec7fc-a3da-4879-857a-32dd65c34311@oss.qualcomm.com> Date: Tue, 10 Feb 2026 18:19:45 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] phy: qcom: edp: Add per-version LDO configuration callback To: Konrad Dybcio , Vinod Koul , Neil Armstrong , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-2-231882bbf3f1@oss.qualcomm.com> <200b055b-7221-45b5-aea1-2462e07a3c1c@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: <200b055b-7221-45b5-aea1-2462e07a3c1c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: t-uY3n6ISI84LqXiSS4ixLCbGh4jynl7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEwMDA4NSBTYWx0ZWRfX8Gbe3+ilgTqt B3A0UDfsnc9TUafSDU2PUw3Hl2ihtGhnPiDkXifV1iAtOp0qneFB5W+GdX2Adpnox7OksEG0NEP Rq/mo0719TTB9VP04ZzD9pziHhi3SHoqkcnXPARlyr+vROqFXKTQpFXNKv25BUrQrWaR02usBvw Zw/DMptNaiIlO66pwnTuthJrmL6/SDLVZztTIrcHT5K0Dfe1aLw6bGNhswNyYkd4yAfJ/rDA1KA YuF1DklrbGZJJ6C3T3CuzjpIkKJvyLuZrniXOJ52eIsw361BdGO+7Ok+Kd5kVdFR5QLr9gr4DcL tKzvDi4a5mjcg4LDLoVkph/Hz4l9/XCNd/tF+4ammzScXJI69l0JBvUcIxa0bTsEq4J7Z1U1hVo jRAN8HJ946qdxFuibX/9TgMcQIzr+SiGi9bHBVKckw6BkdlTOfvaqsqb+OAzphg79iMuDesqgoi NcpjnI+EKINYI2p/+OA== X-Authority-Analysis: v=2.4 cv=F6Rat6hN c=1 sm=1 tr=0 ts=698b0646 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=3p2AMVgKIYlyzUkkMicA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: t-uY3n6ISI84LqXiSS4ixLCbGh4jynl7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-10_01,2026-02-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100085 On 2/6/2026 6:52 PM, Konrad Dybcio wrote: > On 2/5/26 10:20 AM, Yongxing Mou wrote: >> Introduce the com_ldo_config callback to support per‑PHY LDO >> configuration. >> >> Signed-off-by: Yongxing Mou >> --- > > [...] > >> +static int qcom_edp_ldo_config_v4(const struct qcom_edp *edp) >> +{ >> + const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts; >> + u32 ldo_config; >> + >> + if (!edp->is_edp) >> + ldo_config = 0x0; >> + else if (dp_opts->link_rate <= 2700) >> + ldo_config = 0xC1; > > lowercase hex, please > Got it. will fix next version >> + else >> + ldo_config = 0x81; >> + >> + writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG); >> + writel(ldo_config, edp->tx1 + TXn_LDO_CONFIG); > > tx1 should be dp_ops->lanes ? 2 : ldo_config : 0x00, in all cases, > I believe > > Konrad i check the HPG, yes , here need to consider dp_ops->lanes.. will fix it next patch.