From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 377F61D435F for ; Tue, 16 Dec 2025 16:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765901726; cv=none; b=pcUN4RQdLjtQkxl+qSwJyptxLoxapcPZvLQXnpy3ss4pOR6LL3Z4Osybc9lylceGEXQyl37x5KtqfbJbW32iXuFmV1YwytZDLxjE4wOwBiV0FWpMFrIDiaPtpZuRgtR/ZR3otqUs9Fp/XdsNWvyxqCb5NoxSYSG0CAYnIh8P5jE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765901726; c=relaxed/simple; bh=a5UBlHHrvRTS3JC+zn/qQntr9gldXEwvmgrGRyb+jcg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EvFx78PIMCH7vGkeHO+DGk6FkWhn1DtNndh6YH1PubNiHhyNbIv9VJkTOe/7wH064ACzNfRlw7o7AewZDRbHhSI9UpVpRnHtvgrSqdJI1YjsJu4wjOimiNDq8JPmPyvQfl4fQrpZyJKDXlO+9zyOZo7wXp276GBbw9Mi9F1AbF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BRyh5C0J; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BRyh5C0J" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-47798ded6fcso31125375e9.1 for ; Tue, 16 Dec 2025 08:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765901721; x=1766506521; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WGSPO6qsmI9NuF2qc7Ml/qVSMOQyrqO1n4RFIIjYNR4=; b=BRyh5C0JjamfLcjDm6Fus4ghMqCvP1zroJDca71nCnA5mWTa4yqSUbbosT5ZA/VeDa PvCW3AnsgxOoi/3hj5ojfcQOBlQUjxo/RKVSRMmSg04X9VgIxCCFLoypLVcYe9D1V8pT SDPqFqBuNxo42eEoMQI07qYfNoyiun/VkxXF6kdql5RrdsQwCR69Mz2/9d7YGCyvJ56O zAq0HmCNtb2P88MRo4fK/zbi0eQFAoFu0L0u71Au7DMPHXvXov5kPZQqw1XjhhGOWcET VFL0xd1Z1nK8dsZ5tKj50DN0DoT+Vl6Rp6BC5e8h4IKaDCNcBVTIG+aTC3G3r/Vonuy8 o0lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765901721; x=1766506521; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WGSPO6qsmI9NuF2qc7Ml/qVSMOQyrqO1n4RFIIjYNR4=; b=ncFmy/Aj/Odccq7XTb7cKKfm2rPvgCSmeeSFwXswJquwU3qOU0WFNnd4CMxAuyiAGs djQSZlPzSBrkhDFJE2DM5Iv5fveqb8jrxDt+Pqxh963Imv3eZH3r89j+sgQr7IjmOjUp FE5SSUl1+aJ1i4eXbNfmaB2Meeg/Vq1eau9XBd438CqUwGyZB7npo5gsL4bhKTZYFhVd 0k4qUGvZ/OFCRVhWVVRn8Qw2SzQ7O0q/37tewXaXTp6QQ4viNejt/cD7oUbWHaBeB3+/ k5sKuGbiEVfW7qK8w3avcBAs5JmXNW+fPY9iluZGeUpzomD+HPVoj1xnzZg0T6MGLkUt jKIg== X-Forwarded-Encrypted: i=1; AJvYcCUxNiv7bBruFLF/8f3j0AxLY/S6BQhJfAvB1HIvAz5Q3U2mfG0WuYslNd/bFjh15Xg9lJ6ZJgwTVXaE93s=@vger.kernel.org X-Gm-Message-State: AOJu0YwbSH63ToanUXact8GFDIttaoa27FzETQjINe7wC6MVY0+eG3ov sAXYgG6NeIKXePtWHP7N+Fmjcmm6iAocdxV44+8Bd5E9B7lxjiXVYOrR X-Gm-Gg: AY/fxX76Jo4sjgWIGUw1xsmazE11gkGSqOFyRVKxApLFcuDokqJNae8CvCYhoDlcBhH ZM0uR0CQDMI4UgdtvAYX4oNxXZhxhQQAWcQob0wMv+wcz/WmLgOOohAmWaw5wAPazeQE8IaqO8o lh3tw2rTCZfYioRGtsb5cEPSflOeWhrsH62II7r/+Ae+Gg0BLhygHwx1vUVme378//8Nschtp7W y0r+dgoshGp3WzZlI4X5a1Qhn32R5szYFqcLFUweTqnTrb4i+Yz8rYRLpgu9TRdsBe3pTlUFVRv oMPyxULHxrSKSlWV8lB4WXMTEoBnH5APxJrIMwOmsJDGsqCoan3jB4sg9MYbgexWv/7gKBVkVH3 MB+8eVdm8lnwAVtuzf+KFIx7zvS9U9eYak42mD2uOdcvEGYhvVmmctCqfcMjYNpBk8lw2jna3K/ RJCHozJE5Lr2fL+VTNYEcamDMP2VqmbD1GCn5CpAOxTWqJS2Fv7pfpzwKUeBDyJ/h2fE5ouUO+B 9rO9Mm8EOizP0tMqwKUq5TPJWfvH2MeRYh/oX727xuVMRimF9VaucWm X-Google-Smtp-Source: AGHT+IGr5ud2LIyQ7R5OT/mlluw/76ko5OMRE3Aw6kFibrC+GBg5HKX0chI47WgVgI9wSkSsz4vtzA== X-Received: by 2002:a05:600c:19c6:b0:45c:4470:271c with SMTP id 5b1f17b1804b1-47a8f90598emr149262615e9.18.1765901720666; Tue, 16 Dec 2025 08:15:20 -0800 (PST) Received: from ?IPV6:2003:df:bf2d:e300:ef47:e8b9:f11f:76be? (p200300dfbf2de300ef47e8b9f11f76be.dip0.t-ipconnect.de. [2003:df:bf2d:e300:ef47:e8b9:f11f:76be]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f3240fasm256044245e9.0.2025.12.16.08.15.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Dec 2025 08:15:20 -0800 (PST) Message-ID: <08d00540-9de9-43a5-9e36-df2d575b4c24@gmail.com> Date: Tue, 16 Dec 2025 17:15:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v16 12/17] rust: sync: lock/global: Rename B to G in trait bounds To: Lyude Paul , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner Cc: Boqun Feng , Daniel Almeida , Miguel Ojeda , Alex Gaynor , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Andrew Morton , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long References: <20251215175806.102713-1-lyude@redhat.com> <20251215175806.102713-13-lyude@redhat.com> Content-Language: de-AT-frami, en-US From: Dirk Behme In-Reply-To: <20251215175806.102713-13-lyude@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15.12.25 18:57, Lyude Paul wrote: > Due to the introduction of Backend::BackendInContext, if we want to be able > support Lock types with a Context we need to be able to handle the fact > that the Backend for a returned Guard may not exactly match the Backend for > the lock. Before we add this though, rename B to G in all of our trait > bounds to make sure things don't become more difficult to understand once > we add a Backend bound. > > There should be no functional changes in this patch. > > Signed-off-by: Lyude Paul > --- > rust/kernel/sync/atomic.rs | 2 +- > rust/kernel/sync/lock/global.rs | 58 ++++++++++++++++----------------- > 2 files changed, 30 insertions(+), 30 deletions(-) > > diff --git a/rust/kernel/sync/atomic.rs b/rust/kernel/sync/atomic.rs > index 3afc376be42d9..c07a53f8360b4 100644 > --- a/rust/kernel/sync/atomic.rs > +++ b/rust/kernel/sync/atomic.rs > @@ -21,8 +21,8 @@ > mod predefine; > > pub use internal::AtomicImpl; > -pub use ordering::{Acquire, Full, Relaxed, Release}; > pub(crate) use internal::{AtomicArithmeticOps, AtomicBasicOps, AtomicExchangeOps}; > +pub use ordering::{Acquire, Full, Relaxed, Release}; Just fyi, there is a (trivial) conflict of this with Miguel's recently merged commit 309e49039f124a ("rust: sync: atomic: separate import "blocks"") https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/rust/kernel/sync/atomic.rs?id=309e49039f124a9dcb99c05651af8eb8fa05bc29 If I haven't missed anything this is just to fix the alphabetical order? So maybe this should go as an independent patch like Miguel's one? Dirk