From: Robin Murphy <robin.murphy@arm.com>
To: Amita Mishra <amitamishra@google.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: perf: arm,smmu-v3-pmcg: Allow power-domains
Date: Wed, 18 Nov 2026 13:07:06 +0000 [thread overview]
Message-ID: <08d06f8c-026c-4503-8783-6b8a1b59d620@arm.com> (raw)
In-Reply-To: <20261118101913.3135869-2-amitamishra@google.com>
On 2026-11-18 10:19 am, Amita Mishra wrote:
> On some SoCs, SMMUv3 Performance Monitor Counter Groups (PMCGs) reside
> in switchable power domains rather than an always-on domain.
>
> Document the optional power-domains property so that runtime power
> management can manage the PMCG power state.
Isn't power-domain-consumer one of the common schemas that's
automatically applicable to any node anyway? I would think that unless
we have a specific expectation and description of what each
power-domains entry should represent - which we cannot reasonably do in
a binding that is for the architectural PMCG interface rather than any
specific implementation of such - we'd be better off just leaving it
implicit.
> Signed-off-by: Amita Mishra <amitamishra@google.com>
> ---
> Documentation/devicetree/bindings/perf/arm,smmu-v3-pmcg.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/perf/arm,smmu-v3-pmcg.yaml b/Documentation/devicetree/bindings/perf/arm,smmu-v3-pmcg.yaml
> index a4b53a6a1ebf..aea6623bb98c 100644
> --- a/Documentation/devicetree/bindings/perf/arm,smmu-v3-pmcg.yaml
> +++ b/Documentation/devicetree/bindings/perf/arm,smmu-v3-pmcg.yaml
> @@ -36,6 +36,9 @@ properties:
>
> msi-parent: true
>
> + power-domains:
> + maxItems: 1
Even for existing implementations it would be quite possible for a PMCG
to be functionally dependent on multiple power domains (yes some of them
should usually be hierarchical, but still...) - what justifies 1 being
the only "correct" number?
Thanks,
Robin.
> +
> required:
> - compatible
> - reg
next prev parent reply other threads:[~2026-11-18 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 10:19 [PATCH 0/2] perf/smmuv3: Add runtime PM support Amita Mishra
2026-11-18 10:19 ` [PATCH 1/2] dt-bindings: perf: arm,smmu-v3-pmcg: Allow power-domains Amita Mishra
2026-11-18 13:07 ` Robin Murphy [this message]
2026-11-18 10:19 ` [PATCH 2/2] perf/smmuv3: Add runtime PM support Amita Mishra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08d06f8c-026c-4503-8783-6b8a1b59d620@arm.com \
--to=robin.murphy@arm.com \
--cc=amitamishra@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®