From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E7EC742A7 for ; Thu, 9 Mar 2023 01:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229850AbjCIB1H convert rfc822-to-8bit (ORCPT ); Wed, 8 Mar 2023 20:27:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbjCIB1F (ORCPT ); Wed, 8 Mar 2023 20:27:05 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12E9983178; Wed, 8 Mar 2023 17:27:03 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 3FC4224E057; Thu, 9 Mar 2023 09:26:55 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 9 Mar 2023 09:26:55 +0800 Received: from [192.168.120.42] (171.223.208.138) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 9 Mar 2023 09:26:54 +0800 Message-ID: <08d3d24b-f568-0592-6e77-07113cde86be@starfivetech.com> Date: Thu, 9 Mar 2023 09:26:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v5 04/12] dt-bindings: net: Add support StarFive dwmac Content-Language: en-US To: Rob Herring CC: , , , , "David S . Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , "Krzysztof Kozlowski" , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis , Yanhong Wang References: <20230303085928.4535-1-samin.guo@starfivetech.com> <20230303085928.4535-5-samin.guo@starfivetech.com> <20230308215915.GA3911690-robh@kernel.org> From: Guo Samin In-Reply-To: <20230308215915.GA3911690-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -------- 原始信息 -------- Re: [PATCH v5 04/12] dt-bindings: net: Add support StarFive dwmac From: Rob Herring > On Fri, Mar 03, 2023 at 04:59:20PM +0800, Samin Guo wrote: >> From: Yanhong Wang >> >> Add documentation to describe StarFive dwmac driver(GMAC). >> >> Signed-off-by: Yanhong Wang >> Signed-off-by: Samin Guo >> --- >> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >> .../bindings/net/starfive,jh7110-dwmac.yaml | 117 ++++++++++++++++++ >> MAINTAINERS | 6 + >> 3 files changed, 124 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index 89099a888f0b..395f081161ce 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -91,6 +91,7 @@ properties: >> - snps,dwmac-5.20 >> - snps,dwxgmac >> - snps,dwxgmac-2.10 >> + - starfive,jh7110-dwmac >> >> reg: >> minItems: 1 >> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> new file mode 100644 >> index 000000000000..ca49f08d50dd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> @@ -0,0 +1,117 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2022 StarFive Technology Co., Ltd. >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 DWMAC glue layer >> + >> +maintainers: >> + - Emil Renner Berthing >> + - Samin Guo >> + >> +select: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - starfive,jh7110-dwmac >> + required: >> + - compatible >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - starfive,jh7110-dwmac >> + - const: snps,dwmac-5.20 >> + >> + clocks: >> + items: >> + - description: GMAC main clock >> + - description: GMAC AHB clock >> + - description: PTP clock >> + - description: TX clock >> + - description: GTX clock >> + >> + clock-names: >> + items: >> + - const: stmmaceth >> + - const: pclk >> + - const: ptp_ref >> + - const: tx >> + - const: gtx >> + >> + resets: >> + items: >> + - description: MAC Reset signal. >> + - description: AHB Reset signal. >> + >> + reset-names: >> + items: >> + - const: stmmaceth >> + - const: ahb >> + >> + starfive,tx-use-rgmii-clk: >> + description: >> + Tx clock is provided by external rgmii clock. >> + type: boolean >> + >> +allOf: >> + - $ref: snps,dwmac.yaml# >> + >> +unevaluatedProperties: true > > This must be false. > Thanks, will fix net version. >> + >> +required: >> + - compatible >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + >> +examples: >> + - | >> + ethernet@16030000 { >> + compatible = "starfive,jh7110-dwmac", "snps,dwmac-5.20"; >> + reg = <0x16030000 0x10000>; >> + clocks = <&clk 3>, <&clk 2>, <&clk 109>, >> + <&clk 6>, <&clk 111>; >> + clock-names = "stmmaceth", "pclk", "ptp_ref", >> + "tx", "gtx"; >> + resets = <&rst 1>, <&rst 2>; >> + reset-names = "stmmaceth", "ahb"; >> + interrupts = <7>, <6>, <5>; >> + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; >> + phy-mode = "rgmii-id"; >> + snps,multicast-filter-bins = <64>; >> + snps,perfect-filter-entries = <8>; >> + rx-fifo-depth = <2048>; >> + tx-fifo-depth = <2048>; >> + snps,fixed-burst; >> + snps,no-pbl-x8; >> + snps,tso; >> + snps,force_thresh_dma_mode; >> + snps,axi-config = <&stmmac_axi_setup>; >> + snps,en-tx-lpi-clockgating; >> + snps,txpbl = <16>; >> + snps,rxpbl = <16>; >> + phy-handle = <&phy0>; >> + >> + mdio { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + compatible = "snps,dwmac-mdio"; >> + >> + phy0: ethernet-phy@0 { >> + reg = <0>; >> + }; >> + }; >> + >> + stmmac_axi_setup: stmmac-axi-config { >> + snps,lpi_en; >> + snps,wr_osr_lmt = <4>; >> + snps,rd_osr_lmt = <4>; >> + snps,blen = <256 128 64 32 0 0 0>; >> + }; >> + }; >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 5c67c75a940f..4e236b7c7fd2 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -19912,6 +19912,12 @@ M: Emil Renner Berthing >> S: Maintained >> F: arch/riscv/boot/dts/starfive/ >> >> +STARFIVE DWMAC GLUE LAYER >> +M: Emil Renner Berthing >> +M: Samin Guo >> +S: Maintained >> +F: Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> + >> STARFIVE JH71X0 CLOCK DRIVERS >> M: Emil Renner Berthing >> M: Hal Feng >> -- >> 2.17.1 >> -- Best regards, Samin