From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25E463594B for ; Thu, 2 Oct 2025 02:01:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759370487; cv=none; b=qEvWl71EVqgZ8VxMmQdnN+FsqpFVTaFkRPKMG/x37GdNwp70qrjmqBlYgkp0BgGYmvLwmSCQ83ej1In5A5C4+p3taKjX4YOvqa4LTxLE80yscWdWzQIiEVjdsN0aOGysTC+PfV8rpGBC06lxYS05fYGYLmjEOTW2Gi6z8LB3Qtc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759370487; c=relaxed/simple; bh=PPUI2geMS9zlzoaHXsJ0CztmeGxA29GYz5yY5qTmqeA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ragy7FuQnLN7oPFh19oCIjuWddV9ntQNEdZC7dUub1XuXOqKcNFMXFclnDzGJFfvAJ8bHS6cWafda8mpPUE9nR4DfCiXFK9Cx7QlSC5HnCvf6/ByadXLxCjcnQZtdQ5T8toUv2M2u/OQAJgql7V76xj5k/SYNxEYKom01ul3dHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h/iOd7EQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h/iOd7EQ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 591Ibsur023316 for ; Thu, 2 Oct 2025 02:01:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8NbEfizQUWTtDuaEiGJY++Pou4KpkObXybJBlqEsClc=; b=h/iOd7EQuMAXWcW+ lt/DfTy7srrrVXQlpy4eHttGCQZKu+LO2EkpkiX8uW2e3SRca+ofZzGIXmgz/0JY YS1mTVxfh7pyzgKTdyr0Hot0NrERkRkKJS1acgTb6YtiyQNd9cxUw2dGRLUfkNAD +Kvicuip4oflpXRVdN4vWZdOkknvng3w7sV6kuGypfDizC0MJPdzC8q5/vHY4huL prPaDiz3PGnINX8xiBPPYShLRcEXoqUGhQB7lNsnI2F/tfv10xK+5ACLVr12nldp EqBbxwXbDnLnp0AIKv0uKIJHm28ZmG+2s5NOeVfgsUWRJTiTsJiQ0+iXaksIql48 URsDvA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49e8a66e7e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 02 Oct 2025 02:01:23 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-781269a9049so883278b3a.2 for ; Wed, 01 Oct 2025 19:01:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759370482; x=1759975282; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8NbEfizQUWTtDuaEiGJY++Pou4KpkObXybJBlqEsClc=; b=T/cbtzz2G8ynwZG0cEmY02jf4/yqG+o7tD+bF4yzghF4ZLcV+NcctpvnTqbvA7RXbl IbNJtvui77a3OEzyr90euF8m8yzFg7a54grF7PIqtMYWtqlW5wbc6qouvuZXPPa8ktYx ODvAxJHaZELLlCcI7eJiBFp2uy8Dcy2DSjvoFzBJQsnLXBRWmWPc/BV+LAO7/KPMCfd7 iRjyLVxa88AKSzG4LlqdkLoulACpAenn/SA9JbedvOUrJ4wec/86vrSzIZwPQlnT09eq VQSs0ONTS6qO3P0F47FmkmK+i/rteq0yRh8Ek25tYM9gL9Jrd38+UAeZBhFI8gb0x6p4 +10A== X-Forwarded-Encrypted: i=1; AJvYcCXA7yNbnXrxFvFwvt+ijeG3OCxYDUgiYsImnvZOKJOS9Qt18reJ+K02Vb5EflXPqt/Beu8LQdFVT8PpUyE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywem0EsjmFORMFSpm2RW2Jw1mJBvrgeXP3U4t+R1RwPJrlhjGA0 akY94UayDE20ooPhm9KUp1F7kUP2aTiR6pfOaaya8ITgPRlcim0cftew5WRUWlak62AAjuwDpJ8 FNGZJc6nIBt+/SfxPFQlsW99P7EXVQT023v4lcDjFc90tIMR3tNB5SLngY+qEZzAxXCY= X-Gm-Gg: ASbGnctavrZQifbxStkGto8FK+5u9kCLOQl/wphRAaAKHeLCe+OIzIHWiSWtCWYODfu A1+NnE3s3lpu287zQZFeY72+3eXkBKahF36bkXlBAc1rery4p9j/ilfLNEd7Y1Juoi9NVXTOnRg lHwgds3gnr3Brv93374W3U16UL0SZRyrDy52W+wd8E7PfPtF1FlJYCJJ3nhRxgTCxKYOCRWUFXN x/IVSzdqPOJX5+WpPEq0YAYMRUdd9hwXQVJUS1EQAotlKPXTX2g88FA+9vgATCb289dnrkpKLha UcuHeSRAXxRc9sjkuO2HDMqpuIrUcyZe2eEXbJwQISJ42R8lFuk6aYWi+B1a2UCKrqGu8U0t92z vTZ+g X-Received: by 2002:a05:6a20:3946:b0:2e3:a914:aa93 with SMTP id adf61e73a8af0-321e477bf0dmr7670873637.30.1759370482219; Wed, 01 Oct 2025 19:01:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjOOZ64bXPfAFXM3hKJDHB/mu2en9QreyGMP6Drwrt0qG8NWYPcUKAYjBPa3c+kv8YUlnAJg== X-Received: by 2002:a05:6a20:3946:b0:2e3:a914:aa93 with SMTP id adf61e73a8af0-321e477bf0dmr7670805637.30.1759370481669; Wed, 01 Oct 2025 19:01:21 -0700 (PDT) Received: from [192.168.29.113] ([49.43.226.92]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-78b01fcc45fsm999528b3a.39.2025.10.01.19.01.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 19:01:21 -0700 (PDT) Message-ID: <08d64683-cea7-4e39-bde4-5b6cd213afee@oss.qualcomm.com> Date: Thu, 2 Oct 2025 07:31:12 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] arm64: dts: qcom: sm8750: Add PCIe PHY and controller node To: Bjorn Andersson Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, quic_vbadigan@quicinc.com, quic_mrana@quicinc.com References: <20250826-pakala-v3-0-721627bd5bb0@oss.qualcomm.com> <20250826-pakala-v3-2-721627bd5bb0@oss.qualcomm.com> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=RZKdyltv c=1 sm=1 tr=0 ts=68dddcf3 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=jyboLUZ+MFoqbd6eZ184Eg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=EUspDBNiAAAA:8 a=AkHrb9cOowbY_nbVBZgA:9 a=l78PwBI5Ku7GpRGV:21 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: CBeTabUFW3zQioEh8fklOwRhFK24YyQY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI3MDAzMyBTYWx0ZWRfX4RGDpY/n7VlJ 41ktTHyaYxajR6JcYX+3sZ9LzkCjEoFYQFdAbGcxpDuP7espUGxY3WoKxA8nbitQu7rr6OWynkf NtORgks4Rspl8ldR4YhykQnhSCxG8lMCR/C+cWnM3iY6hg0oUUSzV2vAjQPEYEMVSU85c6uY5VE 0xfQPPa4zuhQPt3uOpPFK6/o863SG1V6fBEiyzUJ+QMtAJBhE3hNj6EXRPsn4uKh9zLbrDkhmro SrunzJQfdSXsKBDIaNmJwokUr8oCGY/ld0a5+CdqIW6C2mbCbajuFzHG83b3iKJiXtv8fxWB75c oLN4CRg1RKvTbFY14UhLs7++LO3ciWUeU/IZJMhc2N5JkPyIZB7mjgVzULCliqW7zkFCZcRXPUo X7ktLdvEkfiVwyv1E89gnym37kKw2A== X-Proofpoint-ORIG-GUID: CBeTabUFW3zQioEh8fklOwRhFK24YyQY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-02_01,2025-09-29_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509270033 On 10/2/2025 5:07 AM, Bjorn Andersson wrote: > On Tue, Aug 26, 2025 at 04:32:54PM +0530, Krishna Chaitanya Chundru wrote: >> Add PCIe controller and PHY nodes which supports data rates of 8GT/s >> and x2 lane. >> > > I tried to boot the upstream kernel (next-20250925 defconfig) on my > Pakala MTP with latest LA1.0 META and unless I disable &pcie0 the device > is crashing during boot as PCIe is being probed. > > Is this a known problem? Is there any workaround/changes in flight that > I'm missing? > The only required change for this is the driver change in this series [3/3] PCI: qcom: Restrict port parsing only to pci child nodes - Krishna Chaitanya. > Regards, > Bjorn > >> Signed-off-by: Krishna Chaitanya Chundru >> --- >> arch/arm64/boot/dts/qcom/sm8750.dtsi | 180 ++++++++++++++++++++++++++++++++++- >> 1 file changed, 179 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi >> index 4643705021c6ca095a16d8d7cc3adac920b21e82..b47668a64bcead3e48f58eeb2e41c04660493cb7 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi >> @@ -631,7 +631,7 @@ gcc: clock-controller@100000 { >> clocks = <&bi_tcxo_div2>, >> <0>, >> <&sleep_clk>, >> - <0>, >> + <&pcie0_phy>, >> <0>, >> <0>, >> <0>, >> @@ -3304,6 +3304,184 @@ gic_its: msi-controller@16040000 { >> }; >> }; >> >> + pcie0: pcie@1c00000 { >> + device_type = "pci"; >> + compatible = "qcom,pcie-sm8750", "qcom,pcie-sm8550"; >> + reg = <0x0 0x01c00000 0x0 0x3000>, >> + <0x0 0x40000000 0x0 0xf1d>, >> + <0x0 0x40000f20 0x0 0xa8>, >> + <0x0 0x40001000 0x0 0x1000>, >> + <0x0 0x40100000 0x0 0x100000>, >> + <0x0 0x01C03000 0x0 0x1000>; >> + reg-names = "parf", >> + "dbi", >> + "elbi", >> + "atu", >> + "config", >> + "mhi"; >> + >> + #address-cells = <3>; >> + #size-cells = <2>; >> + ranges = <0x01000000 0x0 0x00000000 0x0 0x40200000 0x0 0x100000>, >> + <0x02000000 0x0 0x40300000 0x0 0x40300000 0x0 0x23d00000>, >> + <0x03000000 0x4 0x00000000 0x4 0x00000000 0x3 0x00000000>; >> + bus-range = <0x00 0xff>; >> + >> + dma-coherent; >> + >> + linux,pci-domain = <0>; >> + >> + msi-map = <0x0 &gic_its 0x1400 0x1>, >> + <0x100 &gic_its 0x1401 0x1>; >> + msi-map-mask = <0xff00>; >> + >> + num-lanes = <2>; >> + >> + interrupts = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; >> + interrupt-names = "msi0", >> + "msi1", >> + "msi2", >> + "msi3", >> + "msi4", >> + "msi5", >> + "msi6", >> + "msi7", >> + "global"; >> + >> + #interrupt-cells = <1>; >> + interrupt-map-mask = <0 0 0 0x7>; >> + interrupt-map = <0 0 0 1 &intc 0 0 0 149 IRQ_TYPE_LEVEL_HIGH>, >> + <0 0 0 2 &intc 0 0 0 150 IRQ_TYPE_LEVEL_HIGH>, >> + <0 0 0 3 &intc 0 0 0 151 IRQ_TYPE_LEVEL_HIGH>, >> + <0 0 0 4 &intc 0 0 0 152 IRQ_TYPE_LEVEL_HIGH>; >> + >> + clocks = <&gcc GCC_PCIE_0_AUX_CLK>, >> + <&gcc GCC_PCIE_0_CFG_AHB_CLK>, >> + <&gcc GCC_PCIE_0_MSTR_AXI_CLK>, >> + <&gcc GCC_PCIE_0_SLV_AXI_CLK>, >> + <&gcc GCC_PCIE_0_SLV_Q2A_AXI_CLK>, >> + <&gcc GCC_DDRSS_PCIE_SF_QTB_CLK>, >> + <&gcc GCC_AGGRE_NOC_PCIE_AXI_CLK>, >> + <&gcc GCC_CNOC_PCIE_SF_AXI_CLK>; >> + clock-names = "aux", >> + "cfg", >> + "bus_master", >> + "bus_slave", >> + "slave_q2a", >> + "ddrss_sf_tbu", >> + "noc_aggr", >> + "cnoc_sf_axi"; >> + >> + interconnects = <&pcie_noc MASTER_PCIE_0 QCOM_ICC_TAG_ALWAYS >> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, >> + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS >> + &cnoc_main SLAVE_PCIE_0 QCOM_ICC_TAG_ALWAYS>; >> + interconnect-names = "pcie-mem", >> + "cpu-pcie"; >> + >> + iommu-map = <0x0 &apps_smmu 0x1400 0x1>, >> + <0x100 &apps_smmu 0x1401 0x1>; >> + >> + resets = <&gcc GCC_PCIE_0_BCR>; >> + reset-names = "pci"; >> + >> + power-domains = <&gcc GCC_PCIE_0_GDSC>; >> + >> + operating-points-v2 = <&pcie0_opp_table>; >> + >> + status = "disabled"; >> + >> + pcie0_opp_table: opp-table { >> + compatible = "operating-points-v2"; >> + >> + /* GEN 1 x1 */ >> + opp-2500000 { >> + opp-hz = /bits/ 64 <2500000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> + opp-peak-kBps = <250000 1>; >> + }; >> + >> + /* GEN 1 x2 and GEN 2 x1 */ >> + opp-5000000 { >> + opp-hz = /bits/ 64 <5000000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> + opp-peak-kBps = <500000 1>; >> + }; >> + >> + /* GEN 2 x2 */ >> + opp-10000000 { >> + opp-hz = /bits/ 64 <10000000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> + opp-peak-kBps = <1000000 1>; >> + }; >> + >> + /* GEN 3 x1 */ >> + opp-8000000 { >> + opp-hz = /bits/ 64 <8000000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + opp-peak-kBps = <984500 1>; >> + }; >> + >> + /* GEN 3 x2 */ >> + opp-16000000 { >> + opp-hz = /bits/ 64 <16000000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + opp-peak-kBps = <1969000 1>; >> + }; >> + >> + }; >> + >> + pcieport0: pcie@0 { >> + device_type = "pci"; >> + reg = <0x0 0x0 0x0 0x0 0x0>; >> + bus-range = <0x01 0xff>; >> + >> + #address-cells = <3>; >> + #size-cells = <2>; >> + ranges; >> + phys = <&pcie0_phy>; >> + }; >> + }; >> + >> + pcie0_phy: phy@1c06000 { >> + compatible = "qcom,sm8750-qmp-gen3x2-pcie-phy"; >> + reg = <0 0x01c06000 0 0x2000>; >> + >> + clocks = <&gcc GCC_PCIE_0_AUX_CLK>, >> + <&gcc GCC_PCIE_0_CFG_AHB_CLK>, >> + <&tcsrcc TCSR_PCIE_0_CLKREF_EN>, >> + <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>, >> + <&gcc GCC_PCIE_0_PIPE_CLK>; >> + clock-names = "aux", >> + "cfg_ahb", >> + "ref", >> + "rchng", >> + "pipe"; >> + >> + assigned-clocks = <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>; >> + assigned-clock-rates = <100000000>; >> + >> + resets = <&gcc GCC_PCIE_0_PHY_BCR>; >> + reset-names = "phy"; >> + >> + power-domains = <&gcc GCC_PCIE_0_PHY_GDSC>; >> + >> + #clock-cells = <0>; >> + clock-output-names = "pcie0_pipe_clk"; >> + >> + #phy-cells = <0>; >> + >> + status = "disabled"; >> + }; >> + >> ufs_mem_phy: phy@1d80000 { >> compatible = "qcom,sm8750-qmp-ufs-phy"; >> reg = <0x0 0x01d80000 0x0 0x2000>; >> >> -- >> 2.34.1 >>