From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752838AbdCNNrj (ORCPT ); Tue, 14 Mar 2017 09:47:39 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:55858 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751703AbdCNNrg (ORCPT ); Tue, 14 Mar 2017 09:47:36 -0400 Subject: Re: [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data To: Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz References: <20170313190726.2988-1-krzk@kernel.org> <20170313190726.2988-3-krzk@kernel.org> <2568764.DQnxL2m83S@amdc3058> Cc: Kukjin Kim , Javier Martinez Canillas , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <08e02fbe-a059-fae9-ad08-ccd32a9602a7@roeck-us.net> Date: Tue, 14 Mar 2017 06:47:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/14/2017 06:20 AM, Krzysztof Kozlowski wrote: > On Tue, Mar 14, 2017 at 3:17 PM, Bartlomiej Zolnierkiewicz > wrote: >> >> Hi, >> >> On Monday, March 13, 2017 09:07:25 PM Krzysztof Kozlowski wrote: >>> Simplify the flow in helper function for getting the driver data by >>> using of_device_get_match_data() and only one if() branch. >>> >>> The code should be equivalent. >> >> While you are at it could you remove s3c2410_get_wdt_drv_data() >> helper? It is used only once during probe and is marked inline >> anyway.. > > Thanks for feedback! > The existence of this helper is purely from code readability (thus > inline does not matter). The probe is big so splitting some small > self-contained part helps. Not much but a little... > Agreed. I don't see value in removing this helper. Guenter