From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3274190685 for ; Sun, 28 Sep 2025 14:20:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759069239; cv=none; b=GccS2j3aaAU0au8DW7cCoQzbuv7qe/GPVnigkGDfwOCF4TiENRUKUx2W4rEJXqeTSZR076HfzFlrjEyWb5nKnIcRFQiWMooobhIeMskp+Crm+s8DUBxnNciGH3ddWjDbzVjSSncY57tNazfVVWYu5PJ5HW8wHl8kHnZMbyxKQvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759069239; c=relaxed/simple; bh=MABUtmW7hs3j6sSEFukRcJjPKjgLALDyIMyqN3Z/8cI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q8OLn+yAZ5D+vlqiIpf4cDQz0kXA5F6DwTR+Po35n1EuYhwr3VdVU8n43FJmb3ncwXY3j57u+GHn1dhYp3C9jWhxc24DOBAuCWlnEat81ViFTO6tJ+XUiCNNyXJL6cXEKC+7CANuTdfsB0tLEKvj4pHIL9+uyuyg2fX6EFUZrh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CPaurFue; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CPaurFue" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-78104c8cbb4so3847424b3a.0 for ; Sun, 28 Sep 2025 07:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759069237; x=1759674037; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=jBliwOJXPnzX5/lt9z5sUm0XkPB682hQdmEorp2useA=; b=CPaurFue6DK9B34TD9XFm9HG7q+SEKVlXX5IDoj6wjsNxk443b+H38QBl2xrf8NZdz ROqok5nkpBn68T9vOVZ+WGhzZ5rauPm/dowp8GI5E9kdvS8QnT9d24Z+eGQAOw8Jla6z xfMcnwzcCBP6CiEZ3OD87dMceq1GT6TjxVPLUDtwqhBAcZ9doDPLkqrvWZ2gzcPXAh9b CRxlofzgIyzkcp2ycb4YI8Akb17QyX0dC/jfIg3TWxtLxU45pJphKdXbmeaS6XkFc/XQ BRxlPcxFvq2ATb29ILJ8kcMvXNfbDGJUDkS37RZJjOmWxYnfG+rZewFgYQcK78rSPmyT EVsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759069237; x=1759674037; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jBliwOJXPnzX5/lt9z5sUm0XkPB682hQdmEorp2useA=; b=WYAKvCSZb3hBoCpdN/V4KwF+tnUbUFbrBOktpC+i5xV8tRnFTz4a/fnSVifx1pqwqa 6kI4UuoqtOlGdqOTtar5m5r4fOciFiCIqPr9q3Yvt0mg9F+ByueWQA1wMNhWeP9VdcLf rB0ILjyF8BxerBaf8sE3rgqUkNaQG5hWwBsmMkr+v7ESDoDW9ARZgWzh7fqOqXdSHrOx Kb1x62o+QZX2qepYdriiV3AqBTnf2Q89m7PdAIuyQJJs/SsUBcbcYEpyzmcIMhRCgdGN 2lZyawT2zcIa9WpjFjPWXWczHMKN4NCrbH+8gLeo0wOm5oLFD3tn9zKORiBDvie6RKIU tANA== X-Forwarded-Encrypted: i=1; AJvYcCX3wmhVXKsROEi3lOEispPemKAUN+Wt1AIbEQt99bnVIzdnGpE6fv+o72b5afNsMo8Qw2Kd58KYkHJXe4w=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo2PwClH2OkyL982NVKhsgqHffPto1w3zqPUgMxFs4x4qWM37a FrCs7u6tLmgjLIfMefLQLGWfmM9QWMgjdBaKrWBSJ68zB7fsico79u0Nmw8cesgP X-Gm-Gg: ASbGnctRe0VJSvn/iN22sU1xN4sZYg9W8WrHnpgQzt3oYYF5uhSveuN6muPNY7nx+cU GeHk4W5+uJc7Oo3KigifHVaUIYFwtg6BZETIU79b+6b/BKAQ+aHLHIDDCc+MnqdFOqCOvcpkRKy OdMHCI1+buAkF4lfBSMiaIYYBDdDEK1gXMe1stut+wpIpEvGZp8iAif1/kr/nL7/Tr1mIYNTel9 BGOsnX1tLraGP21YqDxH8aiKC3fkeIn/m9FHVdFCEnp7Xt2vJcveiMtMo1DZVhMmaZnGDHnfo3I 4H4OWAUGfQbCrx4iMk4Ctr2L/XS7SJE4bqrnK+ns9eLmUK7+IB34pY4KnBc35W1jAo0AQvcX8ce jag8S4QHV+c1sG7l8bDuQkdYDKJhPjLLX6taKIyIv8Q/U0Gni5eKuxxG6f2sRTaxdIYvC11tarF fgq0a69g== X-Google-Smtp-Source: AGHT+IHVLp13cexWtdeZOpKIUVtPdhV6F5Ee+dX4OY0UFLu6wmCVbE3Gx8hDTID8re6UlOrb9jFCBA== X-Received: by 2002:a05:6a20:7348:b0:251:9f29:4553 with SMTP id adf61e73a8af0-2e7c1bd0c99mr17754459637.10.1759069237022; Sun, 28 Sep 2025 07:20:37 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b57c53cac77sm9207630a12.17.2025.09.28.07.20.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Sep 2025 07:20:36 -0700 (PDT) Sender: Guenter Roeck Message-ID: <08e2bfe4-8cee-4d72-96ed-30d1e04e8f63@roeck-us.net> Date: Sun, 28 Sep 2025 07:20:35 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] via_wdt: fix critical boot hang due to unnamed resource allocation To: Li Qiang , wim@linux-watchdog.org Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250928083332.3035370-1-liqiang01@kylinos.cn> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20250928083332.3035370-1-liqiang01@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/28/25 01:33, Li Qiang wrote: > The VIA watchdog driver uses allocate_resource() to reserve a MMIO > region for the watchdog control register. However, the allocated > resource was not given a name, which causes the kernel resource tree > to contain an entry marked as "" under /proc/iomem on x86 > platforms. > > During boot, this unnamed resource can lead to a critical hang because > subsequent resource lookups and conflict checks fail to handle the > invalid entry properly. FWIW, I only see the name used in print messages, which should show when called with a NULL pointer. Some more details would have been useful, especially with the idea in mind that a missing resource name should be reported but not result in a hang and/or crash. > > Signed-off-by: Li Qiang Reviewed-by: Guenter Roeck Guenter > --- > drivers/watchdog/via_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c > index d647923d68fe..f55576392651 100644 > --- a/drivers/watchdog/via_wdt.c > +++ b/drivers/watchdog/via_wdt.c > @@ -165,6 +165,7 @@ static int wdt_probe(struct pci_dev *pdev, > dev_err(&pdev->dev, "cannot enable PCI device\n"); > return -ENODEV; > } > + wdt_res.name = "via_wdt"; > > /* > * Allocate a MMIO region which contains watchdog control register