From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA0FE2C3278 for ; Fri, 2 Jan 2026 09:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347374; cv=none; b=a59HUtjo1AsjoB35xCxOoG2LShil9pwteT8M+3AP0PJUoHcy6V/NcZroM7UO5MvERzK9H1tkCQHLTkd0W64TuK303+6gip36eI7mS+xNZR4uVROFWwjNmc4pFkCry4nOVBxALAyarxSB9/0UGgt12z5++i1u6OIYQm/OL2zvXKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767347374; c=relaxed/simple; bh=slFegTz3P/JluIXvMbOc1Pvvjimz+yXm422YyUVjw0U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DOx8clpcRiI/EdBquhjn4pMV9HHKMCFDETzuuda0GZKpRiCEdqOUEAr/foJ/wrqdmtMp5FkUpgizoMUVTh1wjTY8yWE27wVnpRQVpqVetNfhivQlio+CEn7Mtkq5RD1HeMkozB9UpaFev3x2v9mQE8zHo0QaGwKUhId+QkgHto4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Z6YsgHnW; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z6YsgHnW" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-64d80a47491so17914005a12.1 for ; Fri, 02 Jan 2026 01:49:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767347370; x=1767952170; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BsVkQf9vQJk/04twE5FzoYDgeZD8nWuhZIHPbDLZt1o=; b=Z6YsgHnWKkFUE+jv0NUGas+KtUxvsImT+RQMwvkCiPlNL+Rb3J53VQsSiI5sKuM/fP lLrJRX1woAScvzKgUM3sJEIB6CxamQjxtyIR/pHIXO8elG0rnRVP7V4dVBJxFHRmZuSZ CGCCOQztRS9BGhS2hOaYuFB/hUSTpMZ2qZ+AL0h62O1EnRD6lmGAx8mX+j0d3HdYn4Xp 4bFwZMpbOqUMMZJJGr6/YNisgIq0gbo8uNZDjC8GUNKR5F1dkDoiVKizRcza61Bn7o+n NsjFq04/e0RTmMo99Xx8X9u7xtG4rQofFKutWNZ9FFEyffyrt/5k0f2SkiTcSDjP41hQ mC+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767347370; x=1767952170; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BsVkQf9vQJk/04twE5FzoYDgeZD8nWuhZIHPbDLZt1o=; b=uDVKjIuo/0xbC6U6QdGPB3bzyVqSoRy69K6EtBd1t1Oss9EBcXF3DW4e36pkeK7ftQ Wtf7Ifn4BPF5ypCyCqxpdJzV/IuLaYGKB6FttgHH2heLf6KofwqENCvYA5lS3wThQvT5 AERzYM9br4G1zFpIs75nYyh1J6opaHJ9fZopXVRH0bt6dAl5QbTItE52MnmDl4h5BjNZ qEkeF1dLhchRZzWWxETVskULlgJI8djKbxrpLs0/bEnJnYMlUtFVpRgd2deuoVMabE9C TRG5mqKmRNZt5L6N8w9FHRtNHJCuV5XkkZwgYNlnDdOtdJ1jel30szbSpC2NgL8srdD/ wb4w== X-Forwarded-Encrypted: i=1; AJvYcCVc5mhO/CR7Yx65zoN6p/zIRP85T7RfJx3lgMOqWTvJdpWXeDw5tBdpFDB4Vlw/cbQpag2x8SHQECHOXd0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywjx0yGvRdwxHEaYd+FOVXcebGTy9hmC0KOiIXZseVig3143RLk 3mnVWsijgnVqvS0szNA1S+z0ZKj3FzSwTsmjS1hZNusykd6s3UnZKPFKzKf9D4obWVg= X-Gm-Gg: AY/fxX4Hxc0t3yTmopuOBxjjI8e+ZU8cifm+M7I5oLedcQwIIWF8JjZ6f9B7xwmSyxH FiNYqIwy09ntCOClhCVl9KhlyVBt1fkb0pXZVmj3Zt5UQjIQeXgjzrQyKYgAjxU+JRpzQS54tg4 OHRHYhG4F9FRCINgrPTrb0iYutT4KPU05KVZ7vtZcrsReY/4VwCjS6bEFbTpDxBPElxAN0HWs5K f5FqjWF/+mL6lqctdbVZlkyJFiIx4x8J1d7qeYWqsRjXGJFfLr/qzh5DvW0AoXSGY6P+Pt+WF26 1LDBk6Z3PU7BrX3duAi7dddRMCH+E978d2NqiNnnHdEXpJWT5/ZhdaTiYDAN3C+/8EC8J3GzBC5 wokf0ZM4PuYJ5xesLsWxcvvLNkU7Q2/ZixDQYLhS2Uv/E9Th1yFT3BYkY9D0jtvwUPnsephcn/e 7zZ3aeGnpTvmvNCJcPOwB88QwhSUWjcKhzXn2UI9WObJVbq5L444xM22zi/iDl2MITClZkyO050 M6Db5VMIRPerWTejMCrbZzHBXhlkM4ir2M0oMtoL00q21ujM2xBavm7X3i0SJhZlg2jIb44te9Y sqbdrplJhyhv X-Google-Smtp-Source: AGHT+IETWYWx735xjxVe/6RROWIkDsSn4NVtXPCKugmKHVhMX7CMbKQDhu4KgO1/800miWdtKnSrDA== X-Received: by 2002:a05:6402:50d1:b0:64b:4617:7717 with SMTP id 4fb4d7f45d1cf-64b8d24ebb3mr43849047a12.9.1767347369962; Fri, 02 Jan 2026 01:49:29 -0800 (PST) Received: from ?IPV6:2001:1c06:2302:5600:7555:cca3:bbc4:648b? (2001-1c06-2302-5600-7555-cca3-bbc4-648b.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:7555:cca3:bbc4:648b]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91494cd7sm42644033a12.16.2026.01.02.01.49.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jan 2026 01:49:29 -0800 (PST) Message-ID: <08e380fe-91e5-49a4-8fc0-8ec64a7c89a8@linaro.org> Date: Fri, 2 Jan 2026 09:49:26 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] clk: qcom: gcc-x1e80100: Do not turn off PCIe GDSCs during gdsc_disable() To: Krishna Chaitanya Chundru , Bjorn Andersson , Michael Turquette , Stephen Boyd , Taniya Das , Konrad Dybcio , Bartosz Golaszewski , Shazad Hussain , Sibi Sankar , Melody Olvera , Dmitry Baryshkov , Taniya Das , Dmitry Baryshkov , Konrad Dybcio , Imran Shaik , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , manivannan.sadhasivam@oss.qualcomm.com, stable@vger.kernel.org References: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> <20260102-pci_gdsc_fix-v1-6-b17ed3d175bc@oss.qualcomm.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20260102-pci_gdsc_fix-v1-6-b17ed3d175bc@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/01/2026 09:43, Krishna Chaitanya Chundru wrote: > With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This > can happen during scenarios such as system suspend and breaks the resume > of PCIe controllers from suspend. > > So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs > during gdsc_disable() and allow the hardware to transition the GDSCs to > retention when the parent domain enters low power state during system > suspend. > > Fixes: 161b7c401f4b ("clk: qcom: Add Global Clock controller (GCC) driver for X1E80100") > Cc: stable@vger.kernel.org > Signed-off-by: Krishna Chaitanya Chundru > --- > drivers/clk/qcom/gcc-x1e80100.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-x1e80100.c b/drivers/clk/qcom/gcc-x1e80100.c > index e46e65e631513e315de2f663f3dab73e1eb70604..d659d988660ea5e548fcae6f9f2a9a25081e6dda 100644 > --- a/drivers/clk/qcom/gcc-x1e80100.c > +++ b/drivers/clk/qcom/gcc-x1e80100.c > @@ -6490,7 +6490,7 @@ static struct gdsc gcc_pcie_0_tunnel_gdsc = { > .pd = { > .name = "gcc_pcie_0_tunnel_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, > .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, > }; > > @@ -6502,7 +6502,7 @@ static struct gdsc gcc_pcie_1_tunnel_gdsc = { > .pd = { > .name = "gcc_pcie_1_tunnel_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, > .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, > }; > > @@ -6514,7 +6514,7 @@ static struct gdsc gcc_pcie_2_tunnel_gdsc = { > .pd = { > .name = "gcc_pcie_2_tunnel_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, > .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, > }; > > @@ -6526,7 +6526,7 @@ static struct gdsc gcc_pcie_3_gdsc = { > .pd = { > .name = "gcc_pcie_3_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, > .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, > }; > > @@ -6550,7 +6550,7 @@ static struct gdsc gcc_pcie_4_gdsc = { > .pd = { > .name = "gcc_pcie_4_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, > .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, > }; > > @@ -6574,7 +6574,7 @@ static struct gdsc gcc_pcie_5_gdsc = { > .pd = { > .name = "gcc_pcie_5_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, > .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, > }; > > @@ -6610,7 +6610,7 @@ static struct gdsc gcc_pcie_6a_gdsc = { > .pd = { > .name = "gcc_pcie_6a_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, > .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, > }; > > @@ -6622,7 +6622,7 @@ static struct gdsc gcc_pcie_6b_gdsc = { > .pd = { > .name = "gcc_pcie_6b_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, > .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE | VOTABLE, > }; > > Retitle patch "Switch PCIe GDSCs to retention mode" you're really telling firmware to switch these GDSCs to retention mode in suspend - "power collapse" might be a better word. Anyway I think you should switch from a "don't switch off" to a positive and more accurate description of what you're doing which is switching the GDSCs to retention mode. With that Reviewed-by: Bryan O'Donoghue For the series. --- bod