From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8C31234D1B for ; Tue, 14 Jan 2025 13:01:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736859702; cv=none; b=PoR+7KUUnJdLc680mM0Ur6MKNIljpt8YRkP1fxiYndPtaOJkLy55VlSCGA1c8LIi3mWRa7q/dY1mtDtUrIULPUO1lnPHNukkU5Ryc2O5W7ryBxGfkGh1keQkSwgsRmWmFJMdjg1EvZFP2KqU0BITqiuf71nBV5vF0wqWSPJTeqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736859702; c=relaxed/simple; bh=X6+hy3bm9YGa2Hh8E9VLf9TSipUa87KULSkZWh/eFUw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ripg8VwzsLF02Mzd5FVRpANQa3CEo39s+J7B8OYN1ijee5ZXC7DOaaxR0cZVDxRdZl6v0jVr/hlTKsPo5Zvz6BgHjBGrh+sfbVSBaYlwdjtLTorQcbhmfbRSXyYvQ5MpP4eS7I3VVFI2sTtpOrQK8qw9NkMY3bDuzOQRHoI6kE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Svyjt9to; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Svyjt9to" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736859699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=D7Mb75OxjvrF+ArafgRMgUX+yMhQxtIxTCIZZ+mf518=; b=Svyjt9toQOiYaqhGHlVYHyCskhzLv/3DzeWf5iNfi4gQeZBO+VCmxPBar2ZnLMd3zRJ17D C4fUo2txmvMUbnazMz+xPjmPxaNrVSuzQwZy85NNMgk+JIxF3fz39RqH6IZdz0eRnonbEV YRYpxPplQYUBe7ApkqWxL30/Oel/Qfs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-PNtD7RyIPYyZjVMJoF4g6Q-1; Tue, 14 Jan 2025 08:01:38 -0500 X-MC-Unique: PNtD7RyIPYyZjVMJoF4g6Q-1 X-Mimecast-MFC-AGG-ID: PNtD7RyIPYyZjVMJoF4g6Q Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3862c67763dso2103568f8f.3 for ; Tue, 14 Jan 2025 05:01:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736859696; x=1737464496; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=D7Mb75OxjvrF+ArafgRMgUX+yMhQxtIxTCIZZ+mf518=; b=wEDC8Ajsv+QpvaSozNsaGXVKGcLQYlVZiverX+o4T/KynXedtJmA94aauJ9iiX7Cok oaBJEqeM6JTRK6IS4wi0UBvkWuJ1CnOzKU/vPTqMMAsXQCA7I4NSs0JdF4xkWZK8f+8C g/JolITwel5siFJZLZ7LQSgmoWrEQJ6QpOpjQOUlAYIGnlmOib2KaZ3ARifUJ4fvBrI3 X0tdLfaJIs9B8O8HkghV79FEESnt+HOfCLTWgW98cqp9adnBqr1AvDtv2OBoWcLbh4qN 4uQOSoyhSJDpRgKMDB5phIjZxIESiBvBW4hHLGwMg144+URdSQRjGBmxjSzpUOfRMyn+ F1ow== X-Forwarded-Encrypted: i=1; AJvYcCXWJ88+69/SGcp49ogWLceZZIufkquxAgPT0P4dUsR1iQJ12nvay+LYN8JIiDnunaBtmtHcB7Ee+76wUtQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzlSKlj95vFQ7XYt8jFzMw9sylsI7u07NiEYRqvpuBD+fPeCPWh 79Zy2HiRsnOdmfcbasHREhlcod7RSQ9E2Ba1YHWuFF/DJ8iBSr14m3LK7pQ9e573SRnvDU9zSDr 0RZyvFbImuyGX/+04XHhVAtvUaeRjbNXDFiHdsf/DEWzsqFFvVIz8sFZv7CNhIw== X-Gm-Gg: ASbGncu1T7O6s77X9iyBX9Et8woVRzuRknGeGkt0Q2zCGuNsT+mIlsn1T8eJlQ9OhwG QgvZm0727QoF8yyGh/DJ+uu9NxFbRweHD0xE4441mPkMxczZWTS8JiZFDT3IVabQnACoDvN9n4x TNmTID2iH46DLtk13Fpevp0dLnrWzUv4jnL/7uzABl6wO4dD9IQhPgt1DsfSMw+WRQGHOgvMbq0 aztZKSA16RqtRDRcIWjcOWGph6s0bd8BF/6KpmMKXOLILcz5ELSy6/v3vEfBjzt3ds5L15ATj5u 2dBXfXkk/MYgq+T8JNXOerzc00e2pGSqYWRh2hDCbCQ25uzMKeNIx0xR8lSHt+jr3IbCsckl1sA U2j++23UR X-Received: by 2002:adf:ab0c:0:b0:38a:8888:c0ef with SMTP id ffacd0b85a97d-38a8888c2eemr14523725f8f.52.1736859695788; Tue, 14 Jan 2025 05:01:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGo61YqNgL/O0HKghMG0jXutVQrMS872t9xH/PMkGyjywCSAzRQ2OLWrSuU9QDhRDOtdT2dnA== X-Received: by 2002:adf:ab0c:0:b0:38a:8888:c0ef with SMTP id ffacd0b85a97d-38a8888c2eemr14523686f8f.52.1736859695191; Tue, 14 Jan 2025 05:01:35 -0800 (PST) Received: from ?IPV6:2003:cb:c738:3100:8133:26cf:7877:94aa? (p200300cbc7383100813326cf787794aa.dip0.t-ipconnect.de. [2003:cb:c738:3100:8133:26cf:7877:94aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e37d050sm15078092f8f.15.2025.01.14.05.01.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 05:01:34 -0800 (PST) Message-ID: <08e7f845-6b86-4fdc-830d-23f15ad90475@redhat.com> Date: Tue, 14 Jan 2025 14:01:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] /dev/zero: make private mapping full anonymous mapping To: Yang Shi , arnd@arndb.de, gregkh@linuxfoundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, willy@infradead.org, liushixin2@huawei.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250113223033.4054534-1-yang@os.amperecomputing.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250113223033.4054534-1-yang@os.amperecomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13.01.25 23:30, Yang Shi wrote: > When creating private mapping for /dev/zero, the driver makes it an > anonymous mapping by calling set_vma_anonymous(). But it just sets > vm_ops to NULL, vm_file is still valid and vm_pgoff is also file offset. > > This is a special case and the VMA doesn't look like either anonymous VMA > or file VMA. It confused other kernel subsystem, for example, khugepaged [1]. > > It seems pointless to keep such special case. Making private /dev/zero> mapping a full anonymous mapping doesn't change the semantic of > /dev/zero either. > > The user visible effect is the mapping entry shown in /proc//smaps > and /proc//maps. > > Before the change: > ffffb7190000-ffffb7590000 rw-p 00001000 00:06 8 /dev/zero > > After the change: > ffffb6130000-ffffb6530000 rw-p 00000000 00:00 0 > Hm, not sure about this. It's actually quite consistent to have that output in smaps the way it is. You mapped a file at an offset, and it behaves like an anonymous mapping apart from that. Not sure if the buggy khugepaged thing is a good indicator to warrant this change. -- Cheers, David / dhildenb