From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753377AbdFMPpf (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Jun 2017 11:45:35 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:53766 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750899AbdFMPpe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Jun 2017 11:45:34 -0400
Subject: Re: [PATCH net] net: phy: Fix MDIO_THUNDER dependencies
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Cc: arnd@arndb.de, Andrew Lunn <andrew@lunn.ch>,
        open list <linux-kernel@vger.kernel.org>
References: <20170613001852.10073-1-f.fainelli@gmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
Message-ID: <08ec75c3-8d0d-c543-5d42-46feb6522ba6@infradead.org>
Date: Tue, 13 Jun 2017 08:45:29 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <20170613001852.10073-1-f.fainelli@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/12/17 17:18, Florian Fainelli wrote:
> After commit 90eff9096c01 ("net: phy: Allow splitting MDIO
> bus/device support from PHYs") we could create a configuration where
> MDIO_DEVICE=y and PHYLIB=m which leads to the following undefined
> references:
> 
>  drivers/built-in.o: In function `thunder_mdiobus_pci_remove':
>>> mdio-thunder.c:(.text+0x2a212f): undefined reference to
>>> `mdiobus_unregister'
>>> mdio-thunder.c:(.text+0x2a2138): undefined reference to
>>> `mdiobus_free'
>    drivers/built-in.o: In function `thunder_mdiobus_pci_probe':
>    mdio-thunder.c:(.text+0x2a22e7): undefined reference to
> `devm_mdiobus_alloc_size'
>    mdio-thunder.c:(.text+0x2a236f): undefined reference to
> `of_mdiobus_register'
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/net/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index c360dd6ead22..3ab6c58d4be6 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -127,6 +127,7 @@ config MDIO_THUNDER
>  	tristate "ThunderX SOCs MDIO buses"
>  	depends on 64BIT
>  	depends on PCI
> +	depends on !(MDIO_DEVICE=y && PHYLIB=m)
>  	select MDIO_CAVIUM
>  	help
>  	  This driver supports the MDIO interfaces found on Cavium
> 


-- 
~Randy