From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A078A477E51 for ; Thu, 24 Sep 2026 18:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790275231; cv=none; b=uLM3xyWPEjieFJzJhsF0QHiwkS2/eKIFWOtxhvML+nvWGs1hK8anCPTvbUKmZJpK+egAzA7fm3nfDCmK0yjfvkHRoGO7nBNbRkiETCiLi5CGmCnXmpRzfAhSSKq0tP1JeeBXkLNS5npmdfWUHOYJuQjJGlrAcMTl71gxNrAFwq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790275231; c=relaxed/simple; bh=d9MuZyyLSLcdIoM47CDB63qprl+1fFFPHmGIBwxSUAs=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jIIelqO9FCOGEzwsSecX/s9vfbBuRIQ5P1z6r7y/er620E7R4Nu7HA0btLkg+ddndzCpRlPfix7CIPoxGBmrBMzTjXqLjcm2Jnchl37jVPJPJOUCLmMvt0dxpP6c5rPagJrORQH8ziCz7hJP/faK7lMthsiKM1GZQvnV5AoF6hg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256:X25519MLKEM768) (Exim 4.100) (envelope-from ) id 1x9oMp-000000007Hb-0xP5; Thu, 24 Sep 2026 18:40:23 +0000 Date: Thu, 24 Sep 2026 19:40:20 +0100 From: Daniel Golle To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Allen Chen , Hermes Wu , Pin-yen Lin , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v7 03/14] drm/bridge: it6505: balance and disable runtime PM on remove Message-ID: <08ed0db0bebf3b1d91cd75f4746d4d611c1870bf.1790275151.git.daniel@makrotopia.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Runtime PM is enabled in probe but never disabled on remove, so rebinding the driver warns "Unbalanced pm_runtime_enable!". The extcon work also holds a usage reference while a display is connected, which unbinding leaks; the count survives in struct device, so after a rebind the device never runtime-suspends again. Drop the usage reference held for a connected display and disable runtime PM in remove(). Fixes: 10517777d302 ("drm/bridge: it6505: Adapt runtime power management framework") Signed-off-by: Daniel Golle --- v7: no changes v6: no changes v5: also drop the usage ref held for a connected display; retitled v4: new patch --- drivers/gpu/drm/bridge/ite-it6505.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 52d7d818a5ea..9c4aae383c1c 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -3663,6 +3663,9 @@ static void it6505_i2c_remove(struct i2c_client *client) cancel_work_sync(&it6505->hdcp_wait_ksv_list); cancel_delayed_work_sync(&it6505->hdcp_work); cancel_work_sync(&it6505->extcon_wq); + if (it6505->extcon_state) + pm_runtime_put_sync(&client->dev); + pm_runtime_disable(&client->dev); it6505_poweroff(it6505); it6505_remove_edid(it6505); } -- 2.55.0