From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3E4D38E113 for ; Thu, 2 Jul 2026 06:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782975219; cv=none; b=eNItfzq4oYLUnjQrlfK1mKVjTJkGh5BZ4+miMCop5CIf16e3XwaBwE72TiNQHs39Pxps6zpqhXQvcek86Pn3mE8pTyCtF6Sx+TIvmlFnPmnaU2dd3TOl/fCl1GLiX7qq+/D5F6OOK7zVhp1OZKV104rML/Xi8v9gV/cI3tSK3OM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782975219; c=relaxed/simple; bh=+4b3w6JmV1B0LZJw52j1qed3WNOp/NfO4qp3OK/aatM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WVvrJrhUEonRG5OfiFQVT2Buj8dnOmVE51qV8fyaoCqhTG/v2RsDbVVMPYKg/Uctg2sGtySvCDyj/tVxDAtSE878IQl4kViDH1NetRA9sawZUAAiVMfE+kz3qPWjdvnumRGuQpyZOxj16cYDpft4lgprIE21B19Z/xELAb/01xE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q1aSo5Fj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TNQ+Itdf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q1aSo5Fj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TNQ+Itdf" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6621KWcJ2917515 for ; Thu, 2 Jul 2026 06:53:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BHip0Kz7buAzWxIlIF8kUD1bXgXidWDoAhK1k+rP8l0=; b=Q1aSo5FjWCvGe4xm t/kmK2wpQ4rvcpgGyWYAh6HtsmUmb+YgJ/CrV4dsNOyzFTM0UGngY/ztD3R6lBfO tQ6IMttWxrdEi9/qGIB34BDYQyFVVT+obQguohRSyVLpVy1L1NkZ+H+89nRzGUdE r2ZQuFlgrK0xHIUoapaL27LxMX4F8KRytIYl7O0HDnMqc/P8IYY90It7eA+ZFS/l T86FauypaGcnnJEgKqA7EmDuD1BxBS6OBpDT/SQla2oSRg/I6TQ52enDvzcUQ/P5 Ixh9Tk2irHT3BIneZ20/gjAr/2Ra/CKx0BuPFND+cJmp0iLJhMers92901A99gR9 vZ2wNQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f53q0bh9v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 06:53:36 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-380b630c4e9so1090793a91.3 for ; Wed, 01 Jul 2026 23:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782975216; x=1783580016; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BHip0Kz7buAzWxIlIF8kUD1bXgXidWDoAhK1k+rP8l0=; b=TNQ+Itdfn3OB51EKHyfuW0JaXYuB7tfapNsW2WD7X5Tc9MmlQ5WmnGtFAyHnEXXUWb nXkx1u3NwzatgYfYkPNwg+EpyW63LgPoQHs+acZX9Wyy0AzpXeLSni3zgNCxLr3IRBzR JM9Yohx76QCM9qW+3szIfSSoHq2edegqwHpXYmX4UMvAjj26wYq4GMJXNSVv7v+zsJfz 8LlfjzeeT64MBTN/MtWzcr9Mya3kmkYZvwCEhaZb6okDPcLOusPWE/UKNGnCVoTdEonA lZNXXHH/DDgi0Xmg/BZKUwtQdmCICy0mfYNzJrshiqQfD96gXWunQzgtgAHCCerWI6Ba C79Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782975216; x=1783580016; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BHip0Kz7buAzWxIlIF8kUD1bXgXidWDoAhK1k+rP8l0=; b=hWrs86YdgGmLC4jKzCxZI7O8h7aNscYCSmH2sDPin9hwhovvgHc5Uj+NsXEdur8Z54 XqJzpFcX5e0fv07cuLCvFYPaEYEzjjQAVV86HrSqN3tx+UfU/KAOkkuovUgZicNP4JKo wOZwKrsSUa0A6ro5itdfdj6XAhDK22fS+gim8YadIsYG8DImXo9iqxu5rEmKNPab6rvu q4nITBSb+tu4WGsBKUcfcUIqOvTifm502x/jsfl/etHxCLygLQSGBn5XFNJ7GLaVdRMc osh/6KhSsQzwazrUCYY6poLe2MgINkx/d7l7YYumoAoNzYFNjIZGZDMK/RxGpEq+htJw UdEQ== X-Forwarded-Encrypted: i=1; AHgh+RpZqEjlESp1/fGVPQljX2npK4aKe4bCh4N4i6ejpRTWzN2r/NULwrzUy5Bzoot9JUvgAvHi7kCvfvc+Gjw=@vger.kernel.org X-Gm-Message-State: AOJu0YxT65P+tlVMqhp+c8MiwCrC92Bdw3EJ1+aWolSTSVU4fHDW9dal xLyLdDF+hWVbzvkXrIJ9vuOuETcXuHabg8Zw3h1hGeN2AxHt1HPtR9wF49iZ1sEEsB59SBANAAq Pp53e1DkaApLpv3j3iJiZRVSt+/DFhHIe9meAseKA+/gZSinj3Yue7o7AjQKwCFaIRL0= X-Gm-Gg: AfdE7ck5FUVQkXcXO+BlJ4WGCi7aF6Yv01XmhAQhL78VtPJ9CtleEzJ0zp+/POvkzq0 YbAsFAuJsxZwS2MziLaWd81GpFE4Ko7ru0Xk00k7G1/SL/YeLS6qyk9p0VmFU5AUlfD45ok0J5R 5nldCUaxPpHdAtlRi7s5fuSNjpuWsyeew9C+0LBJsRhZmrHb5xIpPouyyOUTYaO2b2tsjBuk+YJ uK4TZsclWn8TwNBVq+Z8MRuYK8kSvDXFarBQJLFN9PD+WVV3q4EHneQ85lp2oGfWzG54i55rLFo 7HCTzol5z9P+DcrmKGd5Kr5CMouMrA5lCsQG699ybfWiVOOvL8gwtCctx/z3CSdXcBN0QMt07pd etub7tebqgIxqCPSET6FmgZbFjttuoeDgVmJHVXj/ X-Received: by 2002:a17:90b:1844:b0:37f:c2a9:468 with SMTP id 98e67ed59e1d1-380baa6b497mr3981922a91.18.1782975216278; Wed, 01 Jul 2026 23:53:36 -0700 (PDT) X-Received: by 2002:a17:90b:1844:b0:37f:c2a9:468 with SMTP id 98e67ed59e1d1-380baa6b497mr3981881a91.18.1782975215737; Wed, 01 Jul 2026 23:53:35 -0700 (PDT) Received: from [192.168.1.6] ([182.77.29.27]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-380e1608b23sm551730a91.9.2026.07.01.23.53.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 23:53:35 -0700 (PDT) Message-ID: <08ed6b4d-5549-4aae-9967-1365db0e3aa2@oss.qualcomm.com> Date: Thu, 2 Jul 2026 12:22:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/2] arm64: dts: qcom: Add SD Card support for Shikra SoC To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Neil Armstrong , Wesley Cheng , Ulf Hansson , Kernel Team Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-mmc@vger.kernel.org, Nitin Rawat , Pradeep Pragallapati , Komal Bajaj References: <20260630165700.1886608-1-monish.chunara@oss.qualcomm.com> <20260630165700.1886608-2-monish.chunara@oss.qualcomm.com> Content-Language: en-US From: Monish Chunara In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dtnrzVg4 c=1 sm=1 tr=0 ts=6a460af0 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=1qKOYMtCOh3zOq8T1Y2cZw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=nutul9sAWFEbEiaF5vMA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: ypOMbDb4T_KpPL2TlGHQ7WPGQV-YyksQ X-Proofpoint-GUID: ypOMbDb4T_KpPL2TlGHQ7WPGQV-YyksQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDA2OSBTYWx0ZWRfXyaEW5kzhilpI 4VVVhn9jg5s2mnD1URhZXWGntTLRzggbkH/dpTkv6Mz96685JQiQVq2SYwHDxVJ3z1jEhGAQLY8 f3PqU6gjB9lF8sMYzsVwdo0h6MywC46ZWIzx6iKSDC6FFFJ4I/vfuFkkpZm4FubSE8woeQfOH2P 7CtIusUxbuQWmOHxF7gkY1ugpBKF56uAMnoBvuoxoWHOcTcW0bOOklWltxCeZUi7A/FK1TLgckL w64NGY63sX4KIH2qbt4uo7UomWqP+zn1xhm/GfWvymoH6K1wK3rDI0ONUz56FiTBFi1QGbN9pJD Pq7ujoYC6KukIFesSGp5pO/YLOtfQwEOlQqokPj2uFo2O71mfIshcmRD58CRgzPGSt44FbZcypS N1nU1+U05w7N/jxwf/VzTde5N/sDSfXc0eUZm38JTkZGr8hMPOlTthZIemjKMrvosL6VQ0SYcGu qwQHMstxAsr4kouoTdA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDA2OSBTYWx0ZWRfX4EEc+KZghQOx TkXdICmAvmuXNxD36+0bzLNobOKEPmEgN97zUz1jxGg1LjmMyTFltqXBvGiJ31U6YTR4Xn9+k5p BAyYCU2gBBijyyVsvns1c9/PwzHZV+M= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020069 On 7/1/2026 5:07 PM, Konrad Dybcio wrote: > On 6/30/26 6:56 PM, Monish Chunara wrote: >> Add support for SD card on Shikra SoC and enable the required pinctrl >> configurations. >> >> Signed-off-by: Monish Chunara >> --- > > [...] > >> + sdhc_2: mmc@4784000 { >> + compatible = "qcom,shikra-sdhci", "qcom,sdhci-msm-v5"; >> + reg = <0x0 0x4784000 0x0 0x1000>; > > Please pad the address part of reg to 8 hex digits with leading > zeroes, like all the other nodes > > otherwise > > Reviewed-by: Konrad Dybcio > > Konrad > ACK, Thanks. Will rectify in v3. Regards, Monish