From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44548C04AA7 for ; Wed, 15 May 2019 05:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D9B2216F4 for ; Wed, 15 May 2019 05:46:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726447AbfEOFqq (ORCPT ); Wed, 15 May 2019 01:46:46 -0400 Received: from mga06.intel.com ([134.134.136.31]:51202 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725781AbfEOFqq (ORCPT ); Wed, 15 May 2019 01:46:46 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2019 22:46:45 -0700 X-ExtLoop1: 1 Received: from linux.intel.com ([10.54.29.200]) by FMSMGA003.fm.intel.com with ESMTP; 14 May 2019 22:46:45 -0700 Received: from [10.252.16.172] (abudanko-mobl.ccr.corp.intel.com [10.252.16.172]) by linux.intel.com (Postfix) with ESMTP id 9ED8F5800CB; Tue, 14 May 2019 22:46:42 -0700 (PDT) Subject: Re: [PATCH v10 09/12] perf record: implement -z,--compression_level[=] option To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , Andi Kleen , linux-kernel References: <12cce142-6238-475b-b9aa-236531c12c2b@linux.intel.com> <9ff06518-ae63-a908-e44d-5d9e56dd66d9@linux.intel.com> <20190514200424.GB8945@kernel.org> From: Alexey Budankov Organization: Intel Corp. Message-ID: <08ee0c0f-fc4b-c8cb-4ab4-6f976d156004@linux.intel.com> Date: Wed, 15 May 2019 08:46:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190514200424.GB8945@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.05.2019 23:04, Arnaldo Carvalho de Melo wrote: > Em Mon, Mar 18, 2019 at 08:44:42PM +0300, Alexey Budankov escreveu: >> >> Implemented -z,--compression_level[=] option that enables compression >> of mmaped kernel data buffers content in runtime during perf record >> mode collection. Default option value is 1 (fastest compression). >> >> Compression overhead has been measured for serial and AIO streaming >> when profiling matrix multiplication workload: >> >> ------------------------------------------------------------- >> | SERIAL | AIO-1 | >> ----------------------------------------------------------------| > > Please don't have lines starting with --- in the cset comment log > message, breaks scripts, fixing it up now. Oops, will do my best about that. Thanks. ~Alexey > > - Arnaldo > >> |-z | OVH(x) | ratio(x) size(MiB) | OVH(x) | ratio(x) size(MiB) | >> |---------------------------------------------------------------| >> | 0 | 1,00 | 1,000 179,424 | 1,00 | 1,000 187,527 | >> | 1 | 1,04 | 8,427 181,148 | 1,01 | 8,474 188,562 | >> | 2 | 1,07 | 8,055 186,953 | 1,03 | 7,912 191,773 | >> | 3 | 1,04 | 8,283 181,908 | 1,03 | 8,220 191,078 | >> | 5 | 1,09 | 8,101 187,705 | 1,05 | 7,780 190,065 | >> | 8 | 1,05 | 9,217 179,191 | 1,12 | 6,111 193,024 | >> ----------------------------------------------------------------- >> >> OVH = (Execution time with -z N) / (Execution time with -z 0) >> >> ratio - compression ratio >> size - number of bytes that was compressed >> >> size ~= trace size x ratio >> >> Signed-off-by: Alexey Budankov >> --- >> tools/perf/Documentation/perf-record.txt | 5 +++++ >> tools/perf/builtin-record.c | 25 ++++++++++++++++++++++++ >> 2 files changed, 30 insertions(+) >> >> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt >> index 18fceb49434e..0567bacc2ae6 100644 >> --- a/tools/perf/Documentation/perf-record.txt >> +++ b/tools/perf/Documentation/perf-record.txt >> @@ -471,6 +471,11 @@ Also at some cases executing less trace write syscalls with bigger data size can >> shorter than executing more trace write syscalls with smaller data size thus lowering >> runtime profiling overhead. >> >> +-z:: >> +--compression-level[=n]:: >> +Produce compressed trace using specified level n (default: 1 - fastest compression, >> +22 - smallest trace) >> + >> --all-kernel:: >> Configure all used events to run in kernel space. >> >> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c >> index 2e083891affa..7258f2964a3b 100644 >> --- a/tools/perf/builtin-record.c >> +++ b/tools/perf/builtin-record.c >> @@ -440,6 +440,26 @@ static int record__mmap_flush_parse(const struct option *opt, >> return 0; >> } >> >> +#ifdef HAVE_ZSTD_SUPPORT >> +static unsigned int comp_level_default = 1; >> +static int record__parse_comp_level(const struct option *opt, >> + const char *str, >> + int unset) >> +{ >> + struct record_opts *opts = (struct record_opts *)opt->value; >> + >> + if (unset) { >> + opts->comp_level = 0; >> + } else { >> + if (str) >> + opts->comp_level = strtol(str, NULL, 0); >> + if (!opts->comp_level) >> + opts->comp_level = comp_level_default; >> + } >> + >> + return 0; >> +} >> +#endif >> static unsigned int comp_level_max = 22; >> >> static int record__comp_enabled(struct record *rec) >> @@ -2169,6 +2189,11 @@ static struct option __record_options[] = { >> OPT_CALLBACK(0, "affinity", &record.opts, "node|cpu", >> "Set affinity mask of trace reading thread to NUMA node cpu mask or cpu of processed mmap buffer", >> record__parse_affinity), >> +#ifdef HAVE_ZSTD_SUPPORT >> + OPT_CALLBACK_OPTARG('z', "compression-level", &record.opts, &comp_level_default, >> + "n", "Produce compressed trace using specified level (default: 1 - fastest compression, 22 - smallest trace)", >> + record__parse_comp_level), >> +#endif >> OPT_END() >> }; >> >> -- >> 2.20.1 >