From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0FB235E95C for ; Sun, 6 Sep 2026 16:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788712684; cv=none; b=MCanX37mV6N8dpbEIxvtKr1Tfbalz5JVkP7EpmF7u1UhmPL9J+f+eVqAgf5doCm/Q/TZGlh/DWfwFbM5XgHTzkNpKHEpgY7HmlT3QI6BeYSyDJ+BYoXXPL2HtQeoOxU0OAXQMooQAE9U5DwS1Tz5LGyfEGSRbhKcAJ0/cXejEY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788712684; c=relaxed/simple; bh=xZEc8ZW5YLh1fkmHxMW2xGQuFg33secRrvQSBF08CHA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tVxkSF0JCjepqNhcefko7VzbqsFKrIxE8u28hHHTgaGPo03BWyXarw08tt2Qgq2t+u4H0mHYHLq/gWKUv20McbwOtEuSAk1Obp9BotfIWCC6xSt+2QM0a4iuSIzT580cLfs7ySrno4qaV2FzvVNRs3XxpJ8fcAjymrQYpLQRW54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YBHVSWBX; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YBHVSWBX" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-482ea739de2so1733397f8f.0 for ; Sun, 06 Sep 2026 09:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788712681; x=1789317481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Zr4ziqFVq8nKF64tCdjpGyyZ2ASlabQVBOQtlNWXNp8=; b=YBHVSWBXiWfTJF2CSoLvZPkpIyFQg2sOuTp857rTrhTxZKR+hvsnKvlMBR/A+NH7/f tNCDwhWjVIM3ro5du6CFYZXUXB6xm9P/gN3XpQJ/KWyo8aEVsooeiXNPX+u58PxpUidd LnRoG8oYRMGwntao5RcuFi6r9pjsbfIzz+mKa8o79w0JFZzIv4uE1TKu6W13UMLn5zSk mGJuBw359lj6UMLrDoMvvz6cGo0HI7yn6eM4XL0oVwVkOkF7qqb9zBdjaqASyYwaTine OKfeqmlIewFAWqqrT5MzzdbprHRfPDLUTXKz3/BQBr61E9qt6VUkR2TMAd2HtWjRZZly /Buw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788712681; x=1789317481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Zr4ziqFVq8nKF64tCdjpGyyZ2ASlabQVBOQtlNWXNp8=; b=pCfLMDw+u+fELvRNp/Rn5GTQ5iwB4aciJE+o8gvuucexwi9mS78n9RJF2THxi3xUpc ITheHyu9acs2Y2COM666zdjhaEZIhUX9EA1ayeRsRuz2H7MuKQ3mUHwXRKIHP1GGa26k qe1s8xRlp1tEp0UoEi2ayOrAGcu1SMNcyWAWQqIASGONmH4VUqip8y/LFlBlaN/9DMxg pPgAvkZNguPlq62PN3hm5zp81BXl/Gby+XdbUI8z6/QYhhz+o9rEDRmqLCa/oTnrAEv2 r2U3qstR19dnUtExLcr63Mu/V9Hi36kyiYKfR1n624u3Q80wcMXww9gcKX73bQDZcjg5 QX5g== X-Forwarded-Encrypted: i=1; AKwUvByBf9Vbgzw/UnI5WiCdXZCTgt0CM3VaBxD8h+JgWgYNRoAnvO92hXw4wkRxSitzxe0bUCRA6P7sh8wirpo=@vger.kernel.org X-Gm-Message-State: AFuF++kXsXjH1rLrd9Tv4ur+k+am491R1VC1UeH6pffVg5zpg0yWBY2Y /j6VcZu0dHW1Wz/+i7lzJSm9UUJiXjKbSOPeIgqs1Fz9VvTPIi8KSSYZ X-Gm-Gg: AYBFou0Rt/tbjNDWFwfZ8RYtUNjv4qhX6Tv59DrbKBybMpnZMH1+0rbLBtoSwI9aLYA zg04EK9NEQXBW9edR29iPbsXPRjA85JheAPyw/VvQy7nGYi4zTCoqlqZwzRRfuRFWRdXuHB1goj AU+WMXXL/2adt/t6t0XX4zdZ/hMmSCYrJspNilT4Kwyjt8YCKjr7tsyHOTdqLFkFDsIjeuvDEY4 6Yf80IoVa2ymuxxG32D323qpADEtRZ86L+E7OMfcWLtHVEZ8Re088wrbW+RLhEsXenOP+5iIH7K ZRVw4Jzf3+uU2WdNqN4R4jhpvEh8hENPk3nZr2od+BQOc4CQSQEYTgiMToCKmMntmVzh5FIQIVR y4Su5JRoOyL4JTFIfQX3wSp2KCvv9mFxqlCchrhpUYyU9/ih+1hND+WD4otHqtnO71I1983h/QV QUBZ4MHgcQor1eG+UqmjRNFKnJawgGRM1oBx0hmNu6+kXOli/tj714A2OFb0QkD+64QXe+kmVqR zTn2HPpwsR0FjE8Al5B8c7coiU= X-Received: by 2002:a05:6000:27dc:b0:485:8eba:b5eb with SMTP id ffacd0b85a97d-4858ebab621mr8247866f8f.1.1788712681094; Sun, 06 Sep 2026 09:38:01 -0700 (PDT) Received: from localhost.localdomain (mob-5-93-26-136.net.vodafone.it. [5.93.26.136]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-485885c5bbdsm20907997f8f.36.2026.09.06.09.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2026 09:38:00 -0700 (PDT) From: Oleg Keri To: Catalin Marinas , Will Deacon , Mark Rutland , Beata Michalska , Sumit Gupta , Prasanna Kumar T S M , Russell King , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Sudeep Holla , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Viresh Kumar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org Subject: [PATCH v1 1/2] arm64: topology: fix arch_freq_get_on_cpu() overflow above 4.19 GHz Date: Sun, 6 Sep 2026 18:37:14 +0200 Message-ID: <08ee55292c1cedf26067d1a2b02fa5657d9650e8.1788712186.git.okerixx@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit arch_freq_get_on_cpu() computes the product of the frequency scale and the reference frequency as a u64, but assigns it to an unsigned int before shifting it back down: freq = scale * arch_scale_freq_ref(cpu); freq >>= SCHED_CAPACITY_SHIFT; The product is truncated to 32 bits before the shift, so the result wraps once arch_scale_freq_ref() exceeds 2^32 / SCHED_CAPACITY_SCALE, i.e. 4194304 kHz. On a Snapdragon X2 Elite (Glymur) laptop, whose boost OPP is 4723200 kHz, cpuinfo_avg_freq reports 524283 kHz instead of ~4723200 kHz while the CPU demonstrably runs at the boost frequency: a fixed workload completes in 1.72 s at the 4723200 kHz OPP versus 2.01 s at 4032000 kHz, matching the 1.171 frequency ratio. Keep the arithmetic in 64 bits until after the shift. Fixes: 16d1e27475f6 ("arm64: Provide an AMU-based version of arch_freq_get_on_cpu") Signed-off-by: Oleg Keri --- arch/arm64/kernel/topology.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c index d28438f8b83f..804758eeb63a 100644 --- a/arch/arm64/kernel/topology.c +++ b/arch/arm64/kernel/topology.c @@ -245,8 +245,9 @@ int arch_freq_get_on_cpu(int cpu) * (see amu_scale_freq_tick for details) */ scale = arch_scale_freq_capacity(cpu); - freq = scale * arch_scale_freq_ref(cpu); - freq >>= SCHED_CAPACITY_SHIFT; + scale *= arch_scale_freq_ref(cpu); + scale >>= SCHED_CAPACITY_SHIFT; + freq = scale; return freq; } -- 2.55.0