From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 724AC3EC805 for ; Thu, 30 Jul 2026 10:38:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785407886; cv=none; b=Lb7koPmtY/5SMYEEtEWp7kHqdgQ2cXZcXH5hZDGoAAzamC3oKQVBFcDG26SmNsQES6aCuYw3jNtwfnhNd/u8613UzUkmOg0KpEEcJcgo0V9swBfUdIxbEZhLpQUTUrX4JBPeFLl3EKPyvIBQQqxzFP9eIVvIf65bIs+l/iDkcSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785407886; c=relaxed/simple; bh=DaB1WD75GRknJfL9Bf2/hDlK7ZPpbPT2DAN88FkzR6U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T9xfSm0A2ANlDwzGjl9UTbpU++XXbSvdH58MQoMoSDUSvfsgmoe37WqIgD3l/eWdZReLHHos4u1WSxzzsgfotgGTRytU/o999gaFvxjsD7Bx39303Rlx1wTw1/XPxuOohDsWd1PWmuWQTlW+ecCz2v/Gpxtl5CTe005IvO0nHXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QM2cCVon; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=MuFs5J7t; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QM2cCVon"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="MuFs5J7t" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785407883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GgkmD2MutqWFU16wY7N+FGgugaCx8cxXpzUqUgToMPM=; b=QM2cCVongekUrUCni7pY2bWawkJiBhdzHzACX1WC+GioZiYhhMcwP+cKzdo77XOTbWoNSn FuCOF6bJJQmW1Zi0NYNpFzZRidt3uy4p7KvGV3w5nQKmWSTTlxZfLrY9ZIKpM3Pc1WwWdq A9RTk8/onydgz+u7BZu7EQNdXVJgd5g= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-I-6tDu8_Pp6orJHg8HfiWg-1; Thu, 30 Jul 2026 06:38:01 -0400 X-MC-Unique: I-6tDu8_Pp6orJHg8HfiWg-1 X-Mimecast-MFC-AGG-ID: I-6tDu8_Pp6orJHg8HfiWg_1785407881 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-490a767c7dcso15843115e9.2 for ; Thu, 30 Jul 2026 03:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785407880; x=1786012680; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GgkmD2MutqWFU16wY7N+FGgugaCx8cxXpzUqUgToMPM=; b=MuFs5J7tas7qiwjwWalBKjwHJOGcItBjMr1wJwMYj53oVU6tvJDIYkkayKj0gl+Hrs 2LjqgRUQ8cTcyIDtM96/zGkv35ZQLnoAPMZB5EhfxEXqOma8Jg4CsyKhiVAo82f3mLLo FXNUf7cMYfQecBip/s1/V96n0Rdy/ayLJpqDNcYzs5O9mFoydF/Qn8+VC1FZGY2xkKbu ToE5ta+v67YKI7Tq3ugcg+xzXqeMpoDNQkWpcgPpMNdpGuFys2oo1k4dk7oqG2XZc8HY ILA6kLXDX0l1uPuLufcXCL70HZ2uRj4egKq6F448RAV9CIkEEpZfSGHiz7COywdcziL7 9dNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785407880; x=1786012680; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GgkmD2MutqWFU16wY7N+FGgugaCx8cxXpzUqUgToMPM=; b=sTrRitKWbNXSozRQjL2EtB6+Qb2oeMrDT77Oo2KZZrQlPCVRImYLrN6WSHWtYlVYA3 jf4bzpjv2fd1HhNJTYUVRYqpd4ssoxoVmHC/gEz37t2oY3Nt0T6sWKAR62aKtCvE7uDj 7FAfphUUQPwIzkx6EFMCrpOdfCDt72SiQQkVaQCNihrgpGhgjzP6VpbC3ghvKClleXBp U8aOknNYPU0zLjbJ5gRSnhR6R2bhP4xJVMaasA8Ww/fkbfqVt0IImLiuwQnMunWzWSyB CwcgKRTCmJNBNFH4YLuIqitWXKYCxyShWjskffcfQQix1GKfUry0ARyzn7vVCFEGCwoP Lfiw== X-Forwarded-Encrypted: i=1; AHgh+RrPZibrIVjZkDiPQ7vD2WLbaswV8RVO9yrXoDOVia2PFXUaqxN/wprLISrHd54Rawlsv1teYkah/CdmaYI=@vger.kernel.org X-Gm-Message-State: AOJu0YyOt9HpgtAm5+p/lF+NjCHz9ilz7bXu6SPYAI5IjdcUz0SCZ+Uu gerkUc6hxqPP6Ddn/TcSbPxjDCVkhVrJko5Dr4PkuUj4l0z0afcWipJYj0KmXg/784Vp4Bgy6IN TRoHf/XumaQ5LPtlfqrbtCTwTHtT/zb+BgCx+mTYQA3dbe6P9OFJlBGVM7aIMrKBPAg== X-Gm-Gg: AR+sD12eP4G/w4EjoAzBMaUHth2krCRoHYuFBqsWDSF6Ad4XGc77vnyXIyEFRzPd55B /ofHfU6okjR676aMq8DwLBbAeIOBnduq/mKfy9LDCv4TEWS/x4e80k696eMAs9z/vi2VB8K+z7J izg1f/UQlg3xZS9boSwS8J0UMCAQL6cO3bnEcFo3+dVQZeGPGpfwr/DMjU5zkB71xMjjTfiMsR6 yl6/kiFGxRbzxFHJK6d+mcPqr+3a862tpXAsajVhfZcEdKaEg8+qm7+rE2w3hH8bv2pN4wTTCx7 tQZHP/wTbfy9kDo9M4dGYtG/JF6k9gIcPgtcTasGKpiORsFJBFo2xp70HbhI7+x1/zpAuJeKG7d cyLczj0HpPfCEFDbaY06CWorkOR9SBQ57zMB7Nq5IJsSc+ZuuDUbNXr3bglNKjzG2zy4urwZ/D3 6J9g== X-Received: by 2002:a05:600c:1d27:b0:495:518a:5cbf with SMTP id 5b1f17b1804b1-49800eb3d89mr25890305e9.32.1785407880669; Thu, 30 Jul 2026 03:38:00 -0700 (PDT) X-Received: by 2002:a05:600c:1d27:b0:495:518a:5cbf with SMTP id 5b1f17b1804b1-49800eb3d89mr25890105e9.32.1785407880249; Thu, 30 Jul 2026 03:38:00 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fc88d6f18sm4963983f8f.4.2026.07.30.03.37.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 03:37:59 -0700 (PDT) Message-ID: <08ff5f82-c7cf-4d6b-97bc-debe2957331a@redhat.com> Date: Thu, 30 Jul 2026 12:37:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 3/3] net: dsa: motorcomm: Add LED support To: David Yang , netdev@vger.kernel.org Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org References: <20260726162731.1005803-1-mmyangfl@gmail.com> <20260726162731.1005803-4-mmyangfl@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260726162731.1005803-4-mmyangfl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/26/26 6:27 PM, David Yang wrote: > +int yt921x_leds_setup(struct yt921x_priv *priv) > +{ > + struct device *dev = to_device(priv); > + struct dsa_switch *ds = &priv->ds; > + struct dsa_port *dp; > + u32 inv_ctrl = 0; > + u32 inv_mask = 0; > + u32 ctrl; > + u32 mask; > + int res; > + > + dsa_switch_for_each_port(dp, ds) { > + int port = dp->index; > + > + if (!dp->dn) > + continue; > + > + res = yt921x_leds_setup_port(priv, port, &inv_mask, &inv_ctrl); > + if (res) > + dev_warn(dev, "Failed to setup LEDs for port %d: %d\n", > + port, res); > + } Sashiko noted that at this point the leds are already exposed to the user-space and settings can be applied before the following take place. Also please note net-next commit c82ff94592fb /P