From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 848C915AD9C for ; Wed, 20 Nov 2024 13:37:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732109841; cv=none; b=IKxXCziBoXkXrieOkV1wq4lSN6lPPYVwcNTntYSSKZcEMCULUBfrRJt+2Kel+9+cZAgbPDB/SulqhTSCrn6lzlG3sNUiaOJWF0g7KIPDfXGe1cWqzoHY+rsUFc0zbtW9PaNtLFj91E0JpAz9Q3XAdB/Jqcw7qc+Q2e78lW3jclg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732109841; c=relaxed/simple; bh=6FprXMjqswhGDl5RcWUXC/xccCPsNOfntJbRecOImHI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aQ6TXr/tx6H4Hedm2lqeUaW7HrSM6WL416JwYhxnpt59GyESb60WvaHnbIXWgNsj9mngM5PN9alRdYr6OJ/NKWv21qJZpyKzDIECG28L7UsL40ffnAvFJI4UBKdhLapLildE48oqFlkCZH+pVNz5U7fJliw5w1yOjeAcC8Lo6e8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gBiTHzYl; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gBiTHzYl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732109838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aNhJXApteOStSWPJuT1kvuvcDkUdEqnM87tUpsplevc=; b=gBiTHzYlUmAfI92x9kXvuAh9+yrwAUnWBQlviHICQegCt6uVHZCLSMHtNA6XEgpbPTWTVK pgZjTzYIuyRuGKanQcuNElkLKSUqTL63FX4lIm3c09T2Rzm/ea2Vjx2n8xWRVl3QeBGtLI 8/0Z8Fao1WxMlPyeCSyzr8JwuGKZn64= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-UnDdOMc7OtmTi_lAiZSrAw-1; Wed, 20 Nov 2024 08:37:17 -0500 X-MC-Unique: UnDdOMc7OtmTi_lAiZSrAw-1 X-Mimecast-MFC-AGG-ID: UnDdOMc7OtmTi_lAiZSrAw Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-5cf735604aeso5006317a12.0 for ; Wed, 20 Nov 2024 05:37:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732109836; x=1732714636; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aNhJXApteOStSWPJuT1kvuvcDkUdEqnM87tUpsplevc=; b=BziMx1/RsEd1lBHnPllUX3wEjvyts5/Ih5PPHRFNkDa4+mBSN090bmUsoVXm22n4WG xeR1+H1uXPsHY+ziRPDzUzyWDJaRcJQUUlH+7rsBxAzkaHHmiaCrWiO2D/CpYFxGFOj2 FuI8ay2wbpeNlsyAFq+3bLrzDPWdHa+AxmSH34yxZQFG6xMZXY4suGYaY/utKnA1tsFc rCDxXAN/LLGRQ9JZVhDnfJEYc+c2POkwZirfUXWPRo8HTuzONTJEkLaeazdGb4X4rBZF 8SBQUTBBA1YltTYK0c+vYGfRqa2i46yRVX0qO+9fMTciglTg1H8A+NLeHx1vfPQuYwqO 2KSQ== X-Forwarded-Encrypted: i=1; AJvYcCVqXpezWVcIShICsHzsumNId32qVzuQ82891mcv65v2Z4Fz9N/N2cXKej650q0n5mAK8H1bEoTLGqsdSXc=@vger.kernel.org X-Gm-Message-State: AOJu0YxgUFHXNLrhbKoIUMfv4BfNXt2lf4t32CUMGEqtA/v/JtYOnl6e pKrqO6S7kcW/4vtQzQKQB097rGWQDtUJpkRMe0gNfdDC1W6HF2axFg02rNVuHJ73H6NaTscySl0 V4cWX00IMyomE4SalTo8ezofw9zLbLyzsHMEU5aifCNkWSGY1V9i6Csi63VljcA== X-Received: by 2002:a05:6402:2750:b0:5cf:eaf4:bc98 with SMTP id 4fb4d7f45d1cf-5cff4c4c6e9mr2244369a12.18.1732109835825; Wed, 20 Nov 2024 05:37:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDpT+7v1yvHlWIRPEUnC/zmFGXn6Hcf0ANGVYppQlHmpco+GHKLx7MCluM6uUyzlFWQKkJCw== X-Received: by 2002:a05:6402:2750:b0:5cf:eaf4:bc98 with SMTP id 4fb4d7f45d1cf-5cff4c4c6e9mr2244355a12.18.1732109835508; Wed, 20 Nov 2024 05:37:15 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cff4502155sm854390a12.53.2024.11.20.05.37.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Nov 2024 05:37:15 -0800 (PST) Message-ID: <08ffd5b3-8199-46bd-9db6-c52db5c3ca02@redhat.com> Date: Wed, 20 Nov 2024 14:37:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] media: uvcvideo: Add more logging to uvc_query_ctrl() To: Ricardo Ribalda , Laurent Pinchart , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sakari Ailus References: <20241118-uvc-readless-v3-0-d97c1a3084d0@chromium.org> <20241118-uvc-readless-v3-2-d97c1a3084d0@chromium.org> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20241118-uvc-readless-v3-2-d97c1a3084d0@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 18-Nov-24 6:16 PM, Ricardo Ribalda wrote: > If we fail to query the ctrl error code there is no information on dmesg > or in uvc_dbg. This makes difficult to debug the issue. > > Print a proper error message when we cannot retrieve the error code from > the device. > > Signed-off-by: Ricardo Ribalda Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/media/usb/uvc/uvc_video.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c > index e165850397a0..0195394e10b5 100644 > --- a/drivers/media/usb/uvc/uvc_video.c > +++ b/drivers/media/usb/uvc/uvc_video.c > @@ -110,8 +110,12 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8 unit, > error = *(u8 *)data; > *(u8 *)data = tmp; > > - if (ret != 1) > + if (ret != 1) { > + dev_err_ratelimited(&dev->udev->dev, > + "Failed to query (%s) UVC error code control %u on unit %u: %d (exp. 1).\n", > + uvc_query_name(query), cs, unit, ret); > return ret < 0 ? ret : -EPIPE; > + } > > uvc_dbg(dev, CONTROL, "Control error %u\n", error); > >