From: Joe Perches <joe@perches.com>
To: B K Karthik <bkkarthik@pesu.pes.edu>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [REPORT] False positive errors found while using scripts/checkpatch.pl
Date: Sun, 28 Jun 2020 07:53:41 -0700 [thread overview]
Message-ID: <09010c9aa795a8dcbd4408ceb2a39ddc57c85037.camel@perches.com> (raw)
In-Reply-To: <20200628140046.imqmf5vy2vvbwkzo@pesu-pes-edu>
On Sun, 2020-06-28 at 10:00 -0400, B K Karthik wrote:
> The following are reported while using checkpatch.pl on
> drivers/staging/fbtft/fbtft-bus.c
>
> ERROR: space prohibited before that close parenthesis ')'
> #65: FILE: drivers/staging/fbtft/fbtft-bus.c:65:
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
>
> ERROR: space prohibited before that close parenthesis ')'
> #67: FILE: drivers/staging/fbtft/fbtft-bus.c:67:
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
>
> These are false positives as correcting these issues breaks the build.
Thanks, there's no capability to recognize this in checkpatch.
checkpatch is not a compiler.
Perhaps a reasonable solution is to add a comment around the
macro uses that show it's an unusual case.
prev parent reply other threads:[~2020-06-28 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 14:00 B K Karthik
2020-06-28 14:53 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09010c9aa795a8dcbd4408ceb2a39ddc57c85037.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=bkkarthik@pesu.pes.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®