From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A58A372EF6 for ; Thu, 7 May 2026 14:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778162734; cv=none; b=P0HpYE7K9zFXVS2OCJ/6rZX0DOv9egNAKJP53ZEWZ+jK/HXd7JeXlzqPJkz5B3QrQnPpdPWwWW+LRg6+kgfhXMl83ejb/NebO+Xw/JRLzDs0ygmVz4hc7UzrEbYHB7ZaAElO95SWV20QeYf+mxbB+JpAQMtEnOAFem5cBKDw8O4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778162734; c=relaxed/simple; bh=VJeYUAA2309q9lgbKbdvm0r7x9iaF4653LBeP4JcpaI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AhzO7/rlTC0U9KvNkrMM2/xNKcYeClUe5Om2th3+9KxY6bU60Si5vATDLkkZ1PDNDTIiRi2sBwEZpuuxbiuDYAjqPkVIzJAahbaB9U7lpxmymqbAlAxD63u4ghTCC+ShZZG2ofOO07Nj5CB/RZnQaNfSCydg6ds5rgQPHKmek0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i0/AVF2H; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=awkKlNsq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i0/AVF2H"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="awkKlNsq" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647AJThQ150879 for ; Thu, 7 May 2026 14:05:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +BC6FDv/KCnHxFRu2JFlqNIRoVxvZm/nujJQr/xP2ew=; b=i0/AVF2HZDo/BLCb WvTrxhYA/bVoEZuS4GZc+d3L8vOAe+VW1AYGfT5VqQ/4dzbA7/BHCAUjM3Draws5 nXR2cPrSskwlYT/6Bl8SflTbYzKpdblgCQ4EzeV2AVMbFk4Nw+SsHjxnjPqs1cnT 81Y+5E6tvM1nv2c9CdbtUFVNss0W4Ev/7WItpilLA7O60BU0cs+HUu46R4Y2qMS/ gXd1v6CphbUbeolHiUZeGbN+3R+kkMu9WhylTuSg9DgTrMorCBFbqjGc/EDyLoZg wfS3WeJJsgHDDew3ILgRQZ89oEr/DHkgKo0gdTvjw4fiOkbRSOdeLYyjDob+ikV0 xu7rKQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kctt56b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 14:05:32 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-364c0e269e5so1135893a91.2 for ; Thu, 07 May 2026 07:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778162731; x=1778767531; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+BC6FDv/KCnHxFRu2JFlqNIRoVxvZm/nujJQr/xP2ew=; b=awkKlNsqpNRWTWbB9AkP3QRjKM1Z5ji9z2OucOjVs9fyGV++FeqijZJML4ODibjOMu DF5tICXJr72aKC7q/TZu/khJOyPgFRNA3DHKs3O4zQdWGM0ruaqE5GjIbnPlS9hbq9Ss aXqssAw+PoSAaFx9kUWN7F8p6XiiZiKFfY5S8gRwT+XpPP2XR5Ghb8JxhJTux3cKAqKN lnuO77Jlg7pvbedgXyV0OMqllw96JzJjqGYmSBncd4Zw+yzoTWZTcfgiwDFhOO5BR8ya sKr2SuYidJQ3F2b+Fs7qWOvsG9FsIbDX8+CXqwvR1hCWGcSWFXRlG6Cbi3PDr+4UvuZl s1Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778162731; x=1778767531; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+BC6FDv/KCnHxFRu2JFlqNIRoVxvZm/nujJQr/xP2ew=; b=d8aRwloulzcakUl2lbPymceQuvAY6sCEsVFqtLXaBjf4r5O1rNOwswsgZqE9o8AWaP jIu7XvC/THdmfl0358N3vOvsE5qnp/Hxuu++JR7T6l/cKjEZaNgW2TQ/3/jEyTZD9/nJ AUPMpp/ecmlQ+FT9HsJq6LjtqHl7fdH2n10q4m0NGWO6+230Q/1Jy8TWYnj88OGlWUMf oX0G8VJ6xQpSApw3in/XDGHlFySjdRp5RThjm8Ub7xLrte+ObTS9okAN3+mkD/RrNoHv Zf1nxBUtcKaWidS5WuCFov320ApiwOV2hs1s/zXyP9zooNFESkM4oLy54OY1HGfoY8zn IWKg== X-Forwarded-Encrypted: i=1; AFNElJ+HpTSpaGUxQLcuJ67yOUSjUMkXaocb9EDu3OWakC8v/UlsS+nC0KdPt8fe0ZiG9eizAV2ysWg0EZ6uFGg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxb6XKZDHwqoYuoLyBnYdqsUARhxPu8ui+WMpn3umWYciNjJfVg jqCbY+IEOsoOeFvzRtT1IlWcYGdFZx+6t/ggGAWylGAU4bIapV5stDmpn12M+bZ+jcU6EgWu3CO t+DTk36+Dq9e5+Te8j2NZwempVEDMWzZaVScGFKn66rQo7YgSoqkOsM+JRMCWf7GWDC8= X-Gm-Gg: AeBDievApxv8rVwjglW3vvDcwzUiVrMRrI5oxhaZ44+VPoUMki9DxUFKi5xy+h5/6v5 bZCF3W3X+II4YAS9hxlPfoK69FTdKxMTtLRNC4r3/Qc5xsCCR9xHE1sr6c83D02+0Nj7s3vKBgk WiPT4FNbYJNgjVsLx05fPhNoPzwHvUVpVrL11/O2nmpCMJeTn9gobTI7kkAZ3wMYMDgTfCifTtn 1xRqQMRhxXmBdc8o2EG2Z94x9iWjIvcCgnF3CpmJ7aFXqOU5/0a6+95iBSe1aUmQmQWI7wVcbtg ZCTUwcsVSgH+tkZB6Ecun8DZq4vkQDQke9qOu6Jv7/0DMKLXja1tTSBEUxy2vlfzibG0AprLDqM HvcG5LSqJOENgAnzv++vAqKnFoCPey0OnJWhuVioLQJrNqD3Xj7QIg1E= X-Received: by 2002:a17:90b:2f4e:b0:35d:a0b7:9608 with SMTP id 98e67ed59e1d1-365abadd261mr7941365a91.7.1778162731054; Thu, 07 May 2026 07:05:31 -0700 (PDT) X-Received: by 2002:a17:90b:2f4e:b0:35d:a0b7:9608 with SMTP id 98e67ed59e1d1-365abadd261mr7941240a91.7.1778162729807; Thu, 07 May 2026 07:05:29 -0700 (PDT) Received: from [10.206.103.12] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-365b4bd8debsm6158400a91.2.2026.05.07.07.05.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 07:05:29 -0700 (PDT) Message-ID: <09031221-51cd-4a6e-b87e-f2d8290f8ac2@oss.qualcomm.com> Date: Thu, 7 May 2026 19:35:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/29] drm/msm/adreno: use qcom_ubwc_version_tag() helper To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> <20260507-ubwc-rework-v4-6-c19593d20c1d@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <20260507-ubwc-rework-v4-6-c19593d20c1d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=XsPK/1F9 c=1 sm=1 tr=0 ts=69fc9c2c cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=GMbUkbxl-BqPewUEXpgA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: ERc3WaJK89w9DfO1cDLL3hdisvBM7zKS X-Proofpoint-ORIG-GUID: ERc3WaJK89w9DfO1cDLL3hdisvBM7zKS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDE0MCBTYWx0ZWRfX12826kbUou10 Kru88llzmX2VqAroUhNuOIprJNV3LttqNO9Rm7D3uvQu+I+9nOgdRRfwBG02w/a7f+WRjgk+y+8 StF715OKtLrBvom9j6B3vSoVRi0DGG9zqSZamkt891wszhgxvKUMNvHmF3gblsJYJ7DAh6dkTKW r10abTMGn6TNE/muRxa4o04pBnlTJHJBho5v33b8mV/yvLUeKQ7Rq9lnja5FpGskpoP1Cpma4n+ A2ucpHsCjYGGeKiGy7STQZl1IxfSWErdlqNKRmDoI3RQtlN8HiSfOmCNsHub1vBESOXfvlSyu4S gAicavekgB5THskhIUHGM7gzy4DxD2kJsOEgjH0iNJXZywj2XChYBMOV/Xpqt0SeLrr4O1ONBPA vmjeB9u80oVV/px62ufN/UqDzRew35rmqS8mrRLYngI6WM7oLmAiR3ICCeHdse7omhrhMXXc4F9 Ez0H7NUQfVeg57EITwg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070140 On 5/7/2026 6:33 PM, Dmitry Baryshkov wrote: > Use new helper defined to program UBWC version to the hardware. > > Reviewed-by: Konrad Dybcio > Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen -Akhil > --- > drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > index ccfccc45133f..1923f904d37d 100644 > --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > @@ -282,35 +282,33 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) > bool rgb565_predicator = false, amsbc = false; > bool ubwc_mode = qcom_ubwc_get_ubwc_mode(cfg); > u32 ubwc_version = cfg->ubwc_enc_version; > - u32 hbb, hbb_hi, hbb_lo, mode = 1; > + u32 hbb, hbb_hi, hbb_lo, mode; > u8 uavflagprd_inv = 2; > > switch (ubwc_version) { > case UBWC_6_0: > yuvnotcomptofc = true; > - mode = 5; > break; > case UBWC_5_0: > amsbc = true; > rgb565_predicator = true; > - mode = 4; > break; > case UBWC_4_0: > amsbc = true; > rgb565_predicator = true; > fp16compoptdis = true; > rgba8888_lossless = true; > - mode = 2; > break; > case UBWC_3_0: > amsbc = true; > - mode = 1; > break; > default: > dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); > break; > } > > + mode = qcom_ubwc_version_tag(cfg); > + > /* > * We subtract 13 from the highest bank bit (13 is the minimum value > * allowed by hw) and write the lowest two bits of the remaining value >