From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751681AbdKYOvZ (ORCPT ); Sat, 25 Nov 2017 09:51:25 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32807 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbdKYOvX (ORCPT ); Sat, 25 Nov 2017 09:51:23 -0500 X-Google-Smtp-Source: AGs4zMYOSy74N5jI5Sf3wJF66I7jnho8Rdl2Q/aZmxXCKPTCxw6UEyE4OHBmhIEFPecoiCOZ0EDsNw== Subject: Re: [PATCH] nvmem: core: switch to device_property_present for reading property "read-only" To: Heiner Kallweit Cc: Linux Kernel Mailing List References: <02db961d-4293-8d67-431f-5bbfc97acc84@gmail.com> From: Srinivas Kandagatla Message-ID: <0906195e-0143-991d-7007-56012ddd4729@linaro.org> Date: Sat, 25 Nov 2017 14:51:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <02db961d-4293-8d67-431f-5bbfc97acc84@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the patch, On 25/11/17 11:56, Heiner Kallweit wrote: > Switch to more generic device_property_present to consider also non-DT > properties. > > Signed-off-by: Heiner Kallweit > --- > drivers/nvmem/core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c It looks good for me, I will queue it up! > index 5a5cefd12..ba0e3b453 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -444,7 +444,6 @@ static int nvmem_setup_compat(struct nvmem_device *nvmem, > struct nvmem_device *nvmem_register(const struct nvmem_config *config) > { > struct nvmem_device *nvmem; > - struct device_node *np; > int rval; > > if (!config->dev) > @@ -473,13 +472,12 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) > nvmem->priv = config->priv; > nvmem->reg_read = config->reg_read; > nvmem->reg_write = config->reg_write; > - np = config->dev->of_node; > - nvmem->dev.of_node = np; > + nvmem->dev.of_node = config->dev->of_node; > dev_set_name(&nvmem->dev, "%s%d", > config->name ? : "nvmem", > config->name ? config->id : nvmem->id); > > - nvmem->read_only = of_property_read_bool(np, "read-only") | > + nvmem->read_only = device_property_present(config->dev, "read-only") | > config->read_only; > > if (config->root_only) >