mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Emanuele Ghidoli <ghidoliemanuele@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Sebastian Reichel <sre@kernel.org>,
	Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: reset: POWER_RESET_TORADEX_EC should depend on ARCH_MXC
Date: Tue, 6 May 2025 15:23:00 +0200	[thread overview]
Message-ID: <091539c4-8ed1-46a4-aab5-8eb0e62a9027@gmail.com> (raw)
In-Reply-To: <1ef0beb1e09bf914650f9f9885a33af06772540d.1746536287.git.geert+renesas@glider.be>

On 06/05/2025 15:01, Geert Uytterhoeven wrote:
> The Toradex Embedded Controller is currently only present on Toradex
> SMARC iMX8MP and iMX95 SoMs.  Hence add a dependency on ARCH_MXC, to
> prevent asking the user about this driver when configuring a kernel
> without NXP i.MX SoC family support.
> 
> Fixes: 18672fe12367ed44 ("power: reset: add Toradex Embedded Controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/power/reset/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 5ce402ff71964f59..1a17c5192818de1e 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -218,6 +218,7 @@ config POWER_RESET_ST
>  
>  config POWER_RESET_TORADEX_EC
>  	tristate "Toradex Embedded Controller power-off and reset driver"
> +	depends on ARCH_MXC || COMPILE_TEST
>  	depends on I2C
>  	select REGMAP_I2C
>  	help

The default is 'N', and the EC is just an I2C device, unrelated to ARCH_MXC.
Is it really annoying if the user is asked about this driver during
configuration? Or is it just normal?
Wouldn't there be a better way to handle this?

  reply	other threads:[~2025-05-06 13:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 13:01 Geert Uytterhoeven
2025-05-06 13:23 ` Emanuele Ghidoli [this message]
2025-06-22 19:13 ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=091539c4-8ed1-46a4-aab5-8eb0e62a9027@gmail.com \
    --to=ghidoliemanuele@gmail.com \
    --cc=emanuele.ghidoli@toradex.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®