From: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: hamoa-iot-evk: Add backlight support for eDP panel
Date: Fri, 7 Nov 2025 10:35:52 +0800 [thread overview]
Message-ID: <09160a81-0a2d-4e9c-8710-3c172e07284a@oss.qualcomm.com> (raw)
In-Reply-To: <29ef2def-4073-4a77-8437-41cdfac2fa9d@oss.qualcomm.com>
On 11/6/2025 6:15 PM, Konrad Dybcio wrote:
> On 11/6/25 8:12 AM, Yongxing Mou wrote:
>> Previously, the eDP panel backlight was enabled via UEFI. Added backlight
>> control node in kernel DTS due to some meta may not enable the backlight.
>
> Adding the hardware description to the DT with the reason that some prior
> boot stage might not have taken care of it is not great
>
> How about:
>
> The backlight on the Hamoa IoT EVK is controlled through a PWM signal.
> Aligned with other x1e80100-based platforms: the PWM signal is controlled
> by PMK8550, and the backlight enable signal is handled by PMC8380.
>
> Describe the backlight device and connect it to the eDP panel to allow
> for brightness control
>
> Konrad
>
That's great. Thanks for your comments and suggestions. Will update the
commit message next version.
prev parent reply other threads:[~2025-11-07 2:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 7:12 Yongxing Mou
2025-11-06 8:43 ` Abel Vesa
2025-11-07 2:29 ` Yongxing Mou
2025-11-06 10:15 ` Konrad Dybcio
2025-11-07 2:35 ` Yongxing Mou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09160a81-0a2d-4e9c-8710-3c172e07284a@oss.qualcomm.com \
--to=yongxing.mou@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®