From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>,
Mostafa Saleh <smostafa@google.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Abel Vesa <abelvesa@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Subject: Re: [PATCH v2 2/3] interconnect: qcom: x1e80100: enable QoS configuration
Date: Mon, 7 Sep 2026 16:34:35 +0200 [thread overview]
Message-ID: <0916741e-442e-431a-9831-9457e3af1cf0@oss.qualcomm.com> (raw)
In-Reply-To: <86bja94234.wl-maz@kernel.org>
On 9/7/26 3:34 PM, Marc Zyngier wrote:
> On Mon, 07 Sep 2026 14:20:26 +0100,
> Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>>
>> On 9/7/26 10:49 AM, Marc Zyngier wrote:
>>> On Mon, 07 Sep 2026 09:18:38 +0100,
>>> Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com> wrote:
[...]
>>>> The current patch enable QoS for Hamoa SoC, which get programmed only during
>>>> driver probe. This shouldn't impact or cause any spurious resets once the
>>>> device is booted up and probe is successful.
>>>
>>> And yet it absolutely does break things.
>>>
>>> With this patch applied, the box resets within 5GB of heavy network
>>> traffic, probably because some transaction get delayed, and a watchdog
>>> fires. With the patch reverted, the box keeps receiving packets, and
>>> everything is hunky dory (100GB+ so far).
>>>
>>> Which makes me think that the set of hardcoded parameters in this
>>> patch is not universal at all.
>>
>> They are, provided the configuration is for the right SoC..
>
> Is x1e001de different from x1e80100? AFAIK, it is only a binned
> version of the same SoC. How do you explain the above regression?
I somehow skimmed over the fact you said it's on the devkit and not
on the mini-x mentioned before.
I pulled the Hamoa settings I could find, there are some updates but
none seem particularly related (maybe the PCIe one? I don't know how
the network card is connected), please give the attached patch a try.
If nothing else, please "bisect" the QoS additions until it stops
crashing. Although perhaps applying only some of the settings may
have its own set of dragons..
Compile-tested only
https://github.com/quic-kdybcio/linux/commits/topic/hamoa_purwa_qos
The Purwa icc patch is a bit of a mess because some nodes seem to have
moved around buses..
Konrad
next prev parent reply other threads:[~2026-09-07 14:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 5:37 [PATCH v2 0/3] Enable QoS configuration on X1E80100 Raviteja Laggyshetty
2026-05-27 5:37 ` [PATCH v2 1/3] dt-bindings: interconnect: qcom,x1e80100-rpmh: add clocks property to enable QoS Raviteja Laggyshetty
2026-05-30 9:55 ` Krzysztof Kozlowski
2026-05-27 5:37 ` [PATCH v2 2/3] interconnect: qcom: x1e80100: enable QoS configuration Raviteja Laggyshetty
2026-09-02 13:00 ` Mostafa Saleh
2026-09-07 8:09 ` Marc Zyngier
2026-09-07 8:18 ` Raviteja Laggyshetty
2026-09-07 8:49 ` Marc Zyngier
2026-09-07 13:20 ` Konrad Dybcio
2026-09-07 13:34 ` Marc Zyngier
2026-09-07 14:34 ` Konrad Dybcio [this message]
2026-09-07 16:50 ` Marc Zyngier
2026-09-08 5:00 ` Raviteja Laggyshetty
2026-05-27 5:37 ` [PATCH v2 3/3] arm64: dts: qcom: x1e80100: Add clocks for " Raviteja Laggyshetty
2026-08-31 20:21 ` (subset) [PATCH v2 0/3] Enable QoS configuration on X1E80100 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0916741e-442e-431a-9831-9457e3af1cf0@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=odelu.kukatla@oss.qualcomm.com \
--cc=quic_rjendra@quicinc.com \
--cc=raviteja.laggyshetty@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=smostafa@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®