From: Stafford Horne <shorne@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: openrisc@lists.librecores.org, Stafford Horne <shorne@gmail.com>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Al Viro <viro@zeniv.linux.org.uk>,
Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH 2/3] openrisc: fix issue handling 8 byte get_user calls
Date: Tue, 14 Mar 2017 23:56:27 +0900 [thread overview]
Message-ID: <0919e155a0de5d4e6fd8a70c56b8ee44eac37dd2.1489502779.git.shorne@gmail.com> (raw)
In-Reply-To: <cover.1489502779.git.shorne@gmail.com>
In-Reply-To: <cover.1489502779.git.shorne@gmail.com>
Was getting the following error with allmodconfig:
ERROR: "__get_user_bad" [lib/test_user_copy.ko] undefined!
This was simply a missing break statement, causing an unwanted fall
through.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
arch/openrisc/include/asm/uaccess.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/openrisc/include/asm/uaccess.h b/arch/openrisc/include/asm/uaccess.h
index 140faa1..1311e6b 100644
--- a/arch/openrisc/include/asm/uaccess.h
+++ b/arch/openrisc/include/asm/uaccess.h
@@ -211,7 +211,7 @@ do { \
case 1: __get_user_asm(x, ptr, retval, "l.lbz"); break; \
case 2: __get_user_asm(x, ptr, retval, "l.lhz"); break; \
case 4: __get_user_asm(x, ptr, retval, "l.lwz"); break; \
- case 8: __get_user_asm2(x, ptr, retval); \
+ case 8: __get_user_asm2(x, ptr, retval); break; \
default: (x) = __get_user_bad(); \
} \
} while (0)
--
2.9.3
next prev parent reply other threads:[~2017-03-14 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 14:56 [PATCH 0/3] Openrisc fixes for 4.11 Stafford Horne
2017-03-14 14:56 ` [PATCH 1/3] openrisc: xchg: fix `computed is not used` warning Stafford Horne
2017-03-14 14:56 ` Stafford Horne [this message]
2017-03-14 14:56 ` [PATCH 3/3] openrisc: Export symbols needed by modules Stafford Horne
2017-03-14 15:25 ` [OpenRISC] " Geert Uytterhoeven
2017-03-14 22:17 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0919e155a0de5d4e6fd8a70c56b8ee44eac37dd2.1489502779.git.shorne@gmail.com \
--to=shorne@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openrisc@lists.librecores.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®