From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31D2F1A6838 for ; Sun, 28 Jun 2026 08:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782634214; cv=none; b=NFnKuGgYyYN474peZ0zvXLvT8XvqOxbPu611QTOKA65fDUiZTb8nzktJWGjRxyW0q3k8j+MnJ9iVIBeLElTC+zoURgZUj0ig0rmuX0jCQwViFYnHuC1yDpAMTp1HT5tbA76wO/3gcHgdS4iB1ytlb0EkhKjO50zfAjDgiRDL04s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782634214; c=relaxed/simple; bh=+h8xGZNKc6YXPq6khur0wts5VFgWcGZeZRtOQiFbhVo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=naLHqj2O4SHubGaPmhOtJxrJqf7Xfk6hzNyvHijQUM/rbbztQ9rqTjR4anLOyzXqtMzZkGjcBU4XKuX08x2YcVWarYRQo63pry1WHGmJ5Lwb13Dp6BmrpXExiAPfkHvVMwwUID3EhFMGG6D9nkmcqTUG4EX7fvUC0cz/30rIHTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Anemyp46; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Anemyp46" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DB151F000E9; Sun, 28 Jun 2026 08:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782634212; bh=+h8xGZNKc6YXPq6khur0wts5VFgWcGZeZRtOQiFbhVo=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Anemyp46licdNraBAijIiLoHkzo+1UQ1ZvdazvN64Cp/GwsR+z65ZrxMQjiwjHXVc W837L/70Q+eGDasLesbGIZL9TVpdaHlofdMoqQOTngYNJOG7ddT5t+N995tqxzzqYG 5EKIb0IKSRI7hXS731m4o4T8FKbld2Dth7yu1+gaogOoC2sBBCGbCRbfE/xTLVyNDE lTmtrsHTRgze45lCkDe9wx1XLziCCicvDQdfixCuKEFPVl8vky/od22TDk5Xw95ljc jt90KhqEC7ozcp3ktgZGSTWzwL4B44Li2F+3L2pUCaUhiCHYTEi02P1wQHXXcd0pA/ XSGveI9wUonog== Message-ID: <0925f783-1506-4a20-ab9a-3130c2f07ed3@kernel.org> Date: Sun, 28 Jun 2026 17:10:06 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/slub: serve slabobj_ext array from a strictly larger kmalloc cache To: "Vlastimil Babka (SUSE)" , Shakeel Butt Cc: Andrew Morton , Roman Gushchin , Hao Li , Christoph Lameter , David Rientjes , Suren Baghdasaryan , Usama Arif , Meta kernel team , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Danielle Costantino References: <20260625230029.703750-1-shakeel.butt@linux.dev> <62453403-954c-4cf1-8924-6d38184b0810@kernel.org> <09267187-6c85-438f-8791-4cce8d07892a@kernel.org> Content-Language: en-US From: Harry Yoo In-Reply-To: <09267187-6c85-438f-8791-4cce8d07892a@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------BzaDD78aLc9saRG7mpOf5UwL" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------BzaDD78aLc9saRG7mpOf5UwL Content-Type: multipart/mixed; boundary="------------MB4ESdZ0F3dP7cD36LoLmprx"; protected-headers="v1" From: Harry Yoo To: "Vlastimil Babka (SUSE)" , Shakeel Butt Cc: Andrew Morton , Roman Gushchin , Hao Li , Christoph Lameter , David Rientjes , Suren Baghdasaryan , Usama Arif , Meta kernel team , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Danielle Costantino Message-ID: <0925f783-1506-4a20-ab9a-3130c2f07ed3@kernel.org> Subject: Re: [PATCH] mm/slub: serve slabobj_ext array from a strictly larger kmalloc cache References: <20260625230029.703750-1-shakeel.butt@linux.dev> <62453403-954c-4cf1-8924-6d38184b0810@kernel.org> <09267187-6c85-438f-8791-4cce8d07892a@kernel.org> In-Reply-To: <09267187-6c85-438f-8791-4cce8d07892a@kernel.org> --------------MB4ESdZ0F3dP7cD36LoLmprx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 6/27/26 2:11 AM, Vlastimil Babka (SUSE) wrote: > Minimally I'd now want to only do that size bumping when allocation > profiling is enabled. Ideally that means both configured in and not boo= ted > with "never". > > We probably should have done that already in 280ea9c3154b2. I think we did already. obj_exts allocation triggered by memcg has __GFP_ACCOUNT, kmalloc type is KMALLOC_CGROUP, and so is_kmalloc_normal() should return false? Perhaps a comment above !is_kmalloc_normal() check would be nice. > Because AFAIU > memcg-only obj_exts array don't have this issue > (or maybe they do have the > [1] issue? Harry?). memcg-only obj_exts array doesn't have this issue and [1]. Because obj_exts are not accounted and so we can't allocate obj_exts from KMALLOC_CGROUP. --=20 Cheers, Harry / Hyeonggon --------------MB4ESdZ0F3dP7cD36LoLmprx-- --------------BzaDD78aLc9saRG7mpOf5UwL Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQQ1ub6gR5ogjaKRmOGXBN6rc5S1gUCakDW3gAKCRCGXBN6rc5S 1hS/AQCy7EgueIeApxj3Ba5w4CqMIJjhX+COkASUuiWXWDVJKwEAkgFpo8rzSL9j xjjPMOV/XhrXJF2zejmzwvdqjhlOTAM= =4FFO -----END PGP SIGNATURE----- --------------BzaDD78aLc9saRG7mpOf5UwL--