From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: barnabas.czeman@mainlining.org, Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alejandro Tafalla <atafalla@dnyon.com>,
Luca Weiss <luca@lucaweiss.eu>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios
Date: Tue, 2 Sep 2025 12:20:13 +0200 [thread overview]
Message-ID: <09281121-e8d9-439f-b094-9df817acfb00@oss.qualcomm.com> (raw)
In-Reply-To: <e9750a64c761c0e66a813e206696dc7f@mainlining.org>
On 9/1/25 8:32 PM, barnabas.czeman@mainlining.org wrote:
> On 2025-09-01 18:01, Bjorn Andersson wrote:
>> On Sat, Aug 30, 2025 at 11:59:30PM +0200, Barnabás Czémán wrote:
>>> Correct cd-gpios in xiaomi-daisy according to downstream sources
>>> it is using GPIO_ACTIVE_HIGH instead of GPIO_ACTIVE_LOW.
>>
>> Is the problem you're solving that the DT doesn't match downstream, or
>> that card detect doesn't work? Does it work after this patch, or is it
>> just aligned with downstream?
>>
>> Regards,
>> Bjorn
>
> Both, it was not matching with downstream and card detect was not working.
> It is working with this patch.
"things now work" is a more convincing argument than "copy downstream" when
constructing a commit message, the latter can usually make sense as a
sidenote
Konrad
prev parent reply other threads:[~2025-09-02 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 21:59 Barnabás Czémán
2025-09-01 16:01 ` Bjorn Andersson
2025-09-01 18:32 ` barnabas.czeman
2025-09-02 10:20 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09281121-e8d9-439f-b094-9df817acfb00@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=atafalla@dnyon.com \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaweiss.eu \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®