From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A0BC04EBF for ; Wed, 5 Dec 2018 13:03:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 525D020850 for ; Wed, 5 Dec 2018 13:03:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 525D020850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mentor.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727801AbeLENDj (ORCPT ); Wed, 5 Dec 2018 08:03:39 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:49895 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726937AbeLENDi (ORCPT ); Wed, 5 Dec 2018 08:03:38 -0500 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gUWq0-00024C-Mb from Akash_Gajjar@mentor.com ; Wed, 05 Dec 2018 05:03:36 -0800 Received: from [10.105.2.145] (137.202.0.90) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 5 Dec 2018 13:03:31 +0000 Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rockpro64 fix video output chain To: Oskari Lemmela , Rob Herring , Mark Rutland , Heiko Stuebner CC: , , , References: <20181201100817.20688-1-oskari@lemmela.net> <20181201100817.20688-3-oskari@lemmela.net> From: agajjar Message-ID: <09287391-d541-cddb-4168-55ca6fee3f16@mentor.com> Date: Wed, 5 Dec 2018 18:33:29 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2 MIME-Version: 1.0 In-Reply-To: <20181201100817.20688-3-oskari@lemmela.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/1/2018 3:38 PM, Oskari Lemmela wrote: > Rockpro64 is not able boot if kernel is compiled with > CONFIG_DRM_ROCKCHIP=m > > Enable Rockpro64 board HDMI output to fix issue. Hi Oskari, Could you please describe this issue in detail. I am not able to reproduce this issue if CONFIG_DRM_ROCKCHIP is compile in or as a loadable module at the same time hdmi node is present or not. > Signed-off-by: Oskari Lemmela > --- > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > index 5bd4d69914bd..be78172abc09 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > @@ -205,6 +205,13 @@ > status = "okay"; > }; > > +&hdmi { > + ddc-i2c-bus = <&i2c3>; > + pinctrl-names = "default"; > + pinctrl-0 = <&hdmi_cec>; > + status = "okay"; > +}; > + > &i2c0 { > clock-frequency = <400000>; > i2c-scl-rising-time-ns = <168>;