From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Eric Biggers" <ebiggers@kernel.org>, linux-kernel@vger.kernel.org
Cc: linux-crypto@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>
Subject: Re: [PATCH] crypto: crc32c - Remove more outdated usage information
Date: Tue, 17 Mar 2026 12:07:38 +0100 [thread overview]
Message-ID: <092c1681-c863-49fc-aa3a-5780532be8bd@app.fastmail.com> (raw)
In-Reply-To: <20260314173130.16683-1-ebiggers@kernel.org>
On Sat, 14 Mar 2026, at 18:31, Eric Biggers wrote:
> Remove information from the crypto/crc32c.c file comment that is no
> longer applicable now that nearly all users of CRC-32C are simply using
> the crc32c() library function instead. This continues the cleanup from
> commit 0ef6eb10f2e0 ("crypto: Clean up help text for CRYPTO_CRC32C").
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This patch is targeting crc-next.
>
> crypto/crc32c.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> diff --git a/crypto/crc32c.c b/crypto/crc32c.c
> index 1eff54dde2f74..c6c9c727b25b4 100644
> --- a/crypto/crc32c.c
> +++ b/crypto/crc32c.c
> @@ -1,10 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * Cryptographic API.
> - *
> - * CRC32C chksum
> + * crypto_shash support for CRC-32C
> *
> *@Article{castagnoli-crc,
> * author = { Guy Castagnoli and Stefan Braeuer and Martin Herrman},
> * title = {{Optimization of Cyclic Redundancy-Check Codes with 24
> * and 32 Parity Bits}},
> @@ -13,20 +11,10 @@
> * volume = {41},
> * number = {6},
> * pages = {},
> * month = {June},
> *}
> - * Used by the iSCSI driver, possibly others, and derived from
> - * the iscsi-crc.c module of the linux-iscsi driver at
> - * http://linux-iscsi.sourceforge.net.
> - *
> - * Following the example of lib/crc32, this function is intended to be
> - * flexible and useful for all users. Modules that currently have their
> - * own crc32c, but hopefully may be able to use this one are:
> - * net/sctp (please add all your doco to here if you change to
> - * use this one!)
> - * <endoflist>
> *
> * Copyright (c) 2004 Cisco Systems, Inc.
> * Copyright (c) 2008 Herbert Xu <herbert@gondor.apana.org.au>
> */
>
>
> base-commit: c13cee2fc7f137dd25ed50c63eddcc578624f204
> --
> 2.53.0
next prev parent reply other threads:[~2026-03-17 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 17:31 Eric Biggers
2026-03-17 11:07 ` Ard Biesheuvel [this message]
2026-03-17 16:30 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=092c1681-c863-49fc-aa3a-5780532be8bd@app.fastmail.com \
--to=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®